From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD3C7F48C for ; Mon, 9 Dec 2024 16:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733761120; cv=none; b=M3igLuPnmL+Y771tpsVd3xU3XzqAnI+AakIum2lv7sox+W+OmU8jJ0mtY2eNgvKN6IZFuLmuJip8THcpWEBi9OHZBULoZVfrNf9Bqq04jcQLmJx+Yv+ikBC/1BtwghlmNWfbZH8KbIuewhrwlEz5k/URXCaL9ooLOO9Eid+IHwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733761120; c=relaxed/simple; bh=fSNCrWFrXEos4egz/pHomrYC4jn5QtpL5TnMYHGA9Bc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tlGaeogtLcb76QxyEQE5WuZj+eBgQ3iQodQWPnA+Rxm060PnNksQNM8FlPAYrWMRSYw3Rkrj2mdRrEJS58zY8ou8RK0Hk/d/hPId/XeB14wh8WnzyKh9cJP/4wszc96WYDDGYyHBzN0eUrf1FFdrn8zd9RmUk66tEo2iZ9Bcmow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DBeEFtUb; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DBeEFtUb" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2164b662090so11210235ad.1 for ; Mon, 09 Dec 2024 08:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733761116; x=1734365916; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=CNEDZCEDJ89V6GT0W/IdPQ4y91lGhI+LxMiGhcLvg5o=; b=DBeEFtUbjZzeK8LSsc1NoUVMl+hw7LEopR7z0+iA4cqUM/ecem7mCIzW8C4g5c+TGO bxtvK3EjetQRZmToCncQO7SxpZpVAlttoyC2m+nqgonXQZnhBum20W521LqO9GRJEmIM fQgQoBdzhnorxdUpZgEaYk+ZDoUmtIlNNRZNay0OZ8JyW9ptS5kGtrBV5Czt1FNkbdWp f3FS29+bEm/j4JOS16ah3iWs/8B2yspFHR9NWXJDmWBFBF226J9bGOy2Sn+Vc7Uqf/RJ ikwSoblXix/bEwNCMjva5HYHexcXx502g4AoQQe5bp5MngYVyhZHaXdnHmh3LLdqYw40 p7Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733761116; x=1734365916; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CNEDZCEDJ89V6GT0W/IdPQ4y91lGhI+LxMiGhcLvg5o=; b=BGW08K28k5BFrgSF7JNIDC8epFjLUXin9f1WXMaOhGZvBPS6f5V4WVSUQ89dmWXx72 4qDlG35LqRjEDZeHoZK0v9AHc2jASqyWtNFX3ETJ4Znkalh+RIkjDhMvUzlJY0ZXatBW yvVjVfDJas76i+udFG375uvrAFTYfj5+2IPuMuYmgcDn/gLlLmimZWAQrakNKIpXvD9t jpaGwnW/cAOAdRT1kLStM0ckTw7g1VytU2JEusDu+azdouO6rs/sG26IGV+LzjLo+wNw uCWMjRwXPjYcjHdi4si8aU+6Uw062K0myA/0e3a6Tg6gEQ1ZUnZAVoP+hm1V4PEDb4z3 RKgg== X-Forwarded-Encrypted: i=1; AJvYcCXhHabBNcg0CT2+9VKmKFlkCEp3+EuWQCYnMzN1oZ4y0xTiHQduX6VGNOZvI9CK8ZM7FlvupDmAmrBIPHHg@lists.linux.dev X-Gm-Message-State: AOJu0Yy5gbyVRouSKNro+x/OxceXtwb+BsxuL1wGs8vKjgUwwj6BrGui ZkDYfWccgMuNVRzoEeGD/ZNK675H5Hcc0seDiOd1gEWXzdH7fxzK X-Gm-Gg: ASbGncsb2I44HcrivQI6J6OGpn4yGKbZBuUjs/pXlPgXhFTqJCZnx1X47Sg/yqIassV jQRvvlExObiEvwDmAEvYPCX4xfjTbJGOnkenJnyuTW4sUI4Do0/HoyPFkn/9Ej4jdxOVnTPu1r1 sQAdLUL8rVakK/rA9TRyQ3hbUdSw8o+q0UPNZfbuUb0k2VwV6AR2Rrv7XNaRr0vVLJC5RyCyE0o INvYI9jAglLaXgLEsI7k/3ayxcXIs8DT3p7hqQqwIcsJu5+QOBhL5aTnl8FvdEGKW2QW8ZXiBes X2bwzReg9lShJc9rbkVPVYc= X-Google-Smtp-Source: AGHT+IFv7hFtpOtz+AOqw6x/k7hfoa3fCUhVhTw2JNHH71STFUc4FNRpvBQnPTXqWSmRqD3Ama0NdQ== X-Received: by 2002:a17:902:d58f:b0:216:46f4:7e30 with SMTP id d9443c01a7336-21646f480e4mr81935225ad.43.1733761115435; Mon, 09 Dec 2024 08:18:35 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fd49c44e29sm2150519a12.46.2024.12.09.08.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 08:18:34 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Mon, 9 Dec 2024 08:18:33 -0800 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] staging: gpib: Fix i386 build issue To: Geert Uytterhoeven , Dave Penkler Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20241204162128.25617-1-dpenkler@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/9/24 08:01, Geert Uytterhoeven wrote: > Hi Dave, > > On Wed, Dec 4, 2024 at 5:21 PM Dave Penkler wrote: >> These drivers cast resource_type_t to void * causing the build to fail. >> >> With CONFIG_X86_PAE enabled the resource_size_t type is a 64bit unsigned >> int which cannot be cast to a 32 bit pointer. >> >> Disable these drivers if X68_PAE is enabled >> >> Reported-by: Guenter Roeck >> Closes: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@roeck-us.net/ >> Fixes: e9dc69956d4d ("staging: gpib: Add Computer Boards GPIB driver") >> Fixes: e1339245eba3 ("staging: gpib: Add Computer Equipment Corporation GPIB driver") >> Fixes: bb1bd92fa0f2 ("staging: gpib: Add ines GPIB driver") >> Fixes: 0cd5b05551e0 ("staging: gpib: Add TNT4882 chip based GPIB driver") >> Signed-off-by: Dave Penkler > > Thanks for your patch! > >> --- a/drivers/staging/gpib/Kconfig >> +++ b/drivers/staging/gpib/Kconfig >> @@ -50,6 +50,7 @@ config GPIB_CEC_PCI >> tristate "CEC PCI board" >> depends on PCI >> depends on HAS_IOPORT >> + depends on !X86_PAE > > !CONFIG_PHYS_ADDR_T_64BIT, to match the definition of phys_addr_t? > That would be wrong. It would disable the code for all 64-bit builds. The underlying problem is that the code uses a pointer to store the physical address. That doesn't work if sizeof(pointer) < sizeof(physical address), which affects systems with X86_PAE enabled. I have not seen the problem anywhere else. Guenter