Linux kernel staging patches
 help / color / mirror / Atom feed
From: Jeremy Dean Clifton <gservice341@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jeremy Dean Clifton <deaner92@yahoo.com>
Cc: Marc Dietrich <marvin24@gmx.de>,
	ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v2] staging: nvec: use guard(mutex) in nvec_write_sync()
Date: Thu, 15 Oct 2026 08:45:54 -0600	[thread overview]
Message-ID: <de94c8cd-0afc-4a35-bf81-019a8e4cc8e8@gmail.com> (raw)
In-Reply-To: <2026101335-expansive-veteran-c4d6@gregkh>

On 10/13/26 12:15 AM, Greg Kroah-Hartman wrote:
> On Mon, Oct 12, 2026 at 10:29:26PM +0000, Jeremy Dean Clifton wrote:
>> The three return paths of nvec_write_sync() each release
>> sync_write_mutex with explicit unlock calls.
>>
>> Use guard(mutex) to unlock the lock automatically on any return
>> path.
>>
>> This removes the three mutex_unlock() calls.
>>
>> No functional change.
>>
>> Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com>
>> ---
>> v2:
>>   - Reword the commit message to state the motivation and to make
>>     clear that removing the mutex_unlock() calls is the result of
>>     the change (Julia Lawall).
>> v1: https://lore.kernel.org/all/20261012171312.5998-1-deaner92@yahoo.com/
> 
> Please read the archives for why I will not take guard() rewrites of
> staging drivers (nor do I want to see you use a LLM in here either.)
> 
> sorry,
> 
> greg k-h

Hello Greg + Everyone,


It turns out that I was unknowingly subscribed to this list and started 
creating patches for the Outreachy group without ever having submitted 
an application to Outreachy. I just wanted to learn how to contribute to 
the Linux Kernel and I saw https://kernelnewbies.org/ as a direct 
connection to Outreachy.

While I am technically not part of this cohort, I can still review 
patches. What is preferred?

I assume that the same rules apply outside of Outreachy? No LLMs and no 
guard() rewrites.

Jeremy



  parent reply	other threads:[~2026-10-15 14:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20261012222926.7754-1-deaner92.ref@yahoo.com>
2026-10-12 22:29 ` [PATCH v2] staging: nvec: use guard(mutex) in nvec_write_sync() Jeremy Dean Clifton
2026-10-13  6:15   ` Greg Kroah-Hartman
2026-10-13 15:13     ` Jeremy Clifton
2026-10-15 14:45     ` Jeremy Dean Clifton [this message]
2026-10-15 18:04       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de94c8cd-0afc-4a35-bf81-019a8e4cc8e8@gmail.com \
    --to=gservice341@gmail.com \
    --cc=ac100@lists.launchpad.net \
    --cc=deaner92@yahoo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marvin24@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox