From: Joe Perches <joe@perches.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, straube.linux@gmail.com,
martin@kaiser.cx, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement
Date: Sun, 31 Oct 2021 21:31:20 -0700 [thread overview]
Message-ID: <df0f1d2a911acce47eb4525ff4791c751b72821a.camel@perches.com> (raw)
In-Reply-To: <7f406b96-fbfd-bd3e-182b-3ca8b3056635@gmail.com>
On Mon, 2021-11-01 at 09:58 +0530, Saurav Girepunje wrote:
> On 01/11/21 12:47 am, Joe Perches wrote:
> > On Sun, 2021-10-31 at 21:43 +0300, Pavel Skripkin wrote:
> > > On 10/31/21 21:10, Saurav Girepunje wrote:
> > > > Remove the goto statement from rtw_init_drv_sw(). In this function goto
> > > > can be replace by return statement. As on goto label exit, function
> > > > only return it is not performing any cleanup. Avoiding goto will
> > > > improve the function readability.
[]
> > > And just `return _SUCCESS;` here.
> >
> > And maybe one day s/_SUCCESS/true/ and s/_FAIL/false/
> > with appropriate conversions to bool
>
> Yes this is another improvement possible on this function.
Not just this function, globally in the driver.
next prev parent reply other threads:[~2021-11-01 4:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 18:10 [PATCH] staging: r8188eu: os_dep: remove the goto statement Saurav Girepunje
2021-10-31 18:43 ` Pavel Skripkin
2021-10-31 19:17 ` Joe Perches
2021-11-01 4:28 ` Saurav Girepunje
2021-11-01 4:31 ` Joe Perches [this message]
2021-10-31 19:17 ` Saurav Girepunje
2021-10-31 19:24 ` Pavel Skripkin
2021-10-31 19:27 ` Pavel Skripkin
2021-11-02 16:40 ` Saurav Girepunje
2021-11-02 20:20 ` Pavel Skripkin
2021-11-01 13:01 ` Greg KH
2021-11-02 16:30 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df0f1d2a911acce47eb4525ff4791c751b72821a.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox