From: Joe Perches <joe@perches.com>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Lucas Henneman <lucas.henneman@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: fix camelcase byData in card.c
Date: Sat, 06 Nov 2021 12:06:30 -0700 [thread overview]
Message-ID: <dfa9d7734dfc64263b30f29b4d23aab7d0683089.camel@perches.com> (raw)
In-Reply-To: <20211106184822.24242-1-tomm.merciai@gmail.com>
On Sat, 2021-11-06 at 19:48 +0100, Tommaso Merciai wrote:
> Replace camelcase variable "byData" into linux kernel coding style
> equivalent variable "data" in card.c.
> "by" prefix in hungarian notation stands for byte or unsigned char
[]
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
[]
> @@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
> priv->abyBBVGA[0] = 0x20;
> priv->abyBBVGA[2] = 0x10;
> priv->abyBBVGA[3] = 0x10;
> - bb_read_embedded(priv, 0xE7, &byData);
> - if (byData == 0x1C)
> + bb_read_embedded(priv, 0xE7, &data);
It might be nice to figure out what these register values are
and use #defines instead of hard coded values like 0xE7
> + if (data == 0x1C)
> bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
etc...
next prev parent reply other threads:[~2021-11-06 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 18:48 [PATCH v3] staging: vt6655: fix camelcase byData in card.c Tommaso Merciai
2021-11-06 19:06 ` Joe Perches [this message]
2021-11-13 9:16 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa9d7734dfc64263b30f29b4d23aab7d0683089.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.henneman@linaro.org \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox