From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6D22FB0 for ; Sat, 14 Aug 2021 17:02:36 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id f12-20020a05600c4e8c00b002e6bdd6ffe2so6081945wmq.5 for ; Sat, 14 Aug 2021 10:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=X9HnISzXWkNVCczHXM6hTEMkBbJkCBVv5W2RvJ/RQCE=; b=IaI8Qf8y3Hhbe7l9Yq/M1VmbnJfx/iZy3c2Hrq0p2vC1m3Q4cUrhRuE40EWvUUUpL1 mGOBHV7kvFtHK7oY1or4FxjMIFxoF1WD9i3guIwka0EEjYUHEJxJel3312TkFwn8TCKx morDQDr0p20mAkUzxQhLDnn6oze42yyfsb9+/FQeDFcY9mSUkl+kZq5hjJC9tONoIbcW NDvLt8JqpIcI5DI6h1sp2xaSkCYIA1JJNxJJBX5FFnZfWxBL/7Fl/O2qNWIVNXWSJA6+ Ge0lQd2RMebV250RYgU93nFt5LcxWFt7RgRw93snmqD4YLJ5bKg6TndYQ1duwH6111nG WtVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X9HnISzXWkNVCczHXM6hTEMkBbJkCBVv5W2RvJ/RQCE=; b=oKme++U8Y/KqTC+wl/HMfakBvAqPf4Q3iXJXpcIINJIgoZtu4VU+4SUCGJzuhVydXJ pXwX7HhZxRjl93amLlHTPHAzHqNncTZUxOgIbXqY1uH2ngPrjWaB7UwTA/O2FgqPyqot /jkek9iU0k7enCFRjPvS5q2+exYcjIGWVmEBAMzjlITLGoFQLnWPePMi+CUTVS0/2JxS tihfNKJkST+u/BJFw6yiwET/OZ2k19DSOFG4aji9K63SZmVk1fVTcrTKlVpSqywrQTXG FPQj5teaVfmi2kR+6bN9usAVnUE+IRezghc/8fu/wFz9U2RxMZDUr/ZeGXwzu0m4lH/S qcYQ== X-Gm-Message-State: AOAM532Nltjt0lbccv6uhJnPqGmVIfFR5lzALjC6h83xwzJ8UMGqHhof 5GHYQCASVZ8JHaAuAsIGEns= X-Google-Smtp-Source: ABdhPJzvdRKJhhSHZETge+N+tLedrQj+cQPZKJB0HLdBgPp04ehf56MNITDph3+Ysd13DGMYAeEFyw== X-Received: by 2002:a1c:6a18:: with SMTP id f24mr2346878wmc.142.1628960554971; Sat, 14 Aug 2021 10:02:34 -0700 (PDT) Received: from ?IPv6:2a02:8108:96c0:3b88::4058? ([2a02:8108:96c0:3b88::4058]) by smtp.gmail.com with ESMTPSA id z5sm4934753wmi.36.2021.08.14.10.02.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Aug 2021 10:02:34 -0700 (PDT) Subject: Re: [PATCH] staging: r8188eu: os_dep: Remove defined but not used variables To: "Fabio M. De Francesco" , Greg Kroah-Hartman , Larry Finger , Phillip Potter , Martin Kaiser , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210814160804.11634-1-fmdefrancesco@gmail.com> From: Michael Straube Message-ID: Date: Sat, 14 Aug 2021 19:01:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210814160804.11634-1-fmdefrancesco@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/14/21 6:08 PM, Fabio M. De Francesco wrote: > Remove defined but not used const variables. Issues detected by GCC > running with -Wunused-const-variable option enabled. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 21 -------------------- > 1 file changed, 21 deletions(-) > > diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c > index 38ee41f9d2ba..d9fdd83218dc 100644 > --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c > +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c > @@ -84,11 +84,6 @@ static u32 rtw_rates[] = {1000000, 2000000, 5500000, 11000000, > 6000000, 9000000, 12000000, 18000000, 24000000, 36000000, > 48000000, 54000000}; > > -static const char * const iw_operation_mode[] = { > - "Auto", "Ad-Hoc", "Managed", "Master", "Repeater", > - "Secondary", "Monitor" > -}; > - > void indicate_wx_scan_complete_event(struct adapter *padapter) > { > union iwreq_data wrqu; > @@ -6666,19 +6661,3 @@ struct iw_handler_def rtw_handlers_def = { > .num_private_args = sizeof(rtw_private_args) / sizeof(struct iw_priv_args), > .get_wireless_stats = rtw_get_wireless_stats, > }; > - > -/* copy from net/wireless/wext.c start */ > -/* ---------------------------------------------------------------- */ > -/* > - * Calculate size of private arguments > - */ > -static const char iw_priv_type_size[] = { > - 0, /* IW_PRIV_TYPE_NONE */ > - 1, /* IW_PRIV_TYPE_BYTE */ > - 1, /* IW_PRIV_TYPE_CHAR */ > - 0, /* Not defined */ > - sizeof(__u32), /* IW_PRIV_TYPE_INT */ > - sizeof(struct iw_freq), /* IW_PRIV_TYPE_FLOAT */ > - sizeof(struct sockaddr), /* IW_PRIV_TYPE_ADDR */ > - 0, /* Not defined */ > -}; > Looks good to me, thanks. Acked-by: Michael Straube Michael