From: Stefan Wahren <stefan.wahren@i2se.com>
To: Simon Horman <horms@kernel.org>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, llvm@lists.linux.dev,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static
Date: Wed, 19 Apr 2023 08:37:58 +0200 [thread overview]
Message-ID: <e1fed875-059d-bf98-f9da-09c51f362be8@i2se.com> (raw)
In-Reply-To: <20230418-vchiq_platform_init-static-v1-1-3c38ba81bc66@kernel.org>
Hi Simon,
Am 18.04.23 um 13:23 schrieb Simon Horman:
> vchiq_platform_init() is only used in this file so it can be static.
>
> clang-16 with W=1 reports:
>
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes]
> int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
> ^
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>
> Signed-off-by: Simon Horman <horms@kernel.org>
this is not the first attempt to fix this [1]. But maybe this has been
fixed in the meantime.
[1] -
https://lore.kernel.org/linux-staging/20221022043548.1671644-1-scottjcrouch@gmail.com/#t
next prev parent reply other threads:[~2023-04-19 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:23 [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static Simon Horman
2023-04-18 18:39 ` Nick Desaulniers
2023-04-19 5:39 ` Simon Horman
2023-04-18 18:44 ` Nathan Chancellor
2023-04-19 5:42 ` Simon Horman
2023-04-19 6:37 ` Stefan Wahren [this message]
2023-04-19 8:51 ` Simon Horman
2023-04-19 21:21 ` Nick Desaulniers
2023-04-19 21:35 ` Arnd Bergmann
2023-04-19 21:38 ` Nick Desaulniers
2023-04-19 21:41 ` Arnd Bergmann
2023-04-19 21:48 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fed875-059d-bf98-f9da-09c51f362be8@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).