From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Santiago Ruano Rincón" <santiagorr@riseup.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, helen.koike@collabora.com,
~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH v2 1/2] staging: media: sdis: move open brace to a new line
Date: Tue, 30 Jul 2024 10:41:40 -0500 [thread overview]
Message-ID: <e7fb44cc-1a48-4486-b9b6-e505fa1a4e73@suswa.mountain> (raw)
In-Reply-To: <20240730080628.991297-1-santiagorr@riseup.net>
On Tue, Jul 30, 2024 at 05:06:27PM +0900, Santiago Ruano Rincón wrote:
> Fix checkpatch error "ERROR: open brace '{' following function
> definitions go on the next line" in sdis_1.0/ia_css_sdis.host.c:239.
>
> Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>
>
> ---
> This is one of my first patches. Could you please tell me if is there
> anything wrong with it? Thank you.
v2 patches need to say what changed since v1.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
prev parent reply other threads:[~2024-07-30 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 8:06 [PATCH v2 1/2] staging: media: sdis: move open brace to a new line Santiago Ruano Rincón
2024-07-30 8:06 ` [PATCH v2 2/2] staging: media: sdis: move open braces to the previous line Santiago Ruano Rincón
2024-07-30 15:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fb44cc-1a48-4486-b9b6-e505fa1a4e73@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=santiagorr@riseup.net \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox