public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Ariel Silver <arielsilver77@gmail.com>,
	gregkh@linuxfoundation.org, yogi.kernel@gmail.com,
	dan.carpenter@linaro.org, straube.linux@gmail.com,
	garyrookard@fastmail.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: Sparse warning regarding variable declaration
Date: Wed, 28 Feb 2024 21:54:43 +0100	[thread overview]
Message-ID: <ef46a014-279c-490e-bbe1-df4697415d59@gmail.com> (raw)
In-Reply-To: <20240228072553.11740-1-arielsilver77@gmail.com>

On 2/28/24 08:25, Ariel Silver wrote:
> Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should it be static?"
> As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.
> 

Hi Ariel,

please use checkpatch to check your patch:

File Nr: 0    Patch: ../../../Downloads/20240228-[PATCH] Staging_ 
rtl8192e_ Sparse warning regarding variable declaration-14757.txt
WARNING: A patch subject line should describe the change not the tool 
that found it
#1:
Subject: [PATCH] Staging: rtl8192e: Sparse warning regarding variable 
declaration

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#7:
Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should 
it be static?"

total: 0 errors, 2 warnings, 0 checks, 8 lines checked

Please make a v2 with change description under the "---"

Thanks for your support.

Bye Philipp

      reply	other threads:[~2024-02-28 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  7:25 [PATCH] Staging: rtl8192e: Sparse warning regarding variable declaration Ariel Silver
2024-02-28 20:54 ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef46a014-279c-490e-bbe1-df4697415d59@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=arielsilver77@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=garyrookard@fastmail.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    --cc=yogi.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox