From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Nilo Alexandre <n1lux.comp@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, ~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325
Date: Wed, 28 Aug 2024 20:53:38 +0200 [thread overview]
Message-ID: <efe13a61-1607-419d-b330-9a7061511719@gmail.com> (raw)
In-Reply-To: <20240828011842.67611-1-n1lux.comp@gmail.com>
On 8/28/24 03:18, Nilo Alexandre wrote:
> Remove linebreak to improve readability
>
Hi Nilo,
please end the above sentences with a ".".
> CHECK: Alignment should match open parenthesis
Why do we need the above line?
Thanks for your support.
Bye Philipp
>
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
> ---
> v4: Remove linebreak to improve readability
> v3: Fix typo in commit message.
> v2: Using tabs instead of spaces.
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b25e83743956d..a80efe6c7c209 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
>
> if (priv->epromtype == EEPROM_93C46) {
> if (!priv->autoload_fail_flag) {
> - usValue = rtl92e_eeprom_read(dev,
> - EEPROM_TxPwDiff_CrystalCap >> 1);
> + usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
> priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
> priv->eeprom_crystal_cap = (usValue & 0xf000)
> >> 12;
next prev parent reply other threads:[~2024-08-28 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 1:18 [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325 Nilo Alexandre
2024-08-28 18:53 ` Philipp Hortmann [this message]
2024-08-29 9:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efe13a61-1607-419d-b330-9a7061511719@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=n1lux.comp@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox