From: Stefan Wahren <wahrenst@gmx.net>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-staging@lists.linux.dev
Cc: Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 0/2] staging: vchiq_core: Stop kthreads on module unload
Date: Sat, 6 Jul 2024 10:50:04 +0200 [thread overview]
Message-ID: <f2037585-afa6-443c-abfe-4e2b4b278433@gmx.net> (raw)
In-Reply-To: <20240703131052.597443-1-umang.jain@ideasonboard.com>
Am 03.07.24 um 15:10 schrieb Umang Jain:
> This is a re-attempt of [1] where we noticed corruption of vc04 firmware
> on stopping the kthread.
>
> After investigation, I found that the case where
> wait_event_interruptible() can return early(wait failed) with
> -ERESTARTSYS, is something not handling in remote_event_wait(). Once we
> bubble up the that return/err code and handle it - the issue is resolved
> correctly and kthreads are stopped as expected.
>
> Patch 1/2 handles the returning of the return value from
> wait_event_interruptible()
>
> Patch 2/2 handles stopping of kthreads.
>
The whole series is:
Tested-by: Stefan Wahren <wahrenst@gmx.net>
prev parent reply other threads:[~2024-07-06 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 13:10 [PATCH v2 0/2] staging: vchiq_core: Stop kthreads on module unload Umang Jain
2024-07-03 13:10 ` [PATCH v2 1/2] staging: vchiq_core: Bubble up wait_event_interruptible() return value Umang Jain
2024-07-03 16:18 ` Stefan Wahren
2024-07-03 16:54 ` Dan Carpenter
2024-07-03 13:10 ` [PATCH v2 2/2] staging: vc04_services: vchiq_core: Stop kthreads on vchiq module unload Umang Jain
2024-07-03 16:31 ` Stefan Wahren
2024-07-03 16:44 ` Umang Jain
2024-07-06 8:50 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2037585-afa6-443c-abfe-4e2b4b278433@gmx.net \
--to=wahrenst@gmx.net \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox