From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 988DC14D6EF for ; Fri, 25 Oct 2024 17:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729878423; cv=none; b=b9xcpXQeG2CUMIEl9AYkBFNR1F+wheEy9mrd1a+vBYpCdO79BU3bRF31qxi/g+TbpIxrfySdy9uQJC6HFfQ7w5QKfYzaSxEbpOUT4KW6lnPd8giGU0hEpJqfLG6ylHLljleHRoOtvAeB05XE4ebVcW4N5xbDTZgvXxSdcyrl5n4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729878423; c=relaxed/simple; bh=ozBIpgyxnAgCBKNUleMXiK02jDu4q4LAhe4fTs4O04s=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MpRx/qwNujLgFSUQIxk30w8I7UlM5U1bJznP78ABiEq5T+rzCwCdhbmK3LjAHDTeL07RXFBoEinZ1J5H5t3fe6mA0MQsrxVZqJGWOXQxxfaKHjIbeqvB1uCjjqtoMh9wcuj5ZJFMuDcvGj5PSn0FzQHvTrZ/QyqN1MXPBQ6AsKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=iUg44kWB; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="iUg44kWB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729878418; bh=ozBIpgyxnAgCBKNUleMXiK02jDu4q4LAhe4fTs4O04s=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=iUg44kWBzy9MSSIzXccTiM8CT+DmPeUOKRVz7wQSt6tXpAV8XHJyQsUgsBzcJMnrl H2wUZKvZqhgtu4gEjEq5KdV9Uu1DBV6gHCy04fMhzVm1of3mNa4NMGY+2HUbDULdW9 xFEXp2AoyMZUxDeTtHC4LByH0c2gdHO7XSutsFlHIRzODNIrcBNAWxjH3U1rkuwqye gujMmwRC7Ckl2G+l6HL4G9veMPSN9jM0QCowsOYc8GTEoqkKmo0RCqGQJQsuMRwLSy O1fctHQo8IOTsgglaa0sk2pQsQXhu1OaLnC0ZBS48/rbMPInMEPBB216adib9YQKFs dtLZ2T11X37QQ== Received: from nicolas-tpx395.lan (unknown [IPv6:2606:6d00:15:862e::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id B8C4817E36B5; Fri, 25 Oct 2024 19:46:56 +0200 (CEST) Message-ID: Subject: Re: [PATCH v6 11/11] media: rkvdec: Fix enumerate frame sizes From: Nicolas Dufresne To: Jonas Karlman , Sebastian Fricke , Ezequiel Garcia , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Boris Brezillon Cc: Alex Bee , Benjamin Gaignard , Detlev Casanova , Dan Carpenter , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab Date: Fri, 25 Oct 2024 13:46:55 -0400 In-Reply-To: <20240909192522.1076704-12-jonas@kwiboo.se> References: <20240909192522.1076704-1-jonas@kwiboo.se> <20240909192522.1076704-12-jonas@kwiboo.se> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Le lundi 09 septembre 2024 à 19:25 +0000, Jonas Karlman a écrit : > The VIDIOC_ENUM_FRAMESIZES ioctl should return all frame sizes (i. e. > width and height in pixels) that the device supports for the given pixel > format. > > For coded format returning the frame size used to enforce HW alignment > requirements for CAPTURE buffers does not make fully sense. > > Instead, signal applications what the maximum frame size that is > supported by the HW decoder using a frame size of continuous type. > > Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver") > Suggested-by: Alex Bee > Signed-off-by: Jonas Karlman Reviewed-by: Nicolas Dufresne > --- > v6: > - New patch > > With this change FFmpeg V4L2 Request API hwaccels can implement a strict > check if frame size is supported by the video device: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-August/332037.html > --- > drivers/staging/media/rkvdec/rkvdec.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index c8c14f35ac44..9002eb3a59e5 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -334,8 +334,14 @@ static int rkvdec_enum_framesizes(struct file *file, void *priv, > if (!fmt) > return -EINVAL; > > - fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; > - fsize->stepwise = fmt->frmsize; > + fsize->type = V4L2_FRMSIZE_TYPE_CONTINUOUS; > + fsize->stepwise.min_width = 1; > + fsize->stepwise.max_width = fmt->frmsize.max_width; > + fsize->stepwise.step_width = 1; > + fsize->stepwise.min_height = 1; > + fsize->stepwise.max_height = fmt->frmsize.max_height; > + fsize->stepwise.step_height = 1; > + > return 0; > } >