Re: [PATCH v7 22/49] media: i2c: Stop direct calls to queue num_buffers field

Hans Verkuil
2023-09-19T13:42:04Z

On 14/09/2023 15:32, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffer field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> drivers/media/i2c/video-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index 537ebd9fa8d7..60d3e2f35afe 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -406,7 +406,7 @@ static int queue_setup(struct vb2_queue *vq,
> struct video_i2c_data *data = vb2_get_drv_priv(vq);
> unsigned int size = data->chip->buffer_size;
>
> - if (vq->num_buffers + *nbuffers < 2)
> + if (vb2_get_num_buffers(vq) + *nbuffers < 2)
> *nbuffers = 2;
>
> if (*nplanes)

This driver sets min_buffers_needed to 1, then checks for 2 here.

Drop the check and instead set min_buffers_needed to 2.

Update the commit log accordingly.

Regards,

Hans