Re: [PATCH v7 40/49] media: usb: usbtv: Stop direct calls to queue num_buffers field

Hans Verkuil
2023-09-19T14:21:10Z

On 14/09/2023 15:33, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffer field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> drivers/media/usb/usbtv/usbtv-video.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/usbtv/usbtv-video.c b/drivers/media/usb/usbtv/usbtv-video.c
> index 1e30e05953dc..41704d45c65c 100644
> --- a/drivers/media/usb/usbtv/usbtv-video.c
> +++ b/drivers/media/usb/usbtv/usbtv-video.c
> @@ -725,10 +725,11 @@ static int usbtv_queue_setup(struct vb2_queue *vq,
> unsigned int *nplanes, unsigned int sizes[], struct device *alloc_devs[])
> {
> struct usbtv *usbtv = vb2_get_drv_priv(vq);
> + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
> unsigned size = USBTV_CHUNK * usbtv->n_chunks * 2 * sizeof(u32);
>
> - if (vq->num_buffers + *nbuffers < 2)
> - *nbuffers = 2 - vq->num_buffers;
> + if (q_num_bufs + *nbuffers < 2)
> + *nbuffers = 2 - q_num_bufs;

Drop check, set min_buffers_needed to 2.

Hans

> if (*nplanes)
> return sizes[0] < size ? -EINVAL : 0;
> *nplanes = 1;