Re: [PATCH v7 37/49] media: usb: airspy: Stop direct calls to queue num_buffers field

Hans Verkuil
2023-09-19T14:16:50Z

On 14/09/2023 15:33, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffer field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> drivers/media/usb/airspy/airspy.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
> index 462eb8423506..e24e655fb1db 100644
> --- a/drivers/media/usb/airspy/airspy.c
> +++ b/drivers/media/usb/airspy/airspy.c
> @@ -482,12 +482,13 @@ static int airspy_queue_setup(struct vb2_queue *vq,
> unsigned int *nplanes, unsigned int sizes[], struct device *alloc_devs[])
> {
> struct airspy *s = vb2_get_drv_priv(vq);
> + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
>
> dev_dbg(s->dev, "nbuffers=%d\n", *nbuffers);
>
> /* Need at least 8 buffers */
> - if (vq->num_buffers + *nbuffers < 8)
> - *nbuffers = 8 - vq->num_buffers;
> + if (q_num_bufs + *nbuffers < 8)
> + *nbuffers = 8 - q_num_bufs;
> *nplanes = 1;
> sizes[0] = PAGE_ALIGN(s->buffersize);
>

Drop the check, instead set min_buffers_needed to 8.

Regards,

Hans