From: Hans de Goede <hansg@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [rft, PATCH v2 0/3] media: atomisp: replace math macros
Date: Sun, 6 Jul 2025 18:11:28 +0200 [thread overview]
Message-ID: <f7074f3f-cdd3-4476-8711-0e932357bbfc@kernel.org> (raw)
In-Reply-To: <20250519155028.526453-1-andriy.shevchenko@linux.intel.com>
Hi,
On 19-May-25 5:46 PM, Andy Shevchenko wrote:
> Kill unused definitions that may use custom macros from math_support.h
> and reduce usage of the latter and even kill some of them at the end
> of the series.
>
> Please, apply only after tests that confirm everything is working
> as expected.
>
> Changelog v2:
> - added a cleanup patch 1
> - removed potential div-by-0 conversions
Thanks, patch looks good to me and this time things don't crash
during testing:
Reviewed-by: Hans de Goede <hansg@kernel.org>
Tested-by: Hans de Goede <hansg@kernel.org>
I have merged the series in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this series will be included in my next
pull-request to Mauro (to media subsystem maintainer)
Regards,
Hans
> v1:
> https://lore.kernel.org/linux-media/20240923085652.3457117-1-andriy.shevchenko@linux.intel.com/
>
> Andy Shevchenko (3):
> media: atomisp: Remove unused header
> media: atomisp: Replace macros from math_support.h
> media: atomisp: Remove no more used macros from math_support.h
>
> .../pci/hive_isp_css_include/math_support.h | 5 -
> .../kernels/anr/anr_1.0/ia_css_anr_types.h | 4 +-
> .../pci/isp/kernels/dpc2/ia_css_dpc2_param.h | 6 +-
> .../isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c | 4 +-
> .../isp/kernels/eed1_8/ia_css_eed1_8_param.h | 22 +--
> .../isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c | 6 +-
> .../isp/kernels/sc/sc_1.0/ia_css_sc_param.h | 2 +-
> .../pci/isp/modes/interface/input_buf.isp.h | 6 +-
> .../pci/isp/modes/interface/isp_const.h | 157 ------------------
> .../pci/runtime/debug/src/ia_css_debug.c | 1 -
> .../atomisp/pci/runtime/frame/src/frame.c | 29 ++--
> .../atomisp/pci/runtime/ifmtr/src/ifmtr.c | 11 +-
> .../pci/runtime/isys/src/virtual_isys.c | 2 +-
> .../staging/media/atomisp/pci/sh_css_defs.h | 12 +-
> .../media/atomisp/pci/sh_css_internal.h | 8 +-
> .../media/atomisp/pci/sh_css_param_dvs.h | 22 +--
> .../staging/media/atomisp/pci/sh_css_params.c | 12 +-
> 17 files changed, 77 insertions(+), 232 deletions(-)
> delete mode 100644 drivers/staging/media/atomisp/pci/isp/modes/interface/isp_const.h
>
prev parent reply other threads:[~2025-07-06 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 15:46 [rft, PATCH v2 0/3] media: atomisp: replace math macros Andy Shevchenko
2025-05-19 15:46 ` [PATCH v2 1/3] media: atomisp: Remove unused header Andy Shevchenko
2025-05-19 15:46 ` [PATCH v2 2/3] media: atomisp: Replace macros from math_support.h Andy Shevchenko
2025-05-19 15:46 ` [PATCH v2 3/3] media: atomisp: Remove no more used " Andy Shevchenko
2025-06-24 14:02 ` [rft, PATCH v2 0/3] media: atomisp: replace math macros Andy Shevchenko
2025-07-06 16:11 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7074f3f-cdd3-4476-8711-0e932357bbfc@kernel.org \
--to=hansg@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).