From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D86667D3F4 for ; Tue, 9 Apr 2024 08:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712649639; cv=none; b=ODODOvCzUufnZZCLosUOcbcQr3UGaOtXzxvjG9XAoFhdCSU6tRRlMURSJekeZ1dCM+jjQ6YM0sBsECNNdc2AJx+gnBJQ7taHi5ZJyspn+sZV9/WNQRMZ6RN1ioJI925kOKeeBkD8H2X0ex9uX4OODwG6+QwR2bfYTP20JGDBXPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712649639; c=relaxed/simple; bh=avVXALww2VwZ9gN38ctn3234RAy9lcjvts1P4UvCWU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fS4Zoi2f2gVfu/4/PCV3HBoohh/xTCNONarlsle+RNY24G6kP3xeEpo+ejV47UOBnm4JIg4cHh5Yk1A4w3NCzS7UG0a7FRNd9XuFbIsC5l0AfqnRxno+kfUNgu/fJfTZTCM8Hy3TiHLSd0vvxDO8oDI6En1sKGueqXhe1VaIEQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kxY13EaH; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kxY13EaH" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-56e6282dd72so2112544a12.3 for ; Tue, 09 Apr 2024 01:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712649636; x=1713254436; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6ONlMZGZ9RPYiJA+pih4//jtldRttSyww/CoJiXseC8=; b=kxY13EaHac/J1Ts5aXql/phzDIp/Vvxri+xZ08/0/mtkHF3Ztitc+ZM4fshYj35dEn TC7uWPlmcwizuFSQMFuuSyYH8Gtoku46VmuqL2HRTCU6jge6uG6Iranlw+Qc4NnMgKSG PK9zIWzChRE5bMYasaGR0wv4jIqKlmKU/RvCpAfSYrcNIy2uGHSptvYMKxEaDter7JkU cTyNHyC0dJMiwHFeT76M1PAc0oxikYsdH/FBwL0N90+WDnmIaxZYcNp5BwK7VK4t+wjE +CpVJ2Wu2tAtt8sa5wOHoB2U+L+RJQf4XVW+tjXf5EXqkMy0iQOSeYID0sWMzKMWCYbf FeQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712649636; x=1713254436; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6ONlMZGZ9RPYiJA+pih4//jtldRttSyww/CoJiXseC8=; b=AF49siM3rqYUUgZvGdDQHHQSfjupBWUVshfYmdr9htqvrmFY2uvRLtTFdMnHX0dqyJ K1AYnH2kMtk8Nog9wdUZxNtuWHnYxBo/RxXOUKrV+PTytID0iMrvR5JEsKYxPZPmCSl6 SOqmk8H9Q8JjhK2Y2ozbPl18uEuCDpQLNZpBzMt25KO/CkNs6PBp3dvEJXsoyGJP5lJO LRSuOSh8hv2xtdA4QRMwlIQMBM4cE/FIfYfyxRRePWE3xNfmY88lVU3JSnE1lO3N/iZj Vm5BShpZ5lridhFzdGMAa9NylPf6n6Tj2iS5lsDGBp5d4WOStG1I+/AdWtHyH6NmiGf0 VJsA== X-Forwarded-Encrypted: i=1; AJvYcCWsTgeNehhsM/X2n64HzlLpQUg8PRiptGZo228ElkL46o6d5HCO9PFK6Nr+drBzPQq/6G9q8VSqFksPh/RWvpX3LiGzDzOeotxzrKtrYw== X-Gm-Message-State: AOJu0Ywo2S4Ed2LFEzzrhBnnZyEmWDWjv4rhaNQ2Lfcf8iLnhPgYofBp rieFrEmU8FG3ZbYH9j5iR941Jo1LJC0EyJaL7nV5lAyG6WzqBEEFsWi35zMHlx0= X-Google-Smtp-Source: AGHT+IGxEblWAkIcMvVn/67TittUpAQ5r3yIpuR2HIFYIIXkYrL/8PqoXuJ527K8Niw97U0bA6lP0A== X-Received: by 2002:a17:907:8690:b0:a4e:2600:3fb6 with SMTP id qa16-20020a170907869000b00a4e26003fb6mr4485405ejc.62.1712649635877; Tue, 09 Apr 2024 01:00:35 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id dm14-20020a170907948e00b00a4e24d259edsm5289480ejc.167.2024.04.09.01.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 01:00:35 -0700 (PDT) Date: Tue, 9 Apr 2024 11:00:30 +0300 From: Dan Carpenter To: Jackson Chui Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] staging: greybus: Replace gcam macros with direct dev log calls Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 08, 2024 at 03:44:40PM -0700, Jackson Chui wrote: > Reported by checkpatch: > > CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid > precedence issues > > Inline standard calls to 'dev_*' kernel logging functions, in favor > of 'gcam_*' macros, to clear up gcam-related logging. > > Signed-off-by: Jackson Chui Reviewed-by: Dan Carpenter regards, dan carpenter