Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

Sakari Ailus
2021-04-14T18:33:31Z

Hi Aline,

Thanks for the patch.

On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro wrote:
> Format multi-line comments according to the coding-style.
> Issue detected by checkpatch.pl.
>
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 109 ++++++++++++++----------
> 1 file changed, 65 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 592ea99..6113785 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -67,7 +67,8 @@
> * At 15fps this means 133ms. We set the timeout a bit longer.
> * Each flash driver is supposed to set its own timeout, but
> * just in case someone else changed the timeout, we set it
> - * here to make sure we don't damage the flash hardware. */
> + * here to make sure we don't damage the flash hardware.
> + */
> #define FLASH_TIMEOUT 800 /* ms */
>
> union host {
> @@ -562,7 +563,8 @@ irqreturn_t atomisp_isr(int irq, void *dev)
> * and driver needs to keep old sequence_temp value.
> * NOTE: There is assumption here that ISP will not
> * start processing next frame from sensor before old
> - * one is completely done. */
> + * one is completely done.
> + */
> if (atomic_read(&asd->sequence) == atomic_read(
> &asd->sequence_temp))
> atomic_set(&asd->sequence_temp,
> @@ -1247,7 +1249,8 @@ void atomisp_buf_done(struct atomisp_sub_device *asd, int error,
>
> if (IS_ISP2401) {
> /* If there are no buffers queued then

This should begin with:

/*
*

And the same for the rest. Apart from this the patch seems fine.

--
Kind regards,

Sakari Ailus