From: Pavel Skripkin <paskripkin@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
David Laight <david.Laight@aculab.com>
Subject: Re: [PATCH v6 19/19] staging: r8188eu: remove shared buffer for USB requests
Date: Thu, 16 Sep 2021 14:51:10 +0300 [thread overview]
Message-ID: <fb4e88d9-8e1e-4964-8361-085f5a6ee9f1@gmail.com> (raw)
In-Reply-To: <20210916114928.GK2116@kadam>
On 9/16/21 14:49, Dan Carpenter wrote:
> On Wed, Sep 15, 2021 at 11:11:03PM +0200, Fabio M. De Francesco wrote:
>> static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
>> {
>> int i;
>> @@ -158,9 +135,6 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
>> DBG_88E("NON USB_SPEED_HIGH\n");
>> }
>>
>> - if (rtw_init_intf_priv(pdvobjpriv) == _FAIL)
>> - goto free_dvobj;
>> -
>> /* 3 misc */
>> sema_init(&pdvobjpriv->usb_suspend_sema, 0);
>> rtw_reset_continual_urb_error(pdvobjpriv);
>> @@ -169,7 +143,6 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
>>
>> status = _SUCCESS;
> ^^^^^^^^^^^^^^^^^
>
>>
>> -free_dvobj:
>> if (status != _SUCCESS && pdvobjpriv) {
> ^^^^^^^^^^^^^^^^^^
> status is going to be _SUCCESS so we can delete this if statement.
>
silly mistake :(
will be fixed in v7, thanks so much for review
>> usb_set_intfdata(usb_intf, NULL);
>> kfree(pdvobjpriv);
>> @@ -200,7 +173,7 @@ static void usb_dvobj_deinit(struct usb_interface *usb_intf)
>> usb_reset_device(interface_to_usbdev(usb_intf));
>> }
>> }
>> - rtw_deinit_intf_priv(dvobj);
>> +
>> kfree(dvobj);
>> }
>
With regards,
Pavel Skripkin
prev parent reply other threads:[~2021-09-16 11:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 21:10 [PATCH v6 00/19] staging: r8188eu: Shorten and simplify calls chains Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 01/19] staging: r8188eu: remove usb_{read,write}_mem() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 02/19] staging: r8188eu: remove the helpers of rtw_read8() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 03/19] staging: r8188eu: remove the helpers of rtw_read16() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 04/19] staging: r8188eu: remove the helpers of rtw_read32() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 05/19] staging: r8188eu: remove the helpers of usb_write8() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 06/19] staging: r8188eu: remove the helpers of usb_write16() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 07/19] staging: r8188eu: remove the helpers of usb_write32() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 08/19] staging: r8188eu: remove the helpers of usb_writeN() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 09/19] staging: r8188eu: remove the helpers of usb_read_port() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 10/19] staging: r8188eu: remove the helpers of usb_write_port() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 11/19] staging: r8188eu: remove the helpers of usb_read_port_cancel() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 12/19] staging: r8188eu: remove the helpers of usb_write_port_cancel() Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 13/19] staging: r8188eu: remove core/rtw_io.c Fabio M. De Francesco
2021-09-15 21:10 ` [PATCH v6 14/19] staging: remove struct _io_ops Fabio M. De Francesco
2021-09-16 12:52 ` Dan Carpenter
2021-09-16 13:28 ` Fabio M. De Francesco
2021-09-16 13:52 ` Greg Kroah-Hartman
2021-09-15 21:10 ` [PATCH v6 15/19] staging: r8188eu: Clean up usbctrl_vendorreq() Fabio M. De Francesco
2021-09-15 21:11 ` [PATCH v6 16/19] staging: r8188eu: Clean up rtw_read*() and rtw_write*() Fabio M. De Francesco
2021-09-16 11:36 ` Dan Carpenter
2021-09-16 12:14 ` Fabio M. De Francesco
2021-09-16 12:50 ` Dan Carpenter
2021-09-15 21:11 ` [PATCH v6 17/19] staging: r8188eu: Shorten calls chains of rtw_read*() Fabio M. De Francesco
2021-09-15 21:11 ` [PATCH v6 18/19] staging: r8188eu: Shorten calls chains of rtw_write*() Fabio M. De Francesco
2021-09-15 21:11 ` [PATCH v6 19/19] staging: r8188eu: remove shared buffer for USB requests Fabio M. De Francesco
2021-09-16 11:49 ` Dan Carpenter
2021-09-16 11:51 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb4e88d9-8e1e-4964-8361-085f5a6ee9f1@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=david.Laight@aculab.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox