From: Michael Straube <straube.linux@gmail.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove power_saving_wk_hdl function
Date: Sat, 2 Oct 2021 16:47:48 +0200 [thread overview]
Message-ID: <fb64de38-50e1-e0e7-0b13-42e2c2e43f3d@gmail.com> (raw)
In-Reply-To: <YVhv5JiHovfdpNGg@user>
On 10/2/21 16:42, Saurav Girepunje wrote:
> Remove function power_saving_wk_hdl is it just calling rtw_ps_processor.
> Instead of power_saving_wk_hdl() call rtw_ps_processor().
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index 3a70776f3304..44a1df4f51d1 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -1649,11 +1649,6 @@ u8 rtw_antenna_select_cmd(struct adapter *padapter, u8 antenna, u8 enqueue)
> return res;
> }
>
> -static void power_saving_wk_hdl(struct adapter *padapter, u8 *pbuf, int sz)
> -{
> - rtw_ps_processor(padapter);
> -}
> -
> u8 p2p_protocol_wk_cmd(struct adapter *padapter, int intCmdType)
> {
> struct cmd_obj *ph2c;
> @@ -1890,7 +1885,7 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
> dynamic_chk_wk_hdl(padapter, pdrvextra_cmd->pbuf, pdrvextra_cmd->type_size);
> break;
> case POWER_SAVING_CTRL_WK_CID:
> - power_saving_wk_hdl(padapter, pdrvextra_cmd->pbuf, pdrvextra_cmd->type_size);
> + rtw_ps_processor(padapter);
> break;
> case LPS_CTRL_WK_CID:
> lps_ctrl_wk_hdl(padapter, (u8)pdrvextra_cmd->type_size);
> --
> 2.32.0
>
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks,
Michael
prev parent reply other threads:[~2021-10-02 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 14:42 [PATCH] staging: r8188eu: core: remove power_saving_wk_hdl function Saurav Girepunje
2021-10-02 14:47 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb64de38-50e1-e0e7-0b13-42e2c2e43f3d@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox