From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E4B3225761 for ; Sun, 24 Aug 2025 19:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756062293; cv=none; b=BOdwMMmZy4CTKmApJ/rLFPNwxcEopjEMK2ZP8wEgvj8NeOdqtY92q+IfebV2ZOH8kN7c2OtbGxOUtrOEzBfjCyGksJCP8SVeLPNMy5FN5Uf6aGYLS8gzEtgIOcNmbwPm2doPpByBUMhZkHodKMvdw4lwG6yJx5P+NH5kUQ3mzrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756062293; c=relaxed/simple; bh=UP+AYol+DY8UTEmT5RaSgfZsggShtTb7514fxVj9jCY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cy12Y/rar2A76nOJhrTYJamJlqfXrX10kPXPVILNvNwG4FmLpqnA02eRNyA+IVQgRgtkgB43HnuYjbWE87Ycb2onswvPcBwsBOWWFOQ3KnnwlfDRo+88GGwPzgQX222iOMeApbsycpwqD4b97IOhBiUud8M9XdoPPQkPVPWhPxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WWYN5bT/; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WWYN5bT/" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-55ce5095c90so347781e87.0 for ; Sun, 24 Aug 2025 12:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756062288; x=1756667088; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=WWYN5bT/a8E2VT5vJ1JYLabSrgah/0BeZ4SUlYgXKkU91BZZbWf5vBfj4zEu9GbGm4 sBBDQr9HFv+lN1ftpdQbq/h3+OKrZbF+5+zn6ODT/qdagIV1xl6lD5mhF6Qmsch729DL 5svQUF25TQ8UNK2qmykUwWcEcDURxON7kVImwM+YBA9lt901TEzQkXee6DOAjPTf1iAT kXo30z7uTjyMhlMsVqHuTL/sXVClmTSViMVZYX2SJ78ezKuWC4VNXrKX3mc3vAaKVIuK T5A3ySK0O5uXIVU8O/LTNnxQW2lTiT5jLTXS/ghWa0AOKQlccvWlaAbpR7D3yy9L/Vo/ pvKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756062288; x=1756667088; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=fCKQ30e0pTFkDam7UUNcf7m92lMGRsK+0xzVh7Uttfv71jmnldvevtmhDhPBtYRtCx 1vDQXcf9+dipfq4IQ2YSbjed8NC+9lyPpYRfFT7h3VL7ZSf7OPsOxmux4qlA5mwUZYZl /vJYpBCLmD3Vm2VmfcEKsMe0jaHUs8uG1TD9yA6u6M4gM7I19LdMCqj8S0YcuHzKvWBv tbUwoX1BEN+JycnG2dCofXKxwEqv+KhO0WIk12SzNrWwxjgnAPRjyuaq/Yu4suG7sKuH THM0WBbHDKv83c4vpIswiNBv498uMD4buFSqNwttg1HjQku+LsFWjTKwI2RaVpxM9BYS 6bBw== X-Forwarded-Encrypted: i=1; AJvYcCW9H6JiYTJPkdnMpPjI9ZDuS8HCKtjG29NfMLJ6C0JcZAUdO0vmwbeZTe5Ku0a1FxNptEwMa3neKw25f9n9@lists.linux.dev X-Gm-Message-State: AOJu0YwF5RXcfZ2yiW6QqrrA+rSzUbQImE1bCd6sXKaQP/IZky+rj6wv D2PJ7g2BXJ7ERLMlF/yuBLXx5KACxPU6XNlPEZSX9hgA9LDvFBncpGf1Bx19uo8jyAc= X-Gm-Gg: ASbGncsCXYWhOz48XrUXJa0b5lvOes9evat1Nhy5D8NsSSlqkDLd+b80vmQKEE9PygV KS/cFZVWwLvxL4SR5LNiW6yxYr4UuqV5/DGCM0z924DLRy7t2TjSgOiXUX/9ZtDLcirOlUQ8iHr emTr4y4Izkm+tCP9Yhb8VF31cP+TaXOFpVwrfG6lDO8q+2gi1btKCLknPh7OtB8eGs14Aj1Mfyu O8o7o/8BBZ21i7AIa7WLDVdeSu/eNncKBK99uaHL+8Igf3IwZUhgb1zmCwZIBjSD1OVXqBYa5Fd GNWnfbeKvOQwSKRo8D8OITWhVVb45gQTp+mlM1/+b8oMMhGBHcopEcxXnDYPglqR/MeJFD8FTzZ FsNRFtbc8IHY9p5zqf8d4AczT7EDvVMlGm9CVFRzq5/bcrHk0dDKEvoGFwB8VmvmW75l5OcVpr2 N8 X-Google-Smtp-Source: AGHT+IFyrm2w79r4qu/FnmHu4qBJdoxQ8tpCUb7HA7mtPlKxjeyzi9xJQ9J7AuBmZ4uek0zzq2ON9Q== X-Received: by 2002:a05:6512:a85:b0:553:24b4:6492 with SMTP id 2adb3069b0e04-55f0cd6ef0bmr1246189e87.5.1756062288277; Sun, 24 Aug 2025 12:04:48 -0700 (PDT) Received: from [192.168.1.100] (88-112-128-43.elisa-laajakaista.fi. [88.112.128.43]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55f35c8bb4esm1204996e87.75.2025.08.24.12.04.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Aug 2025 12:04:47 -0700 (PDT) Message-ID: Date: Sun, 24 Aug 2025 22:04:45 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/65] media: camss: Replace .open() file operation with v4l2_fh_open() To: Jacopo Mondi , Mauro Carvalho Chehab , Devarsh Thakkar , Benoit Parrot , Hans Verkuil , Laurent Pinchart , Hans de Goede , Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , Alex Shi , Yanteng Si , Jonathan Corbet , Tomasz Figa , Marek Szyprowski , Andy Walls , Michael Tretter , Pengutronix Kernel Team , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Kieran Bingham , Michal Simek , Ming Qian , Zhou Peng , Xavier Roumegue , Philipp Zabel , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Sylwester Nawrocki , Jernej Skrabec , Chen-Yu Tsai , Samuel Holland , Daniel Almeida , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Geert Uytterhoeven , Magnus Damm , Mikhail Ulyanov , Jacob Chen , Heiko Stuebner , Detlev Casanova , Krzysztof Kozlowski , Sylwester Nawrocki , =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Nicolas Dufresne , Benjamin Gaignard , Steve Longerbeam , Maxime Ripard , Paul Kocialkowski , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Robert Foss , Todor Tomov , Corentin Labbe , Sakari Ailus , Stanislaw Gruszka Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, mjpeg-users@lists.sourceforge.net References: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> <20250802-media-private-data-v1-19-eb140ddd6a9d@ideasonboard.com> From: Vladimir Zapolskiy In-Reply-To: <20250802-media-private-data-v1-19-eb140ddd6a9d@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jacopo, Laurent, thank you for the nice clean-up. On 8/2/25 12:22, Jacopo Mondi wrote: > From: Laurent Pinchart > > The custom video_open() function in the camss driver open-codes the > v4l2_fh_open() helper, with an additional mutex that protects the whole > function. Given that the function does not modify any data guarded by > the lock, there's no need for using the mutex and the function can be > replaced by v4l2_fh_open(). > > Signed-off-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi Tested-by: Vladimir Zapolskiy Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir