From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40CCF3FED for ; Mon, 4 Oct 2021 07:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633334391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c37BzLidBYzb5X13SgY9I9yJ9KC600FPw/jSiIVYAh0=; b=FocwmMIt0k8MP8aYaLA/VYXyrBEyL0oeiyKJoQ+mcRQlMeF/Bu7mCQONnR6Cu2Bzvu/Pts rox7d7XeC2YsVSuOOoR0TxrB+HkGAx9vDPez/avjxRsXpSpi2oq++bT5WG0WFZTcS1TiFi /7Lcxj3Duo+plg0gtp4CvaN6wIGByqw= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-091lI0iwNmOdE5kl8jjGBA-1; Mon, 04 Oct 2021 03:59:50 -0400 X-MC-Unique: 091lI0iwNmOdE5kl8jjGBA-1 Received: by mail-ed1-f69.google.com with SMTP id r11-20020aa7cfcb000000b003d4fbd652b9so16318162edy.14 for ; Mon, 04 Oct 2021 00:59:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c37BzLidBYzb5X13SgY9I9yJ9KC600FPw/jSiIVYAh0=; b=UQU2gbaL79ZaN91b641ir5+iTG6ni6NYtdDBjrIB0qhserk+naSqEZeGtsrbeWfOVg ncHh39uG0DJjQAZ1h7oXAxzBVwLzApqEASAvE647EIQnKAuYV3cto1b08oAUNsXs0/a1 Bg25sHBUzG1Aftc4aKftDf21XzUtuTH9ZmtpBSz3zSKdsTU7PxvfHn14TZxe2k1KGzlR s6Pulk98afNkc9NGxyEO7BhsZ9YBgzWNSlg9lEshiNHUKUjWvhbGcQPHP0mCeyf9/Se1 vrMesMqp4NVHels4mF2iXArrAOmTRjc9ecAYUK2UPjkW7j53Z7LWjYu2MBrvm+o2jDq9 mbEQ== X-Gm-Message-State: AOAM53166Rq0Q7CAcolOQE3KRhw3Mqtqr3LaJ7uFagz0pbAgCHJ1MiYf 5zT6sAzqaJ/UbBtzmfPMiS703LE1o8dgPdlccYW9Ym04OhX1dZxpC1JlDnMywkBuYHue9Pkj1iI AF61XukI7K2H5yQZi90dci3BSyw== X-Received: by 2002:a50:bb09:: with SMTP id y9mr16259951ede.89.1633334389018; Mon, 04 Oct 2021 00:59:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzQhV94k4lBT9IBc6lsco946c+YRKUoPG15ShQUP6UiQTbWwVPybN55Udnsy6qXsJkSNGcQA== X-Received: by 2002:a50:bb09:: with SMTP id y9mr16259942ede.89.1633334388849; Mon, 04 Oct 2021 00:59:48 -0700 (PDT) Received: from x1.localdomain ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id n6sm6893877eds.10.2021.10.04.00.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Oct 2021 00:59:48 -0700 (PDT) Subject: Re: [PATCH] staging: rtl8723bs: core: remove condition never execute To: Saurav Girepunje , gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, marcocesati@gmail.com, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Hans de Goede Message-ID: Date: Mon, 4 Oct 2021 09:59:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 10/3/21 5:58 PM, Saurav Girepunje wrote: > Remove condition which never get execute. > as pattrib->mdata is always zero before if condition check. > > Signed-off-by: Saurav Girepunje Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > index b2c042c36777..3ee4d35ca8d7 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > @@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, > else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE) > SetToDs(fctrl); > > - if (pattrib->mdata) > - SetMData(fctrl); > - > qc = (unsigned short *)(pframe + pattrib->hdrlen - 2); > > SetPriority(qc, tid); > -- > 2.32.0 >