From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B24522AE59 for ; Thu, 8 May 2025 13:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746710119; cv=none; b=Szi1zzkl3EYKMwh9iMWeCmxf8J1VNSoKanY7HUeyATzPrh0y6NlyGPJ+auqUl2vEOeUOvmkXhAWTvFNqw59Gyxbr/Xy3KHA22C2C7Cdrl46tBTPyHD6rvwaTgLS27p8RUC1vVkj1haD0H5ULM1wLqdaAsAt/GIdkiX/a9RnHNs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746710119; c=relaxed/simple; bh=XqkFp8Q62Hgx5/ilnKRShqtjfz/INRjKlnDTZZ+KQrY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EsNMZDuQ1yj5+yTSGURftTukBqsKd4X0H2BU3nMIsiqqNbU+ccqtVAOsrFQJzeTmFpTWMoJgXefvqRW1GxlbKxGe7ppegNdoDdb9io22jARazyupTdd3ZUoI7DUolWXWFB9jM2/5uCgrn3ymU1jxyopXub1bdHx6l0zpVnUfg54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bEXyIDv8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bEXyIDv8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746710116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lmFi0BvbaWesUxsWSFddwtAKSlD+TyvgcmgSa8GUXko=; b=bEXyIDv84r/mnRG3AvuIX1J+XgMGZ9Yk5KVcoAfupghHN9gEWOpFZi4f/9HKLwueBPi4TR XiWPyz1O/0qRV3sc7eq3s0zjPogJYrXN63FExcQRZDiwiT3ctKPltVnaLr5j7EN88vWMOa G6q5Mv37TTt6yAwUQSmTJxITkPlOpQU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-G_eTn30QPJ-INBCC9hDpzw-1; Thu, 08 May 2025 09:15:14 -0400 X-MC-Unique: G_eTn30QPJ-INBCC9hDpzw-1 X-Mimecast-MFC-AGG-ID: G_eTn30QPJ-INBCC9hDpzw_1746710114 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5f63ee41315so752224a12.0 for ; Thu, 08 May 2025 06:15:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746710113; x=1747314913; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lmFi0BvbaWesUxsWSFddwtAKSlD+TyvgcmgSa8GUXko=; b=SzY75r94qRz5F2SgYLTE4kNgMzVMACgYBwkfeok2mZf4vr+WwaQeB5VWqTSJhGacTs i2H85W+3oPMw7Fi2siJcZQM9Wa3S4vpxS3vG3ttbtnzlYVShjM4GIhSAA5mSj/yRjvTY +q7dwtfPPOjwzRQWt97JOK2xnj0qyyiOL4jmL2qsg+vSKArKF8e8CTb1tbcL/Ly2Y0q9 1BR+FQb+d/lDw+ZkUA75cx9LrAaFoGbpcjH/461GQ/5gXkYcKeaprXIxOvY4tkKZOLkl 9uZ+8oVebvevpwZC6Iuij8Rif4393cHa1WqncgdsUGWQJPXHYvpiz3boT7i6X359zORD 9XJg== X-Forwarded-Encrypted: i=1; AJvYcCUJffwXXGyTG88Cr2q/yS+Fwh7jXPW2/ZeNhLU5//cL3vpmRqk+S9jugbc7juVL6axJtCRVAKcVNwbZcF2c@lists.linux.dev X-Gm-Message-State: AOJu0YzFZVp6dJIX/bovzc91WPYlcvGvRbCLpo1qaA0J8rMBUqKoDdVP AjZBUYHoOAfh5BF2IBAZ83R1vpLrgPnEWC6zNIzKlAJL6Sx0XM09iYNa7/EygMBKWVY0A8DCwlv wztziyv8oq+JeiBDtzfKWgY4Lcd/fQ6o/qWQMbUrQ12JHlnyXbQ1Lq7tdSNlPYCs= X-Gm-Gg: ASbGncvzEPQALtMqEpdl66aYNl26T5Rainhf5JaCgxd5ajfQFl1AoX896rAQuDKblrD zF7FPhHYn6QpjFcTfodS2ej6rF7MDlhij0FnZGzHhkdmjyc02bXYva+GNB3T1HV0V+CfM8/XEmU MhhwIHvcSxmobvHfs7z3brrxXRNSxqOz61mzTqKiOI7BhyTikCGdVnxRkCrdnrXMf0lz2ihYBBQ WEw4lgHsCFz15ryu9SPlKGDKN0lqhY99nDjl5k1O1TEMUZX7uNwhLX1GfHdWopBJ54+xY29SHYB eVHranKOWQXZBO9LbtiKhz8aPuAkZtPyXZAgDfgkig4IJ6JT6AYQIBLNK8kQ2TyyJWUujDl8xbn COyjvvM3K4VzbAkKwvkSn1rjtVm4aUPxFpuM27PJxCOKIPv1++g8gfJ2Uj8TAQQ== X-Received: by 2002:a05:6402:2691:b0:5e0:892f:89ae with SMTP id 4fb4d7f45d1cf-5fc34e585c8mr3040936a12.4.1746710113617; Thu, 08 May 2025 06:15:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnc4ngHaCx+piUSXWfkfvJF8SnlajfUx/OxaeFxdQDqKvgTaSsjOh3H40FUsWbK11MrUzc8Q== X-Received: by 2002:a05:6402:2691:b0:5e0:892f:89ae with SMTP id 4fb4d7f45d1cf-5fc34e585c8mr3040901a12.4.1746710113072; Thu, 08 May 2025 06:15:13 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fa77bea456sm11369201a12.65.2025.05.08.06.15.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 06:15:12 -0700 (PDT) Message-ID: Date: Thu, 8 May 2025 15:15:11 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] platform/x86: int3472: Allow re-using sensor GPIO mapping in atomisp To: Andy Shevchenko Cc: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Sakari Ailus , platform-driver-x86@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-staging@lists.linux.dev References: <20250507184737.154747-1-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mp0xHZ8Y397gQU5xihifaOLre2ax02YUoG5aVoNvwjc_1746710114 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 8-May-25 10:37 AM, Andy Shevchenko wrote: > On Thu, May 8, 2025 at 11:36 AM Andy Shevchenko > wrote: >> On Wed, May 7, 2025 at 9:52 PM Hans de Goede wrote: >> >>> This patch series does some small refactoring of the int3472 code to allow >>> re-using the sensor GPIO mapping code in the atomisp driver and then the >>> final patch in the series moves the atomisp driver over. >>> >>> About merging this, maybe the int3472 patches can be merged in time for >>> the 6.16 merge window and then the atomisp patch can be merged after >>> 6.16-rc1 is released, otherwise an immutable pdx86 branch with the first >>> 5 patches will be necessary. >> >> Overall I'm pretty much liking this series, but one comment against >> the last patch (see there) and one question here. Can you isolate GPIO >> mapping code in a separate file, please? This will help to generalise >> this code outside of two mentioned drivers (I might need it in the >> future for something else, not related to cameras at all). > > Ah, and formal > Reviewed-by: Andy Shevchenko > for patches 1-5. Andy, Sakari, Thank you both for your reviews of patches 1-5. Ilpo, since patches 1-5 have 2 Reviewed-by-s now, can we maybe still get those in before the 6.16 merge window ? That would make merging patch 6/6 a bit easier, avoiding the need to have an immutable branch for the int3472 bits patch 6/6 depends on. Regards, Hans