From: Stefan Wahren <stefan.wahren@i2se.com>
To: Gaston Gonzalez <gascoar@gmail.com>, linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
juerg.haefliger@canonical.com, rdunlap@infradead.org,
dave.stevenson@raspberrypi.com, unixbhaskar@gmail.com,
mitaliborkar810@gmail.com, phil@raspberrypi.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: vc04_services: avoid the use of typedef for function pointers
Date: Tue, 21 Dec 2021 00:28:06 +0100 [thread overview]
Message-ID: <fd3aa2dc-cef0-4e80-d0b8-e554fd21c89f@i2se.com> (raw)
In-Reply-To: <7f681ccee713ef8600f40c765b6a59e119c6bf2c.1639858361.git.gascoar@gmail.com>
Am 20.12.21 um 22:29 schrieb Gaston Gonzalez:
> Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to
> better align with the linux kernel coding style.
>
> Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> ---
> .../vc04_services/bcm2835-camera/controls.c | 76 +++++++++----------
> 1 file changed, 35 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> index b096a12387f7..7782742396fc 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type {
> MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */
> };
>
> -struct bm2835_mmal_v4l2_ctrl;
Oh dear, in the whole kernel it's always bcm2835 and not bm2835. I don't
see any good reason for the different naming and the resulting confusion.
@Gaston: it's not your fault, but it would be nice to have this fixed.
next prev parent reply other threads:[~2021-12-20 23:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:29 [PATCH 0/4] staging: vc04_services: avoid the use of typedef for function pointers Gaston Gonzalez
2021-12-20 21:29 ` [PATCH 1/4] " Gaston Gonzalez
2021-12-20 21:29 ` [PATCH 2/4] " Gaston Gonzalez
2021-12-20 23:28 ` Stefan Wahren [this message]
2021-12-21 6:19 ` Greg KH
2021-12-21 20:41 ` Gaston Gonzalez
2021-12-20 21:29 ` [PATCH 3/4] " Gaston Gonzalez
2021-12-21 6:22 ` Greg KH
2021-12-21 20:43 ` Gaston Gonzalez
2021-12-20 21:29 ` [PATCH 4/4] staging: vc04_services: update TODO file Gaston Gonzalez
2021-12-21 6:20 ` [PATCH 0/4] staging: vc04_services: avoid the use of typedef for function pointers Greg KH
2021-12-21 20:40 ` Gaston Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3aa2dc-cef0-4e80-d0b8-e554fd21c89f@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=juerg.haefliger@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitaliborkar810@gmail.com \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rdunlap@infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).