* [PATCH v3] dt-bindings: misc: add binding for Xilinx AXI-Stream FIFO
From: Aditya Chari @ 2026-06-21 9:43 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, gregkh
Cc: jacobsfeder, devicetree, linux-staging, linux-kernel,
Aditya Chari
In-Reply-To: <20260621085209.52651-1-adi25charis@gmail.com>
The axis-fifo driver's compatible strings were undocumented, flagged
by checkpatch.pl as UNDOCUMENTED_DT_STRING. Add a YAML devicetree
binding document for drivers/staging/axis-fifo, converted from and
replacing the existing free-form text binding (axis-fifo.txt), which
this patch removes.
Constrain xlnx,tx-fifo-depth to a minimum of 4, since the driver
subtracts 4 from this value in its transmit bounds check and a
smaller value would underflow that check.
Signed-off-by: Aditya Chari <adi25charis@gmail.com>
---
Changes since v2:
- Added $ref: /schemas/types.yaml#/definitions/string to the three
AXI-Stream protocol enum properties (xlnx,axi-str-rxd-protocol,
xlnx,axi-str-txd-protocol, xlnx,axi-str-txc-protocol) for explicit
type consistency with the rest of the schema.
- Added minimum: 4 to xlnx,tx-fifo-depth, since the driver subtracts
4 from this value in its transmit bounds check
(axis_fifo_write()) and a smaller configured value would underflow
that unsigned check, bypassing the oversized-packet guard.
Changes since v1:
- Fixed xlnx,rx/tx-fifo-depth: depth is in 32-bit words, not bytes,
matching the driver's overflow check in axis_fifo_write() and the
wording of the original text binding.
- Restored the full set of hardware-generated properties (interrupt-
names, AXI-Stream protocol/width properties, has-axis-t* feature
flags, fifo threshold properties, etc.) so that additionalProperties:
false does not reject valid device trees generated for real hardware.
- Removed the now-superseded axis-fifo.txt text binding.
.../bindings/misc/xlnx,axi-fifo-mm-s.yaml | 227 ++++++++++++++++++
drivers/staging/axis-fifo/axis-fifo.txt | 96 --------
2 files changed, 227 insertions(+), 96 deletions(-)
create mode 100644 Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
delete mode 100644 drivers/staging/axis-fifo/axis-fifo.txt
diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
new file mode 100644
index 000000000..53bf52524
--- /dev/null
+++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
@@ -0,0 +1,227 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/misc/xlnx,axi-fifo-mm-s.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xilinx AXI-Stream FIFO (axis-fifo)
+
+maintainers:
+ - Jacob Feder <jacobsfeder@gmail.com>
+
+description:
+ The AXI-Stream FIFO (AXIS-FIFO) IP core provides a memory-mapped AXI4-Lite
+ interface for sending and receiving data over an AXI4-Stream interface
+ using FIFO buffers. Currently supports only store-forward mode with a
+ 32-bit AXI4-Lite interface; cut-through mode and full AXI4 are not
+ supported. See Xilinx PG080 for IP details.
+
+properties:
+ compatible:
+ enum:
+ - xlnx,axi-fifo-mm-s-4.1
+ - xlnx,axi-fifo-mm-s-4.2
+ - xlnx,axi-fifo-mm-s-4.3
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-names:
+ items:
+ - const: interrupt
+
+ xlnx,axi-str-rxd-tdata-width:
+ description:
+ Width in bits of the AXI4-Stream receive data interface. Only a
+ width of 32 is currently supported by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 32
+
+ xlnx,axi-str-txd-tdata-width:
+ description:
+ Width in bits of the AXI4-Stream transmit data interface. Only a
+ width of 32 is currently supported by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 32
+
+ xlnx,axi-str-txc-tdata-width:
+ description:
+ Width in bits of the AXI4-Stream transmit control interface.
+ Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,axi-str-rxd-protocol:
+ description: AXI-Stream receive data protocol. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/string
+ enum: [ XIL_AXI_STREAM_ETH_DATA ]
+
+ xlnx,axi-str-txd-protocol:
+ description: AXI-Stream transmit data protocol. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/string
+ enum: [ XIL_AXI_STREAM_ETH_DATA ]
+
+ xlnx,axi-str-txc-protocol:
+ description: AXI-Stream transmit control protocol. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/string
+ enum: [ XIL_AXI_STREAM_ETH_CTRL ]
+
+ xlnx,axis-tdest-width:
+ description: AXI-Stream TDEST width. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,axis-tid-width:
+ description: AXI-Stream TID width. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,axis-tuser-width:
+ description: AXI-Stream TUSER width. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,data-interface-type:
+ description: Data interface type. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,has-axis-tdest:
+ description:
+ Whether the AXI-Stream interface has TDEST. This feature is not
+ supported by the driver and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,has-axis-tid:
+ description:
+ Whether the AXI-Stream interface has TID. This feature is not
+ supported by the driver and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,has-axis-tkeep:
+ description:
+ Whether the AXI-Stream interface has TKEEP. This feature is not
+ supported by the driver and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,has-axis-tstrb:
+ description:
+ Whether the AXI-Stream interface has TSTRB. This feature is not
+ supported by the driver and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,has-axis-tuser:
+ description:
+ Whether the AXI-Stream interface has TUSER. This feature is not
+ supported by the driver and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,rx-fifo-depth:
+ description:
+ Depth in 32-bit words of the receive FIFO, as configured in the
+ IP core.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,rx-fifo-pe-threshold:
+ description: RX programmable empty interrupt threshold. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,rx-fifo-pf-threshold:
+ description: RX programmable full interrupt threshold. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,s-axi-id-width:
+ description: AXI4-Lite ID width. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,s-axi4-data-width:
+ description: AXI4-Lite data width. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,select-xpm:
+ description: Whether XPM macros are used. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,tx-fifo-depth:
+ description:
+ Depth in 32-bit words of the transmit FIFO, as configured in the
+ IP core. Must be at least 4; the driver subtracts 4 from this
+ value when bounds-checking transmit writes, and a smaller value
+ underflows that check.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 4
+
+ xlnx,tx-fifo-pe-threshold:
+ description: TX programmable empty interrupt threshold. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,tx-fifo-pf-threshold:
+ description: TX programmable full interrupt threshold. Ignored by the driver.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ xlnx,use-rx-cut-through:
+ description:
+ Whether RX cut-through mode is used. Not supported by the driver
+ and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,use-rx-data:
+ description:
+ Indicates whether the receive data path is present, as configured
+ in the IP core. A value of 1 enables the receive path, 0 disables it.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [ 0, 1 ]
+
+ xlnx,use-tx-ctrl:
+ description:
+ Whether the transmit control interface is used. Not supported by
+ the driver and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,use-tx-cut-through:
+ description:
+ Whether TX cut-through mode is used. Not supported by the driver
+ and must be 0.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ const: 0
+
+ xlnx,use-tx-data:
+ description:
+ Indicates whether the transmit data path is present, as configured
+ in the IP core. A value of 1 enables the transmit path, 0 disables it.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [ 0, 1 ]
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - xlnx,axi-str-rxd-tdata-width
+ - xlnx,axi-str-txd-tdata-width
+ - xlnx,rx-fifo-depth
+ - xlnx,tx-fifo-depth
+ - xlnx,use-rx-data
+ - xlnx,use-tx-data
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ axi_fifo_mm_s_0: axi-fifo-mm-s@40000000 {
+ compatible = "xlnx,axi-fifo-mm-s-4.1";
+ reg = <0x40000000 0x10000>;
+ interrupts = <0 29 IRQ_TYPE_LEVEL_HIGH>;
+ xlnx,axi-str-rxd-tdata-width = <32>;
+ xlnx,axi-str-txd-tdata-width = <32>;
+ xlnx,rx-fifo-depth = <512>;
+ xlnx,tx-fifo-depth = <32768>;
+ xlnx,use-rx-data = <1>;
+ xlnx,use-tx-data = <1>;
+ };
diff --git a/drivers/staging/axis-fifo/axis-fifo.txt b/drivers/staging/axis-fifo/axis-fifo.txt
deleted file mode 100644
index 413b81a53..000000000
--- a/drivers/staging/axis-fifo/axis-fifo.txt
+++ /dev/null
@@ -1,96 +0,0 @@
-Xilinx AXI-Stream FIFO v4.1 IP core
-
-This IP core has read and write AXI-Stream FIFOs, the contents of which can
-be accessed from the AXI4 memory-mapped interface. This is useful for
-transferring data from a processor into the FPGA fabric. The driver creates
-a character device that can be read/written to with standard
-open/read/write/close.
-
-See Xilinx PG080 document for IP details.
-
-Currently supports only store-forward mode with a 32-bit
-AXI4-Lite interface. DOES NOT support:
- - cut-through mode
- - AXI4 (non-lite)
-
-Required properties:
-- compatible: Should be one of:
- "xlnx,axi-fifo-mm-s-4.1"
- "xlnx,axi-fifo-mm-s-4.2"
- "xlnx,axi-fifo-mm-s-4.3"
-- interrupt-names: Should be "interrupt"
-- interrupt-parent: Should be <&intc>
-- interrupts: Should contain interrupts lines.
-- reg: Should contain registers location and length.
-- xlnx,axi-str-rxd-protocol: Should be "XIL_AXI_STREAM_ETH_DATA"
-- xlnx,axi-str-rxd-tdata-width: Should be <0x20>
-- xlnx,axi-str-txc-protocol: Should be "XIL_AXI_STREAM_ETH_CTRL"
-- xlnx,axi-str-txc-tdata-width: Should be <0x20>
-- xlnx,axi-str-txd-protocol: Should be "XIL_AXI_STREAM_ETH_DATA"
-- xlnx,axi-str-txd-tdata-width: Should be <0x20>
-- xlnx,axis-tdest-width: AXI-Stream TDEST width (ignored by the driver)
-- xlnx,axis-tid-width: AXI-Stream TID width (ignored by the driver)
-- xlnx,axis-tuser-width: AXI-Stream TUSER width (ignored by the driver)
-- xlnx,data-interface-type: Should be <0x0> (ignored by the driver)
-- xlnx,has-axis-tdest: Should be <0x0> (this feature isn't supported)
-- xlnx,has-axis-tid: Should be <0x0> (this feature isn't supported)
-- xlnx,has-axis-tkeep: Should be <0x0> (this feature isn't supported)
-- xlnx,has-axis-tstrb: Should be <0x0> (this feature isn't supported)
-- xlnx,has-axis-tuser: Should be <0x0> (this feature isn't supported)
-- xlnx,rx-fifo-depth: Depth of RX FIFO in words
-- xlnx,rx-fifo-pe-threshold: RX programmable empty interrupt threshold
- (ignored by the driver)
-- xlnx,rx-fifo-pf-threshold: RX programmable full interrupt threshold
- (ignored by the driver)
-- xlnx,s-axi-id-width: Should be <0x4> (ignored by the driver)
-- xlnx,s-axi4-data-width: Should be <0x20> (ignored by the driver)
-- xlnx,select-xpm: Should be <0x0> (ignored by the driver)
-- xlnx,tx-fifo-depth: Depth of TX FIFO in words
-- xlnx,tx-fifo-pe-threshold: TX programmable empty interrupt threshold
- (ignored by the driver)
-- xlnx,tx-fifo-pf-threshold: TX programmable full interrupt threshold
- (ignored by the driver)
-- xlnx,use-rx-cut-through: Should be <0x0> (this feature isn't supported)
-- xlnx,use-rx-data: <0x1> if RX FIFO is enabled, <0x0> otherwise
-- xlnx,use-tx-ctrl: Should be <0x0> (this feature isn't supported)
-- xlnx,use-tx-cut-through: Should be <0x0> (this feature isn't supported)
-- xlnx,use-tx-data: <0x1> if TX FIFO is enabled, <0x0> otherwise
-
-Example:
-
-axi_fifo_mm_s_0: axi_fifo_mm_s@43c00000 {
- compatible = "xlnx,axi-fifo-mm-s-4.1";
- interrupt-names = "interrupt";
- interrupt-parent = <&intc>;
- interrupts = <0 29 4>;
- reg = <0x43c00000 0x10000>;
- xlnx,axi-str-rxd-protocol = "XIL_AXI_STREAM_ETH_DATA";
- xlnx,axi-str-rxd-tdata-width = <0x20>;
- xlnx,axi-str-txc-protocol = "XIL_AXI_STREAM_ETH_CTRL";
- xlnx,axi-str-txc-tdata-width = <0x20>;
- xlnx,axi-str-txd-protocol = "XIL_AXI_STREAM_ETH_DATA";
- xlnx,axi-str-txd-tdata-width = <0x20>;
- xlnx,axis-tdest-width = <0x4>;
- xlnx,axis-tid-width = <0x4>;
- xlnx,axis-tuser-width = <0x4>;
- xlnx,data-interface-type = <0x0>;
- xlnx,has-axis-tdest = <0x0>;
- xlnx,has-axis-tid = <0x0>;
- xlnx,has-axis-tkeep = <0x0>;
- xlnx,has-axis-tstrb = <0x0>;
- xlnx,has-axis-tuser = <0x0>;
- xlnx,rx-fifo-depth = <0x200>;
- xlnx,rx-fifo-pe-threshold = <0x2>;
- xlnx,rx-fifo-pf-threshold = <0x1fb>;
- xlnx,s-axi-id-width = <0x4>;
- xlnx,s-axi4-data-width = <0x20>;
- xlnx,select-xpm = <0x0>;
- xlnx,tx-fifo-depth = <0x8000>;
- xlnx,tx-fifo-pe-threshold = <0x200>;
- xlnx,tx-fifo-pf-threshold = <0x7ffb>;
- xlnx,use-rx-cut-through = <0x0>;
- xlnx,use-rx-data = <0x0>;
- xlnx,use-tx-ctrl = <0x0>;
- xlnx,use-tx-cut-through = <0x0>;
- xlnx,use-tx-data = <0x1>;
-};
--
2.53.0
^ permalink raw reply related
* [PATCH 0/2] staging: rtl8723bs: simplify the phy_RF6052_Config_ParaFile() function
From: Nikolay Kulikov @ 2026-06-21 16:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, Nikolay Kulikov
Siplify the function by removing the loop and unreachable switch-case
statements.
Nikolay Kulikov (2):
staging: rtl8723bs: remove 'NumTotalRFPath' from 'struct hal_com_data'
staging: rtl8723bs: remove local variable 'eRFPath'
.../staging/rtl8723bs/hal/rtl8723b_rf6052.c | 83 ++++++-------------
drivers/staging/rtl8723bs/include/hal_data.h | 2 -
2 files changed, 26 insertions(+), 59 deletions(-)
base-commit: 7cb1c5b32a2bfde961fff8d5204526b609bcb30a
--
2.54.0
^ permalink raw reply
* [PATCH 1/2] staging: rtl8723bs: remove 'NumTotalRFPath' from 'struct hal_com_data'
From: Nikolay Kulikov @ 2026-06-21 16:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, Nikolay Kulikov
In-Reply-To: <20260621161611.111461-1-nikolayof23@gmail.com>
This variable is assigned the value 1, after which it is used as a loop
delimiter. Since it always stores 1, only one loop iteration is
performed. We can remove the 'NumTotalRFPath' field and remove the loop
by calling its body directly to simplify the code.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
.../staging/rtl8723bs/hal/rtl8723b_rf6052.c | 102 ++++++++----------
drivers/staging/rtl8723bs/include/hal_data.h | 2 -
2 files changed, 46 insertions(+), 58 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
index da4cb28276b2..86759516838b 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
@@ -81,61 +81,58 @@ void PHY_RF6052SetBandwidth8723B(
static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
{
u32 u4RegValue = 0;
- u8 eRFPath;
+ u8 eRFPath = 0;
struct bb_register_def *pPhyReg;
struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
/* 3----------------------------------------------------------------- */
/* 3 <2> Initialize RF */
/* 3----------------------------------------------------------------- */
- /* for (eRFPath = RF_PATH_A; eRFPath <pHalData->NumTotalRFPath; eRFPath++) */
- for (eRFPath = 0; eRFPath < pHalData->NumTotalRFPath; eRFPath++) {
-
- pPhyReg = &pHalData->PHYRegDef[eRFPath];
-
- /*----Store original RFENV control type----*/
- switch (eRFPath) {
- case RF_PATH_A:
- u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV);
- break;
- case RF_PATH_B:
- u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV << 16);
- break;
- }
-
- /*----Set RF_ENV enable----*/
- PHY_SetBBReg(Adapter, pPhyReg->rfintfe, bRFSI_RFENV << 16, 0x1);
- udelay(1);/* PlatformStallExecution(1); */
-
- /*----Set RF_ENV output high----*/
- PHY_SetBBReg(Adapter, pPhyReg->rfintfo, bRFSI_RFENV, 0x1);
- udelay(1);/* PlatformStallExecution(1); */
-
- /* Set bit number of Address and Data for RF register */
- PHY_SetBBReg(Adapter, pPhyReg->rfHSSIPara2, b3WireAddressLength, 0x0); /* Set 1 to 4 bits for 8255 */
- udelay(1);/* PlatformStallExecution(1); */
-
- PHY_SetBBReg(Adapter, pPhyReg->rfHSSIPara2, b3WireDataLength, 0x0); /* Set 0 to 12 bits for 8255 */
- udelay(1);/* PlatformStallExecution(1); */
-
- /*----Initialize RF fom connfiguration file----*/
- switch (eRFPath) {
- case RF_PATH_A:
- case RF_PATH_B:
- ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv,
- CONFIG_RF_RADIO, eRFPath);
- break;
- }
-
- /*----Restore RFENV control type----*/
- switch (eRFPath) {
- case RF_PATH_A:
- PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV, u4RegValue);
- break;
- case RF_PATH_B:
- PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV << 16, u4RegValue);
- break;
- }
+
+ pPhyReg = &pHalData->PHYRegDef[eRFPath];
+
+ /*----Store original RFENV control type----*/
+ switch (eRFPath) {
+ case RF_PATH_A:
+ u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV);
+ break;
+ case RF_PATH_B:
+ u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV << 16);
+ break;
+ }
+
+ /*----Set RF_ENV enable----*/
+ PHY_SetBBReg(Adapter, pPhyReg->rfintfe, bRFSI_RFENV << 16, 0x1);
+ udelay(1);/* PlatformStallExecution(1); */
+
+ /*----Set RF_ENV output high----*/
+ PHY_SetBBReg(Adapter, pPhyReg->rfintfo, bRFSI_RFENV, 0x1);
+ udelay(1);/* PlatformStallExecution(1); */
+
+ /* Set bit number of Address and Data for RF register */
+ PHY_SetBBReg(Adapter, pPhyReg->rfHSSIPara2, b3WireAddressLength, 0x0); /* Set 1 to 4 bits for 8255 */
+ udelay(1);/* PlatformStallExecution(1); */
+
+ PHY_SetBBReg(Adapter, pPhyReg->rfHSSIPara2, b3WireDataLength, 0x0); /* Set 0 to 12 bits for 8255 */
+ udelay(1);/* PlatformStallExecution(1); */
+
+ /*----Initialize RF fom connfiguration file----*/
+ switch (eRFPath) {
+ case RF_PATH_A:
+ case RF_PATH_B:
+ ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv,
+ CONFIG_RF_RADIO, eRFPath);
+ break;
+ }
+
+ /*----Restore RFENV control type----*/
+ switch (eRFPath) {
+ case RF_PATH_A:
+ PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV, u4RegValue);
+ break;
+ case RF_PATH_B:
+ PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV << 16, u4RegValue);
+ break;
}
/* 3 ----------------------------------------------------------------- */
@@ -149,13 +146,6 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
int PHY_RF6052_Config8723B(struct adapter *Adapter)
{
- struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
-
- /* */
- /* Initialize general global value */
- /* */
- pHalData->NumTotalRFPath = 1;
-
/* */
/* Config BB and RF */
/* */
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 3a93ac312ded..5796e477dcb5 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -187,7 +187,6 @@ struct hal_com_data {
/* rf_ctrl */
u8 rf_chip;
u8 PackageType;
- u8 NumTotalRFPath;
u8 InterfaceSel;
u8 framesync;
@@ -392,7 +391,6 @@ struct hal_com_data {
};
#define GET_HAL_DATA(__padapter) ((struct hal_com_data *)((__padapter)->HalData))
-#define GET_HAL_RFPATH_NUM(__padapter) (((struct hal_com_data *)((__padapter)->HalData))->NumTotalRFPath)
#define RT_GetInterfaceSelection(_Adapter) (GET_HAL_DATA(_Adapter)->InterfaceSel)
#endif /* __HAL_DATA_H__ */
--
2.54.0
^ permalink raw reply related
* [PATCH 2/2] staging: rtl8723bs: remove local variable 'eRFPath'
From: Nikolay Kulikov @ 2026-06-21 16:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, Nikolay Kulikov
In-Reply-To: <20260621161611.111461-1-nikolayof23@gmail.com>
After removing the loop from the phy_RF6052_Config_ParaFile() function,
the value of this variable can no longer be changed, allowing all
switch-case statements to be known in advance, since it stores the value
0 (which is 'RF_PATH_A', defined in enum rf_path).
Therefore, remove it and the associated dead code and access 'RF_PATH_A'
directly.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
.../staging/rtl8723bs/hal/rtl8723b_rf6052.c | 29 +++----------------
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
index 86759516838b..fac1270853de 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
@@ -81,7 +81,6 @@ void PHY_RF6052SetBandwidth8723B(
static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
{
u32 u4RegValue = 0;
- u8 eRFPath = 0;
struct bb_register_def *pPhyReg;
struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
@@ -89,17 +88,10 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
/* 3 <2> Initialize RF */
/* 3----------------------------------------------------------------- */
- pPhyReg = &pHalData->PHYRegDef[eRFPath];
+ pPhyReg = &pHalData->PHYRegDef[RF_PATH_A];
/*----Store original RFENV control type----*/
- switch (eRFPath) {
- case RF_PATH_A:
- u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV);
- break;
- case RF_PATH_B:
- u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV << 16);
- break;
- }
+ u4RegValue = PHY_QueryBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV);
/*----Set RF_ENV enable----*/
PHY_SetBBReg(Adapter, pPhyReg->rfintfe, bRFSI_RFENV << 16, 0x1);
@@ -117,23 +109,10 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
udelay(1);/* PlatformStallExecution(1); */
/*----Initialize RF fom connfiguration file----*/
- switch (eRFPath) {
- case RF_PATH_A:
- case RF_PATH_B:
- ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv,
- CONFIG_RF_RADIO, eRFPath);
- break;
- }
+ ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_RADIO, RF_PATH_A);
/*----Restore RFENV control type----*/
- switch (eRFPath) {
- case RF_PATH_A:
- PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV, u4RegValue);
- break;
- case RF_PATH_B:
- PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV << 16, u4RegValue);
- break;
- }
+ PHY_SetBBReg(Adapter, pPhyReg->rfintfs, bRFSI_RFENV, u4RegValue);
/* 3 ----------------------------------------------------------------- */
/* 3 Configuration of Tx Power Tracking */
--
2.54.0
^ permalink raw reply related
* Re: [PATCH v3] dt-bindings: misc: add binding for Xilinx AXI-Stream FIFO
From: Krzysztof Kozlowski @ 2026-06-21 18:33 UTC (permalink / raw)
To: Aditya Chari, robh, krzk+dt, conor+dt, gregkh
Cc: jacobsfeder, devicetree, linux-staging, linux-kernel
In-Reply-To: <20260621094312.53655-1-adi25charis@gmail.com>
On 21/06/2026 11:43, Aditya Chari wrote:
> The axis-fifo driver's compatible strings were undocumented, flagged
> by checkpatch.pl as UNDOCUMENTED_DT_STRING. Add a YAML devicetree
> binding document for drivers/staging/axis-fifo, converted from and
> replacing the existing free-form text binding (axis-fifo.txt), which
> this patch removes.
>
> Constrain xlnx,tx-fifo-depth to a minimum of 4, since the driver
> subtracts 4 from this value in its transmit bounds check and a
> smaller value would underflow that check.
>
> Signed-off-by: Aditya Chari <adi25charis@gmail.com>
> ---
>
> Changes since v2:
> - Added $ref: /schemas/types.yaml#/definitions/string to the three
> AXI-Stream protocol enum properties (xlnx,axi-str-rxd-protocol,
> xlnx,axi-str-txd-protocol, xlnx,axi-str-txc-protocol) for explicit
> type consistency with the rest of the schema.
> - Added minimum: 4 to xlnx,tx-fifo-depth, since the driver subtracts
> 4 from this value in its transmit bounds check
> (axis_fifo_write()) and a smaller configured value would underflow
> that unsigned check, bypassing the oversized-packet guard.
>
> Changes since v1:
> - Fixed xlnx,rx/tx-fifo-depth: depth is in 32-bit words, not bytes,
> matching the driver's overflow check in axis_fifo_write() and the
> wording of the original text binding.
> - Restored the full set of hardware-generated properties (interrupt-
> names, AXI-Stream protocol/width properties, has-axis-t* feature
> flags, fifo threshold properties, etc.) so that additionalProperties:
> false does not reject valid device trees generated for real hardware.
> - Removed the now-superseded axis-fifo.txt text binding.
Please slow down. Three versions within 1 hour! Why sending something
and immediately sending fixes to it?
>
> .../bindings/misc/xlnx,axi-fifo-mm-s.yaml | 227 ++++++++++++++++++
> drivers/staging/axis-fifo/axis-fifo.txt | 96 --------
Why are you touching staging binding?
https://lore.kernel.org/all/?q=dfn%3Aaxis-fifo.txt
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v3] dt-bindings: misc: add binding for Xilinx AXI-Stream FIFO
From: Aditya Chari S @ 2026-06-22 4:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh, krzk+dt, conor+dt, gregkh
Cc: jacobsfeder, devicetree, linux-staging, linux-kernel,
michal.simek, lucas.fariamo08
In-Reply-To: <548d66ce-d01e-4c6a-a77e-7d61378a1c74@kernel.org>
Sorry about the pace - jumped from automated lint feedback straight to
a new version without waiting for an actual reviewer. Won't happen
again.
On the staging binding question - I found the driver-removal thread
from June 2 and read through it. Michal Simek's reply makes clear this
driver isn't going anywhere (their networking team has plans that
depend on it), and that there's already an in-flight binding
conversion from Lucas Faria Mendes that he's actively tracking. I
wasn't aware of that series when I started this.
Given that, I'll withdraw mine rather than duplicate work that's
already further along and already has the relevant maintainer's eyes
on it.
Thanks for pointing me toward the history.
Regards,
Aditya
^ permalink raw reply
* [staging] staging: greybus: loopback: add missing comment for mutex
From: Arnav Kapoor @ 2026-06-22 4:27 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Johan Hovold, linux-staging, greybus-dev, Arnav Kapoor
Add a comment for the mutex as suggested by checkpatch.
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
---
drivers/staging/greybus/loopback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index ea57b1f5d..bf827e672 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -61,7 +61,7 @@ struct gb_loopback {
struct dentry *file;
struct kfifo kfifo_lat;
- struct mutex mutex;
+ struct mutex mutex; /* protects the entire structure */
struct task_struct *task;
struct device *dev;
wait_queue_head_t wq;
--
2.53.0
^ permalink raw reply related
* Re: [PATCH v3] dt-bindings: misc: add binding for Xilinx AXI-Stream FIFO
From: Krzysztof Kozlowski @ 2026-06-22 5:18 UTC (permalink / raw)
To: Aditya Chari S, robh, krzk+dt, conor+dt, gregkh
Cc: jacobsfeder, devicetree, linux-staging, linux-kernel,
michal.simek, lucas.fariamo08
In-Reply-To: <CAKt_FXsiXv7dai+F7cT=GNvETa5_42su9G1ev8+_fph0Bg5EbA@mail.gmail.com>
On 22/06/2026 06:21, Aditya Chari S wrote:
> Sorry about the pace - jumped from automated lint feedback straight to
> a new version without waiting for an actual reviewer. Won't happen
> again.
>
> On the staging binding question - I found the driver-removal thread
> from June 2 and read through it. Michal Simek's reply makes clear this
> driver isn't going anywhere (their networking team has plans that
> depend on it), and that there's already an in-flight binding
> conversion from Lucas Faria Mendes that he's actively tracking. I
> wasn't aware of that series when I started this.
>
> Given that, I'll withdraw mine rather than duplicate work that's
> already further along and already has the relevant maintainer's eyes
> on it.
>
The main point is that driver is in staging, so we don't take bindings
for it.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v3] dt-bindings: misc: add binding for Xilinx AXI-Stream FIFO
From: Aditya Chari S @ 2026-06-22 6:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh, krzk+dt, conor+dt, gregkh
Cc: jacobsfeder, devicetree, linux-staging, linux-kernel,
michal.simek, lucas.fariamo08
In-Reply-To: <37006444-95a7-41f1-a5a3-58d116c10c14@kernel.org>
On Mon, Jun 22, 2026, Krzysztof Kozlowski wrote:
> The main point is that driver is in staging, so we don't take bindings
> for it.
Understood, thanks for clarifying.
Regards,
Aditya
On Mon, Jun 22, 2026 at 10:48 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 22/06/2026 06:21, Aditya Chari S wrote:
> > Sorry about the pace - jumped from automated lint feedback straight to
> > a new version without waiting for an actual reviewer. Won't happen
> > again.
> >
> > On the staging binding question - I found the driver-removal thread
> > from June 2 and read through it. Michal Simek's reply makes clear this
> > driver isn't going anywhere (their networking team has plans that
> > depend on it), and that there's already an in-flight binding
> > conversion from Lucas Faria Mendes that he's actively tracking. I
> > wasn't aware of that series when I started this.
> >
> > Given that, I'll withdraw mine rather than duplicate work that's
> > already further along and already has the relevant maintainer's eyes
> > on it.
> >
>
> The main point is that driver is in staging, so we don't take bindings
> for it.
>
> Best regards,
> Krzysztof
^ permalink raw reply
* [PATCH 0/3] staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in os_dep
From: Moksh Panicker @ 2026-06-22 6:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, skhan, Moksh Panicker
This series replaces bare uses of 'uint' with 'unsigned int' in the
os_dep directory of the rtl8723bs staging driver. This covers the
remaining files not addressed by previous patches, as part of cleaning
up unusual variable types listed in the driver's TODO file.
Note: os_intfs.c lines using 'uint' as module_param type specifier
are intentionally left unchanged as that is a kernel API requirement.
Each patch addresses one file independently.
Moksh Panicker (3):
staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in
ioctl_cfg80211.c
staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in
xmit_linux.c
staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in
os_intfs.c
drivers/staging/rtl8723bs/include/ioctl_cfg80211.h | 4 ++--
drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 +-
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 12 ++++++------
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
--
2.34.1
^ permalink raw reply
* [PATCH 1/3] staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in ioctl_cfg80211.c
From: Moksh Panicker @ 2026-06-22 6:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, skhan, Moksh Panicker
In-Reply-To: <20260622064129.10261-1-mokshpanicker.7@gmail.com>
Replace bare use of 'uint' with 'unsigned int' in function parameters
and local variables in ioctl_cfg80211.c and its corresponding header
ioctl_cfg80211.h. This fixes the following checkpatch.pl warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/include/ioctl_cfg80211.h | 4 ++--
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/ioctl_cfg80211.h b/drivers/staging/rtl8723bs/include/ioctl_cfg80211.h
index bc62b7285950..a1fc18cd247b 100644
--- a/drivers/staging/rtl8723bs/include/ioctl_cfg80211.h
+++ b/drivers/staging/rtl8723bs/include/ioctl_cfg80211.h
@@ -42,10 +42,10 @@ void rtw_cfg80211_indicate_connect(struct adapter *padapter);
void rtw_cfg80211_indicate_disconnect(struct adapter *padapter);
void rtw_cfg80211_indicate_scan_done(struct adapter *adapter, bool aborted);
-void rtw_cfg80211_indicate_sta_assoc(struct adapter *padapter, u8 *pmgmt_frame, uint frame_len);
+void rtw_cfg80211_indicate_sta_assoc(struct adapter *padapter, u8 *pmgmt_frame, unsigned int frame_len);
void rtw_cfg80211_indicate_sta_disassoc(struct adapter *padapter, unsigned char *da, unsigned short reason);
-void rtw_cfg80211_rx_action(struct adapter *adapter, u8 *frame, uint frame_len, const char *msg);
+void rtw_cfg80211_rx_action(struct adapter *adapter, u8 *frame, unsigned int frame_len, const char *msg);
bool rtw_cfg80211_pwr_mgmt(struct adapter *adapter);
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 1484336d7551..dfb19a9f3d6b 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1152,7 +1152,7 @@ void rtw_cfg80211_surveydone_event_callback(struct adapter *padapter)
static int rtw_cfg80211_set_probe_req_wpsp2pie(struct adapter *padapter, char *buf, int len)
{
int ret = 0;
- uint wps_ielen = 0;
+ unsigned int wps_ielen = 0;
u8 *wps_ie;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
@@ -1515,12 +1515,12 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel
}
{/* handle wps_ie */
- uint wps_ielen;
+ unsigned int wps_ielen;
u8 *wps_ie;
wps_ie = rtw_get_wps_ie(buf, ielen, NULL, &wps_ielen);
if (wps_ie && wps_ielen > 0) {
- padapter->securitypriv.wps_ie_len = min_t(uint, wps_ielen, MAX_WPS_IE_LEN);
+ padapter->securitypriv.wps_ie_len = min_t(unsigned int, wps_ielen, MAX_WPS_IE_LEN);
memcpy(padapter->securitypriv.wps_ie, wps_ie, padapter->securitypriv.wps_ie_len);
set_fwstate(&padapter->mlmepriv, WIFI_UNDER_WPS);
} else {
@@ -1911,7 +1911,7 @@ static int cfg80211_rtw_flush_pmksa(struct wiphy *wiphy,
return 0;
}
-void rtw_cfg80211_indicate_sta_assoc(struct adapter *padapter, u8 *pmgmt_frame, uint frame_len)
+void rtw_cfg80211_indicate_sta_assoc(struct adapter *padapter, u8 *pmgmt_frame, unsigned int frame_len)
{
struct wireless_dev *wdev = padapter->rtw_wdev;
@@ -2247,7 +2247,7 @@ static int rtw_add_beacon(struct adapter *adapter, const u8 *head, size_t head_l
{
int ret = 0;
u8 *pbuf = NULL;
- uint len, wps_ielen = 0;
+ unsigned int len, wps_ielen = 0;
struct mlme_priv *pmlmepriv = &(adapter->mlmepriv);
if (!check_fwstate(pmlmepriv, WIFI_AP_STATE))
@@ -2442,7 +2442,7 @@ static int cfg80211_rtw_dump_station(struct wiphy *wiphy,
return ret;
}
-void rtw_cfg80211_rx_action(struct adapter *adapter, u8 *frame, uint frame_len, const char *msg)
+void rtw_cfg80211_rx_action(struct adapter *adapter, u8 *frame, unsigned int frame_len, const char *msg)
{
s32 freq;
int channel;
--
2.34.1
^ permalink raw reply related
* [PATCH 2/3] staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in xmit_linux.c
From: Moksh Panicker @ 2026-06-22 6:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, skhan, Moksh Panicker
In-Reply-To: <20260622064129.10261-1-mokshpanicker.7@gmail.com>
Replace bare use of 'uint' with 'unsigned int' in rtw_remainder_len()
function definition and its declaration in xmit_osdep.h. This fixes
the following checkpatch.pl warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 +-
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/xmit_osdep.h b/drivers/staging/rtl8723bs/include/xmit_osdep.h
index 5b351652e31b..ee6616880d41 100644
--- a/drivers/staging/rtl8723bs/include/xmit_osdep.h
+++ b/drivers/staging/rtl8723bs/include/xmit_osdep.h
@@ -32,7 +32,7 @@ void rtw_os_xmit_schedule(struct adapter *padapter);
void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *pxmitbuf, u32 free_sz, u8 flag);
-extern uint rtw_remainder_len(struct pkt_file *pfile);
+extern unsigned int rtw_remainder_len(struct pkt_file *pfile);
extern void _rtw_open_pktfile(struct sk_buff *pkt, struct pkt_file *pfile);
int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, unsigned int rlen);
extern signed int rtw_endofpktfile(struct pkt_file *pfile);
diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
index d5bb1c7932fc..960e82009699 100644
--- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
@@ -7,7 +7,7 @@
#include <drv_types.h>
-uint rtw_remainder_len(struct pkt_file *pfile)
+unsigned int rtw_remainder_len(struct pkt_file *pfile)
{
return (pfile->buf_len - ((SIZE_PTR)(pfile->cur_addr) - (SIZE_PTR)(pfile->buf_start)));
}
--
2.34.1
^ permalink raw reply related
* [PATCH 3/3] staging: rtl8723bs: Replace bare 'uint' with 'unsigned int' in os_intfs.c
From: Moksh Panicker @ 2026-06-22 6:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, skhan, Moksh Panicker
In-Reply-To: <20260622064129.10261-1-mokshpanicker.7@gmail.com>
Replace bare use of 'uint' with 'unsigned int' for the status variable
in rtw_drv_init(). The module_param() uses of 'uint' are intentional
and left unchanged. This fixes the following checkpatch.pl warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54b3e..4434e66bfe63 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -791,7 +791,7 @@ int rtw_drv_register_netdev(struct adapter *if1)
static int _netdev_open(struct net_device *pnetdev)
{
- uint status;
+ unsigned int status;
struct adapter *padapter = rtw_netdev_priv(pnetdev);
struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(padapter);
--
2.34.1
^ permalink raw reply related
* Re: [PATCH] staging: fbtft: fix parenthesis alignment in fb_tinylcd.c
From: Dan Carpenter @ 2026-06-22 9:05 UTC (permalink / raw)
To: Aditya Chari
Cc: andy, gregkh, dri-devel, linux-fbdev, linux-staging, linux-kernel
In-Reply-To: <20260621062945.42519-1-adi25charis@gmail.com>
On Sun, Jun 21, 2026 at 11:59:45AM +0530, Aditya Chari wrote:
> Fix a checkpatch.pl
> CHECK:PARENTHESIS_ALIGNMENT warning by aligning the wrapped
> argument list of write_reg() with the line above it.
>
> Signed-off-by: Aditya Chari <adi25charis@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index afa8f1c74..d58b12472 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
The original is deliberate. Just leave it as-is, please.
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH 3/3] staging: rtl8723bs: use usleep_range instead of msleep for short delays
From: Dan Carpenter @ 2026-06-22 9:07 UTC (permalink / raw)
To: Serhat Kumral; +Cc: gregkh, linux-staging, linux-kernel
In-Reply-To: <20260621104058.7408-3-serhatkumral1@gmail.com>
On Sun, Jun 21, 2026 at 01:40:58PM +0300, Serhat Kumral wrote:
> Replace msleep(10) and msleep(1) with usleep_range(10000, 20000) and
> usleep_range(1000, 2000) respectively in os_intfs.c, because msleep is
> imprecise and discouraged for short delays under 20ms.
> This fixes the checkpatch.pl warnings:
> WARNING: msleep < 20ms can sleep for up to 20ms; see function description of msleep().
>
> Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 89e41c26e..5e41f518a 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -986,7 +986,7 @@ void rtw_dev_unload(struct adapter *padapter)
> if (cnt > 5)
> break;
> cnt++;
> - msleep(10);
> + usleep_range(10000, 20000);
The first two are fine but this isn't. Do a search on lore for
the reasons.
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH] staging: rtl8723bs: avoid duplicate size computation in rtw_spt_band_alloc
From: Dan Carpenter @ 2026-06-22 9:20 UTC (permalink / raw)
To: Serhat Kumral; +Cc: gregkh, linux-staging, linux-kernel
In-Reply-To: <20260621133301.13855-1-serhatkumral1@gmail.com>
On Sun, Jun 21, 2026 at 04:33:01PM +0300, Serhat Kumral wrote:
> Introduce a local variable to store the channel array size and reuse it
> for both the allocation and the bitrates pointer offset, replacing a
> redundant open-coded multiplication with the same array_size() result.
>
> Resolves the Coccinelle warning:
> WARNING: array_size is already used (line 124) to compute the same size
>
> Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 1484336d7..2e65788ee 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -111,7 +111,7 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
> {
> struct ieee80211_supported_band *spt_band = NULL;
> int n_channels, n_bitrates;
> - size_t alloc_sz;
> + size_t alloc_sz, channels_sz;
>
> if (band == NL80211_BAND_2GHZ) {
> n_channels = RTW_2G_CHANNELS_NUM;
> @@ -120,15 +120,16 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
> goto exit;
> }
>
> + channels_sz = array_size(n_channels, sizeof(struct ieee80211_channel));
> alloc_sz = sizeof(*spt_band);
> - alloc_sz = size_add(alloc_sz, array_size(n_channels, sizeof(struct ieee80211_channel)));
> + alloc_sz = size_add(alloc_sz, channels_sz);
> alloc_sz = size_add(alloc_sz, array_size(n_bitrates, sizeof(struct ieee80211_rate)));
> spt_band = kzalloc(alloc_sz, GFP_KERNEL);
This is still a mess. First of all these size values are constant so
the layers of indirection are unnecessary. Pretending they are variable
makes code auditors have to check for integer overflows so it wastes
valuable time and makes the whole kernel less secure.
channels_sz = array_size(RTW_2G_CHANNELS_NUM, sizeof(struct ieee80211_channel));
bitrate_size = array_size(RTW_G_RATES_NUM, sizeof(struct ieee80211_rate));
spt_band = kzalloc(sizeof(*spt_band) + channels_sz + bitrate_size, GFP_KERNEL);
spt_band->channels = (void *)spt_band + sizeof(*spt_band);
spt_band->bitrates = (void *)spt_band + sizeof(*spt_band) + channels_sz;
regards,
dan carpenter
^ permalink raw reply
* [PATCH] staging: rtl8723bs: fix CamelCase warning for bAllow
From: Bruce Ou @ 2026-06-22 9:52 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Bruce Ou
Signed-off-by: Bruce Ou <oubruce1234@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25e..c23cf4216 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -299,12 +299,12 @@ void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)
int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj);
int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
{
- u8 bAllow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
+ u8 allow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
if (cmd_obj->cmdcode == GEN_CMD_CODE(_SetChannelPlan))
- bAllow = true;
+ allow = true;
- if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) ||
+ if ((!pcmdpriv->padapter->hw_init_completed && !allow) ||
!atomic_read(&pcmdpriv->cmdthd_running)) /* com_thread not running */
return _FAIL;
--
2.43.0
^ permalink raw reply related
* Re: [PATCH v1 00/13] iio: Use named initializers for device_id structures
From: Nuno Sá @ 2026-06-22 11:43 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Vladislav Kulikov, Kevin Tung, ChiYuan Huang, linux-iio,
linux-kernel, Oleksij Rempel, kernel, Antoniu Miclaus,
Michael Hennerich, linux, Marcelo Schmitt, Petre Rodan,
Dan Robertson, Rui Miguel Silva, Dragos Bogdan, Dixit Parmar,
chuguangqing, Sebastian Andrzej Siewior, Marcus Folkesson,
Andrew Davis, Puranjay Mohan, Ramona Gradinariu, Esteban Blanc,
Sergiu Cuciurean, Alisa-Dariana Roman, Matti Vaittinen,
Renato Lui Geh, Ramona Bolboaca, Kim Seer Paller,
Marilene Andrade Garcia, Marius Cristea, Kent Gustavsson,
Kurt Borja, Leonard Göhrs, Rodrigo Alencar, Gustavo Silva,
Alexis Czezar Torreno, Janani Sunil, Anshul Dalal,
Ricardo Ribalda, Lorenzo Bianconi, Alex Lanzano, Jagath Jog J,
Jean-Baptiste Maneyrol, Remi Buisson, Herve Codina,
Andreas Klinger, Harshit Mogalapalli, Andrew Ijano,
Giorgi Tchankvetadze, Krzysztof Kozlowski, Md Shofiqul Islam,
Greg Kroah-Hartman, Stepan Ionichev, Sam Daly, Colin Ian King,
David Jander, Dmitry Torokhov, Bartosz Golaszewski, Linus Walleij,
Gabriel Rondon, David Marinovic, Lukas Schmid, Shi Hao,
Rahman Mahmutović, linux-staging
In-Reply-To: <cover.1781883685.git.u.kleine-koenig@baylibre.com>
On Fri, Jun 19, 2026 at 05:54:28PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
>
> the first patch is a follow up for making iio's i2c_device_id arrays use
> named initializers. The two drivers adapted in it were missed before
> because they were not yet in the tree I used to prepare the patch. The
> remainder is a similar adaption for spi_device_id. Instead of adapting
> arrays with a single entry and .driver_data, rework these to not use
> .driver_data.
>
> The ad9523 driver is a bit special here. It can only probe devices that
> have platform data. A device instantiated using dt never has platform
> data, so this driver only works for boards registering the device using
> a spi_board_info struct. There is no such board, and there never was
> one. So an alternative is to just drop this driver?!
>
> I was unsure if I should post the staging patches in a separate series,
> I hope it's fine to include them here.
>
> Best regards
> Uwe
>
Tend to agree with Andy on the squash. Not a big deal to me though.
Hence:
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> Uwe Kleine-König (The Capable Hub) (13):
> iio: Initialize i2c_device_id arrays using member names (part 2)
> iio: adc: ti-tsc2046: Simplify device abstraction
> iio: adc: ti-tsc2046: Drop unused member from private data
> iio: adc: max1241: Simplify device abstraction
> iio: dac: max5522: Simplify device abstraction
> iio: frequency: ad9523: Simplify driver a bit
> iio: imu: adis16550: Simplify device abstraction
> iio: magnetometer: hmc5843: Simplify device abstraction
> iio: accel: bmc150: Explicitly set spi .driver_data
> iio: Drop unused assignment of spi_device_id driver data
> iio: Initialize spi_device_id arrays using member names
> staging: iio: Drop unused assignment of spi_device_id driver data
> staging: iio: Initialize spi_device_id arrays using member names
>
> drivers/iio/accel/adxl345_spi.c | 4 +-
> drivers/iio/accel/adxl355_spi.c | 4 +-
> drivers/iio/accel/adxl367_spi.c | 2 +-
> drivers/iio/accel/adxl372_spi.c | 4 +-
> drivers/iio/accel/adxl380_spi.c | 8 +-
> drivers/iio/accel/bma220_spi.c | 2 +-
> drivers/iio/accel/bma400_spi.c | 2 +-
> drivers/iio/accel/bmc150-accel-spi.c | 18 +--
> drivers/iio/accel/bmi088-accel-spi.c | 6 +-
> drivers/iio/accel/fxls8962af-spi.c | 4 +-
> drivers/iio/accel/kxsd9-spi.c | 2 +-
> drivers/iio/accel/mma7455_spi.c | 4 +-
> drivers/iio/accel/sca3000.c | 8 +-
> drivers/iio/accel/sca3300.c | 4 +-
> drivers/iio/accel/st_accel_spi.c | 40 +++---
> drivers/iio/adc/ad4000.c | 62 ++++-----
> drivers/iio/adc/ad4030.c | 14 +-
> drivers/iio/adc/ad4080.c | 22 +--
> drivers/iio/adc/ad4130.c | 12 +-
> drivers/iio/adc/ad4134.c | 2 +-
> drivers/iio/adc/ad4170-4.c | 6 +-
> drivers/iio/adc/ad4851.c | 18 +--
> drivers/iio/adc/ad7091r8.c | 6 +-
> drivers/iio/adc/ad7124.c | 4 +-
> drivers/iio/adc/ad7173.c | 26 ++--
> drivers/iio/adc/ad7191.c | 2 +-
> drivers/iio/adc/ad7192.c | 10 +-
> drivers/iio/adc/ad7266.c | 4 +-
> drivers/iio/adc/ad7280a.c | 2 +-
> drivers/iio/adc/ad7292.c | 2 +-
> drivers/iio/adc/ad7298.c | 2 +-
> drivers/iio/adc/ad7380.c | 36 ++---
> drivers/iio/adc/ad7476.c | 60 ++++----
> drivers/iio/adc/ad7606_spi.c | 22 +--
> drivers/iio/adc/ad7766.c | 12 +-
> drivers/iio/adc/ad7768-1.c | 8 +-
> drivers/iio/adc/ad7780.c | 8 +-
> drivers/iio/adc/ad7791.c | 10 +-
> drivers/iio/adc/ad7793.c | 18 +--
> drivers/iio/adc/ad7887.c | 2 +-
> drivers/iio/adc/ad7923.c | 14 +-
> drivers/iio/adc/ad7944.c | 6 +-
> drivers/iio/adc/ad7949.c | 6 +-
> drivers/iio/adc/ad9467.c | 14 +-
> drivers/iio/adc/ade9000.c | 2 +-
> drivers/iio/adc/hi8435.c | 2 +-
> drivers/iio/adc/max1027.c | 12 +-
> drivers/iio/adc/max1118.c | 6 +-
> drivers/iio/adc/max11205.c | 4 +-
> drivers/iio/adc/max11410.c | 2 +-
> drivers/iio/adc/max1241.c | 8 +-
> drivers/iio/adc/max14001.c | 4 +-
> drivers/iio/adc/mcp320x.c | 26 ++--
> drivers/iio/adc/mcp3564.c | 24 ++--
> drivers/iio/adc/mcp3911.c | 14 +-
> drivers/iio/adc/rohm-bd79112.c | 2 +-
> drivers/iio/adc/rtq6056.c | 4 +-
> drivers/iio/adc/ti-adc0832.c | 8 +-
> drivers/iio/adc/ti-adc084s021.c | 2 +-
> drivers/iio/adc/ti-adc108s102.c | 2 +-
> drivers/iio/adc/ti-adc12138.c | 6 +-
> drivers/iio/adc/ti-adc128s052.c | 24 ++--
> drivers/iio/adc/ti-adc161s626.c | 4 +-
> drivers/iio/adc/ti-ads1018.c | 4 +-
> drivers/iio/adc/ti-ads124s08.c | 4 +-
> drivers/iio/adc/ti-ads1298.c | 2 +-
> drivers/iio/adc/ti-ads131e08.c | 6 +-
> drivers/iio/adc/ti-ads131m02.c | 10 +-
> drivers/iio/adc/ti-ads7950.c | 24 ++--
> drivers/iio/adc/ti-ads8688.c | 4 +-
> drivers/iio/adc/ti-lmp92064.c | 2 +-
> drivers/iio/adc/ti-tlc4541.c | 4 +-
> drivers/iio/adc/ti-tsc2046.c | 12 +-
> drivers/iio/addac/ad74115.c | 2 +-
> drivers/iio/amplifiers/ad8366.c | 26 ++--
> drivers/iio/amplifiers/ada4250.c | 2 +-
> drivers/iio/chemical/bme680_spi.c | 2 +-
> drivers/iio/chemical/ens160_spi.c | 2 +-
> drivers/iio/dac/ad3530r.c | 8 +-
> drivers/iio/dac/ad5064.c | 32 ++---
> drivers/iio/dac/ad5360.c | 16 +--
> drivers/iio/dac/ad5380.c | 32 ++---
> drivers/iio/dac/ad5446-spi.c | 62 ++++-----
> drivers/iio/dac/ad5449.c | 14 +-
> drivers/iio/dac/ad5504.c | 4 +-
> drivers/iio/dac/ad5624r_spi.c | 12 +-
> drivers/iio/dac/ad5706r.c | 2 +-
> drivers/iio/dac/ad5755.c | 10 +-
> drivers/iio/dac/ad5758.c | 2 +-
> drivers/iio/dac/ad5761.c | 8 +-
> drivers/iio/dac/ad5764.c | 8 +-
> drivers/iio/dac/ad5766.c | 4 +-
> drivers/iio/dac/ad5770r.c | 2 +-
> drivers/iio/dac/ad5791.c | 10 +-
> drivers/iio/dac/ad7293.c | 2 +-
> drivers/iio/dac/ad7303.c | 2 +-
> drivers/iio/dac/ad8801.c | 4 +-
> drivers/iio/dac/ad9739a.c | 2 +-
> drivers/iio/dac/ltc1660.c | 4 +-
> drivers/iio/dac/ltc2632.c | 44 +++---
> drivers/iio/dac/ltc2664.c | 4 +-
> drivers/iio/dac/ltc2688.c | 2 +-
> drivers/iio/dac/max22007.c | 2 +-
> drivers/iio/dac/max5522.c | 31 +----
> drivers/iio/dac/mcp4821.c | 12 +-
> drivers/iio/dac/mcp4922.c | 8 +-
> drivers/iio/dac/rohm-bd79703.c | 8 +-
> drivers/iio/dac/ti-dac082s085.c | 12 +-
> drivers/iio/dac/ti-dac7311.c | 6 +-
> drivers/iio/dac/ti-dac7612.c | 2 +-
> drivers/iio/filter/admv8818.c | 2 +-
> drivers/iio/frequency/ad9523.c | 3 +-
> drivers/iio/frequency/adf4350.c | 4 +-
> drivers/iio/frequency/adf4371.c | 4 +-
> drivers/iio/frequency/adf4377.c | 4 +-
> drivers/iio/frequency/admv1013.c | 2 +-
> drivers/iio/frequency/admv1014.c | 2 +-
> drivers/iio/frequency/adrf6780.c | 2 +-
> drivers/iio/gyro/adis16080.c | 4 +-
> drivers/iio/gyro/adis16136.c | 8 +-
> drivers/iio/gyro/adis16260.c | 12 +-
> drivers/iio/gyro/adxrs450.c | 4 +-
> drivers/iio/gyro/bmg160_spi.c | 7 +-
> drivers/iio/gyro/fxas21002c_spi.c | 2 +-
> drivers/iio/gyro/st_gyro_spi.c | 18 +--
> drivers/iio/health/afe4403.c | 2 +-
> drivers/iio/humidity/hts221_spi.c | 2 +-
> drivers/iio/imu/adis16400.c | 30 ++--
> drivers/iio/imu/adis16460.c | 2 +-
> drivers/iio/imu/adis16475.c | 54 ++++----
> drivers/iio/imu/adis16480.c | 40 +++---
> drivers/iio/imu/adis16550.c | 9 +-
> drivers/iio/imu/bmi160/bmi160_spi.c | 4 +-
> drivers/iio/imu/bmi270/bmi270_spi.c | 4 +-
> drivers/iio/imu/bmi323/bmi323_spi.c | 2 +-
> drivers/iio/imu/fxos8700_spi.c | 2 +-
> .../iio/imu/inv_icm42600/inv_icm42600_spi.c | 14 +-
> .../iio/imu/inv_icm45600/inv_icm45600_spi.c | 16 +--
> drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 34 ++---
> drivers/iio/imu/smi240.c | 2 +-
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c | 48 +++----
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 4 +-
> drivers/iio/light/st_uvis25_spi.c | 2 +-
> drivers/iio/magnetometer/bmc150_magn_spi.c | 6 +-
> drivers/iio/magnetometer/hmc5843_spi.c | 6 +-
> drivers/iio/magnetometer/mmc5983.c | 2 +-
> drivers/iio/magnetometer/st_magn_spi.c | 12 +-
> drivers/iio/potentiometer/max5481.c | 8 +-
> drivers/iio/potentiometer/max5487.c | 6 +-
> drivers/iio/potentiometer/mcp41010.c | 12 +-
> drivers/iio/potentiometer/mcp4131.c | 128 +++++++++---------
> drivers/iio/potentiometer/x9250.c | 4 +-
> drivers/iio/pressure/abp2030pa_spi.c | 2 +-
> drivers/iio/pressure/bmp280-spi.c | 14 +-
> drivers/iio/pressure/hsc030pa_spi.c | 2 +-
> drivers/iio/pressure/mpl115_spi.c | 2 +-
> drivers/iio/pressure/mprls0025pa_spi.c | 2 +-
> drivers/iio/pressure/ms5611_spi.c | 4 +-
> drivers/iio/pressure/st_pressure_spi.c | 24 ++--
> drivers/iio/pressure/zpa2326_spi.c | 2 +-
> drivers/iio/proximity/as3935.c | 2 +-
> drivers/iio/resolver/ad2s1200.c | 4 +-
> drivers/iio/resolver/ad2s1210.c | 2 +-
> drivers/iio/resolver/ad2s90.c | 2 +-
> drivers/iio/temperature/ltc2983.c | 10 +-
> drivers/iio/temperature/max31856.c | 2 +-
> drivers/iio/temperature/max31865.c | 2 +-
> drivers/iio/temperature/maxim_thermocouple.c | 18 +--
> drivers/staging/iio/adc/ad7816.c | 6 +-
> drivers/staging/iio/addac/adt7316-spi.c | 13 +-
> drivers/staging/iio/frequency/ad9832.c | 4 +-
> drivers/staging/iio/frequency/ad9834.c | 8 +-
> 172 files changed, 886 insertions(+), 927 deletions(-)
>
>
> base-commit: 3ce97bd3c4f18608335e709c24d6a40e7036cab8
> --
> 2.47.3
>
^ permalink raw reply
* [PATCH] staging: rtl8723bs: hal: remove unnecessary braces
From: Xiaofeng Yuan @ 2026-06-22 13:17 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Xiaofeng Yuan
checkpatch reports two warnings about unnecessary braces in hal_intf.c:
- WARNING: braces {} are not necessary for any arm of this
statement (rtw_hal_update_ra_mask)
- WARNING: braces {} are not necessary for single statement
blocks (rtw_hal_dm_watchdog_in_lps)
Both blocks contain only single statements, so the braces are
redundant. Remove them to align with kernel coding style.
Compile tested with CONFIG_RTL8723BS=m.
Signed-off-by: Xiaofeng Yuan <xiaofengmian@163.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 27c0c0198..45634b5e5 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -208,9 +208,8 @@ void rtw_hal_update_ra_mask(struct sta_info *psta, u8 rssi_level)
if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
add_ratid(padapter, psta, rssi_level);
- else {
+ else
UpdateHalRAMask8723B(padapter, psta->mac_id, rssi_level);
- }
}
void rtw_hal_add_ra_tid(struct adapter *padapter, u32 bitmap, u8 *arg, u8 rssi_level)
@@ -254,9 +253,8 @@ void rtw_hal_dm_watchdog(struct adapter *padapter)
void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
{
- if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) {
+ if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode)
rtl8723b_HalDmWatchDog_in_LPS(padapter); /* this function caller is in interrupt context */
- }
}
void beacon_timing_control(struct adapter *padapter)
--
2.43.0
^ permalink raw reply related
* [GIT PULL] Staging driver changes for 7.2-rc1
From: Greg KH @ 2026-06-22 13:41 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel, linux-staging
The following changes since commit 5d6919055dec134de3c40167a490f33c74c12581:
Linux 7.1-rc3 (2026-05-10 14:08:09 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-7.2-rc1
for you to fetch changes up to 7cb1c5b32a2bfde961fff8d5204526b609bcb30a:
staging: most: video: avoid double free on video register failure (2026-05-21 12:42:38 +0200)
----------------------------------------------------------------
Staging driver updates for 7.2-rc1
Here is the big set of staging driver updates for 7.2-rc1.
Nothing major in here, just constant grind of tiny cleanups and coding
style fixes and wrapper removals. Overall more code was removed than
added, always a nice sign that things are progressing forward.
Changes outside of drivers/staging/ was due to the octeon driver
changes, which for some reason also lives partially in the mips
subsystem, someday that all will be untangled and cleaned up, or just
removed entirely, it's hard to tell which is going to be its fate.
Other than octeon driver cleanups, in here are the usual:
- rtl8723bs driver reworking and cleanups, being the bulk of this
merge window given all of the issues and wrappers involved in that
beast of a driver.
- most driver cleanups
- sm750fb driver cleanups (which might be done, as this really should
be moved to the drm layer one of these days...)
- other tiny staging driver cleanups and fixes
All of these have been in linux-next for many weeks with no reported
issues.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----------------------------------------------------------------
Aadarsh Mandal (1):
staging: rtl8723bs: remove commented-out code
Abhai Kollara (1):
staging: rtl8723bs: simplify NULL pointer comparisons in rtw_recv.h
Ahmet Sezgin Duran (8):
staging: sm750fb: fix off-by-one in lynxfb_ops_setcolreg
staging: sm750fb: remove double space in fb_ops entries
staging: sm750fb: remove unnecessary initializations
staging: sm750fb: remove unnecessary initializations
staging: sm750fb: remove unused includes
staging: sm750fb: use early returns in frequency checks
staging: sm750fb: remove unnecessary initialization
staging: sm750fb: remove double space in assignment
Aidan Russell (2):
staging: rtl8723bs: Fix spelling mistakes in comments
staging: rtl8723bs: Replace uint with unsigned int in core
Alexandru Hossu (2):
staging: nvec: fix use-after-free in nvec_rx_completed()
staging: nvec: fix unconditional pm_power_off teardown
Andrei Khomenkov (19):
staging: rtl8723bs: core: simplify boolean comparisons
staging: rtl8723bs: hal: simplify boolean comparisons
staging: rtl8723bs: os_dep: simplify boolean comparisons
staging: rtl8723bs: add spaces around bitwise OR operators
staging: rtl8723bs: remove redundant braces for single-statement block
staging: rtl8723bs: move logical operators to previous line
staging: rtl8723bs: fix alignment of continued conditions
staging: rtl8723bs: wrap lines exceeding 100 characters
staging: rtl8723bs: remove unused DBG_FIXED_CHAN code
staging: rtl8723bs: remove unused DBG_RX_DUMP_EAP code
staging: rtl8723bs: remove unused CONSISTENT_PN_ORDER code
staging: rtl8723bs: remove unused DBG_CH_SWITCH code
staging: rtl8723bs: remove unused REMOVE_PACK code
staging: rtl8723bs: remove unused RTW_DVOBJ_CHIP_HW_TYPE code
staging: rtl8723bs: remove unused RTW_MLME_EXT_C_ code
staging: rtl8723bs: remove commented out code in rtw_mlme_ext.c
staging: rtl8723bs: simplify if-else blocks in rtw_mlme_ext.c
staging: rtl8723bs: remove unused DBG_XMIT_BUF and DBG_XMIT_BUF_EXT code
staging: rtl8723bs: remove unused TXDESC_64_BYTES code
Ayush Mukkanwar (3):
staging: octeon: ethernet-mem: replace pr_warn with dev_warn in free functions
staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err
staging: octeon: replace pr_warn with dev_warn in fill and rx paths
Ayushman Rout (2):
staging: rtl8723bs: fix line lengths in rtw_cmd.c
staging: rtl8723bs: fix CamelCase of DelayLPSLastTimeStamp
Bera Yüzlü (1):
staging: rtl8723bs: remove unused function pointers
Eric Wu (7):
staging: octeon: convert cvmx_spi_mode_t from typedef to plain enum
staging: octeon: convert cvmx_helper_interface_mode_t from typedef to plain enum
staging: octeon: convert cvmx_pow_wait_t from typedef to plain enum
staging: octeon: convert cvmx_pko_lock_t from typedef to plain enum
staging: octeon: convert cvmx_pko_status_t from typedef to plain enum
staging: octeon: convert cvmx_pko_port_status_t from typedef to plain struct
staging: octeon: convert cvmx_pip_port_status_t from typedef to plain struct
Ethan Tidmore (2):
staging: rtl8723bs: Remove dead code
staging: rtl8723bs: Rename pHT_info_ie to ht_info_ie
Francisco Maestre (1):
staging: rtl8723bs: fix block comment alignment in hal_pwr_seq.c
Gabriel Rondon (3):
staging: most: dim2: remove unnecessary NULL check in service_done_flag()
staging: most: dim2: remove unnecessary NULL check in try_start_dim_transfer()
staging: most: video: remove redundant cleanup in comp_exit()
Greg Kroah-Hartman (1):
Merge tag 'v7.1-rc3' into staging-next
Guangshuo Li (1):
staging: most: video: avoid double free on video register failure
Hadi Chokr (1):
staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep()
Henrique Cazarim (1):
staging: rtl8723bs: add spaces arround |
Hungyu Lin (23):
staging: sm750fb: constify fix_id array
staging: rtl8723bs: remove unnecessary parentheses in os_intfs.c
staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow
staging: rtl8723bs: make rtw_alloc_hwxmits static
staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno
staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c
staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno
staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno
staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c
staging: rtl8723bs: remove redundant return in report_join_res()
staging: sm750fb: return -ETIMEDOUT on timeout in de_wait functions
staging: sm750fb: propagate error codes from de_wait()
staging: sm750fb: fix typo in comment
staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched
staging: rtl8723bs: simplify _rtw_enqueue_cmd control flow
staging: rtl8723bs: make _rtw_enqueue_cmd static
staging: rtl8723bs: simplify rtw_enqueue_cmd control flow
staging: rtl8723bs: make _rtw_enqueue_cmd return 0 on success
staging: rtl8723bs: simplify rtw_xmit_classifier control flow
staging: rtl8723bs: make rtw_xmit_classifier static
staging: rtl8723bs: convert rtw_xmit_classifier to return errno
staging: rtl8723bs: propagate errno through xmit enqueue path
staging: rtl8723bs: propagate errno through hal xmit path
Jennifer Guo (17):
staging: sm750fb: rename CamelCase variable and drop prefix
staging: sm750fb: change 2 CamelCase variables to snake_case
staging: rtl8723bs: remove unnecessary block comment
staging: rtl8723bs: remove commented out enum values from odm_types.h
staging: rtl8723bs: fix block comment alignment in hal/ header files
staging: rtl8723bs: fix block comment alignment in hal/ source files
staging: rtl8723bs: move block comment terminator to new line
staging: rtl8723bs: remove commented out code from odm.c
staging: rtl8723bs: remove unnecessary blank lines in rtw_recv.c
staging: rtl8723bs: remove unnecessary blank lines in rtw_mlme_ext.c
staging: rtl8723bs: remove unnecessary blank lines in rtw_security.c
staging: rtl8723bs: fix unbalanced braces in rtw_recv.c
staging: rtl8723bs: fix unbalanced braces in 3 files
staging: rtl8723bs: fix multiple blank lines in hal/ files
staging: rtl8723bs: fix multiple blank lines in hal/Hal* files
staging: rtl8723bs: fix multiple blank lines in more hal/ files
staging: rtl8723bs: delete superfluous switch statement
Jinemon Tama (4):
staging: rtl8723bs: fix spacing around operators in rtl8723b_phycfg.c
staging: rtl8723bs: remove space after type cast
staging: rtl8723bs: wrap long lines in rtl8723b_phycfg.c
staging: rtl8723bs: remove unnecessary blank lines in rtl8723b_phycfg.c
Josh Hesketh (2):
staging: rtl8723bs: fix whitespace issues in sdio_halinit.c
staging: rtl8723bs: remove unnecessary else after return in sdio_halinit.c
Kenet Jovan Sokoli (2):
staging: sm750fb: remove unused functions
staging: rtl8723bs: remove unused struct rtw_regulatory
Kosugi Souta (1):
staging: greybus: fix alignment to match open parenthesis
Len Bao (1):
staging: sm750fb: Mark g_noaccel, g_nomtrr and g_dualview as __ro_after_init
Linus Probert (16):
staging: rtl8723bs: remove multiple blank lines in rtw_btcoex.c
staging: rtl8723bs: rename global function Efuse_CalculateWordCnts
staging: rtl8723bs: efuse_OneByteRead() -> rtw_efuse_one_byte_read()
staging: rtl8723bs: rename EFUSE_Read1Byte() to rtw_efuse_read_1_byte()
staging: rtl8723bs: EFUSE_ShadowMapUpdate -> rtw_efuse_shadow_map_update
staging: rtl8723bs: rename EFUSE_ShadowRead() to rtw_efuse_shadow_read()
staging: rtl8723bs: remove two unused function prototypes
staging: rtl8723bs: remove space before tab
staging: rtl8723bs: remove blank line in rtw_btcoex.h
staging: rtl8723bs: add function definition arg names to rtw_btcoex.h
staging: rtl8723bs: rename rtw_btcoex_MediaStatusNotify()
staging: rtl8723bs: rename rtw_btcoex_media_status_notify definition arg
staging: rtl8723bs: rtw_btcoex_HaltNotify() -> rtw_btcoex_halt_notify()
staging: rtl8723bs: rename rtw_btcoex_RejectApAggregatedPacket()
staging: rtl8723bs: rtw_btcoex_LPS_Enter() -> rtw_btcoex_lps_enter()
staging: rtl8723bs: rename rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave
Luka Gejak (1):
staging: rtl8723bs: clean up memcpy() in rtw_check_bcn_info
Maha Maryam Javaid (3):
staging: greybus: fix typo in sysfs-bus-greybus
staging: rtl8723bs: fix typo in rtw_pwrctrl.c
staging: most: net: replace pr_err with netdev_err
Mahad Ibrahim (1):
staging: fbtft: Use %pe format specifier for error pointers
Maksym Pikhotskyi (2):
staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt
staging: rtl8723bs: reduce nesting in rtw_security.c
Michael Steinmötzger (2):
staging: rtl8723bs: replace non-standard BITn macros with BIT(n)
staging: rtl8723bs: fix type issue in DYNAMIC_BB_DYNAMIC_TXPWR
Michael Straube (1):
staging: rtl8723bs: remove READ_AND_CONFIG_MP macro
Miguel Cyrineu Vale (1):
staging: rtl8723bs: replace NULL comparison with NOT operator
Mohammed Rizwan Kaniyate (1):
staging: rtl8723bs: remove multiple blank lines in core/
Moksh Panicker (3):
staging: rtl8723bs: Remove unnecessary braces in rtl8723bs_xmit.c
staging: rtl8723bs: Remove commented-out dead code in hal_btcoex.c
staging: rtl8723bs: remove blank line after open brace in hal_com.c
Nikolay Kulikov (34):
staging: rtl8723bs: remove dead code in rtw_io.c
staging: rtl8723bs: replace tabs used as separators with spaces
staging: rtl8723bs: remove unnecessary rtw_bug_check() function
staging: rtl8723bs: remove unused _rtw_init_queue() function header
staging: rtl8723bs: remove the header of non-existent _kfree() function
staging: rtl8723bs: remove unused rtw_sprintf() macro
staging: rtl8723bs: remove the rtw_warn_on() macro
staging: rtl8723bs: remove unused BIT33..BIT36 macros
staging: rtl8723bs: remove dump_chip_info() function
staging: rtl8723bs: remove wrapper rtw_hal_chip_configure()
staging: rtl8723bs: remove wrapper rtw_hal_read_chip_info()
staging: rtl8723bs: remove wrapper rtw_hal_read_chip_version()
staging: rtl8723bs: remove wrapper rtw_hal_def_value_init()
staging: rtl8723bs: remove wrapper rtw_hal_free_data()
staging: rtl8723bs: remove wrapper rtw_hal_dm_init()
staging: rtl8723bs: remove wrapper rtw_hal_enable_interrupt()
staging: rtl8723bs: rename ReadAdapterInfo8723BS() to snake_case
staging: rtl8723bs: rename EnableInterrupt8723BSdio() to snake_case
staging: rtl8723bs: remove wrapper rtw_hal_disable_interrupt()
staging: rtl8723bs: rename DisableInterrupt8723BSdio() to snake_case
staging: rtl8723bs: rename ChipType of struct hal_version to snake_case
staging: rtl8723bs: replace type and rename the chip_type field
staging: rtl8723bs: remove unused macros from include/HalVerDef.h
staging: rtl8723bs: remove unused ICType from struct hal_version
staging: rtl8723bs: remove unused VendorType from struct hal_version
staging: rtl8723bs: remove unused CUTVersion from struct hal_version
staging: rtl8723bs: remove unused ROMVer from struct hal_version
staging: rtl8723bs: move normal_chip field to struct hal_com_data
staging: rtl8723bs: remove struct hal_version from include/HalVerDef.h
staging: rtl8723bs: remove include/HalVerDef.h file
staging: rtl8723bs: remove unused SysIntrMask from struct hal_com_data
staging: rtl8723bs: remove empty InitSysInterrupt8723BSdio()
staging: rtl8723bs: remove overwriting of current IMR settings
staging: rtl8723bs: remove unused SysIntrStatus from struct hal_com_data
Paarth Mahadik (1):
staging: rtl8723bs: fix logical continuation style
Pramod Maurya (5):
staging: rtl8723bs: Replace __attribute__((packed)) with __packed in wifi.h
staging: rtl8723bs: Replace __attribute__((__packed__)) with __packed in rtl8723b_hal.h
staging: rtl8723bs: Remove multiple blank lines in include headers
staging: rtl8723bs: Replace __attribute__((packed)) with __packed in ieee80211.h
staging: rtl8723bs: Fix block comment style in ieee80211.h
Prithvi Tambewagh (5):
staging: rtl8723bs: move constant to right side of test in comparison
staging: rtl8723bs: remove empty if statement block
staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()
staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down
staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase()
Robertus Diawan Chris (1):
staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()
Rupesh Majhi (1):
staging: sm750: rename CamelCase variable Bpp to bpp
Salman Alghamdi (2):
staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition
staging: rtl8723bs: rtw_mlme: add blank line for readability
Shivam Gupta (1):
staging: rtl8723bs: remove unnecessary braces
Shubham Chakraborty (1):
staging: sm750fb: Rename sm750_pnltype enum values to upper case
Shyam Sunder Reddy Padira (7):
staging: most: net: remove filename from top-of-file comment
staging: rtl8723bs: os_dep: remove unnecessary braces for single statement
staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload
staging: most: video: remove filename from the top-of-file comment
staging: most: dim2: remove filename from comment blocks
staging: vme_user: remove unnecessary NULL initialization before list iteration
staging: vme_user: simplify boolean comparisons
Siwanan Bungtong (2):
staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c
staging: rtl8723bs: fix unbalanced braces in if/else statements
Stepan Ionichev (2):
staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
staging: rtl8723bs: drop blank line before close brace in rtw_ieee80211.c
Xiyuan Guo (1):
staging: rtl8723bs: fix include guard comment in rtw_cmd.h
.../cavium-octeon/executive/cvmx-helper-util.c | 2 +-
arch/mips/cavium-octeon/executive/cvmx-helper.c | 8 +-
arch/mips/cavium-octeon/executive/cvmx-pko.c | 6 +-
arch/mips/cavium-octeon/executive/cvmx-spi.c | 16 +-
arch/mips/include/asm/octeon/cvmx-helper-util.h | 2 +-
arch/mips/include/asm/octeon/cvmx-helper.h | 6 +-
arch/mips/include/asm/octeon/cvmx-pip.h | 6 +-
arch/mips/include/asm/octeon/cvmx-pko.h | 26 +-
arch/mips/include/asm/octeon/cvmx-pow.h | 12 +-
arch/mips/include/asm/octeon/cvmx-spi.h | 38 +--
drivers/staging/fbtft/fb_ssd1351.c | 3 +-
drivers/staging/fbtft/fbtft-core.c | 3 +-
drivers/staging/fbtft/fbtft-io.c | 7 -
drivers/staging/fbtft/fbtft.h | 1 -
.../greybus/Documentation/firmware/authenticate.c | 2 +-
.../greybus/Documentation/sysfs-bus-greybus | 2 +-
drivers/staging/most/dim2/dim2.c | 6 +-
drivers/staging/most/dim2/errors.h | 2 +-
drivers/staging/most/dim2/hal.c | 2 +-
drivers/staging/most/dim2/hal.h | 2 +-
drivers/staging/most/dim2/reg.h | 2 +-
drivers/staging/most/dim2/sysfs.h | 2 +-
drivers/staging/most/net/net.c | 18 +-
drivers/staging/most/video/video.c | 30 +--
drivers/staging/nvec/nvec.c | 8 +-
drivers/staging/octeon/ethernet-mem.c | 43 ++--
drivers/staging/octeon/ethernet-mem.h | 8 +-
drivers/staging/octeon/ethernet-rx.c | 49 ++--
drivers/staging/octeon/ethernet-rx.h | 13 +-
drivers/staging/octeon/ethernet.c | 69 ++---
drivers/staging/octeon/octeon-ethernet.h | 14 ++
drivers/staging/octeon/octeon-stubs.h | 48 ++--
drivers/staging/rtl8723bs/core/rtw_ap.c | 90 +------
drivers/staging/rtl8723bs/core/rtw_btcoex.c | 15 +-
drivers/staging/rtl8723bs/core/rtw_cmd.c | 48 ++--
drivers/staging/rtl8723bs/core/rtw_efuse.c | 29 ++-
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 3 +-
drivers/staging/rtl8723bs/core/rtw_io.c | 20 +-
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 58 ++---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 68 +++--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 172 ++-----------
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 +-
drivers/staging/rtl8723bs/core/rtw_recv.c | 186 +++++---------
drivers/staging/rtl8723bs/core/rtw_security.c | 223 ++++++++---------
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 +-
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 57 ++---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 277 ++++++++++-----------
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 105 +++-----
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 18 +-
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 32 +--
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h | 16 +-
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 10 +-
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 30 +--
drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 24 +-
drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.h | 13 +-
drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 25 +-
drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.h | 21 +-
drivers/staging/rtl8723bs/hal/HalPhyRf.c | 1 -
drivers/staging/rtl8723bs/hal/HalPhyRf.h | 1 -
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 59 ++---
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h | 2 -
drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 1 -
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 52 +---
drivers/staging/rtl8723bs/hal/hal_com.c | 86 ++-----
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 22 +-
drivers/staging/rtl8723bs/hal/hal_intf.c | 53 +---
drivers/staging/rtl8723bs/hal/hal_pwr_seq.c | 18 +-
drivers/staging/rtl8723bs/hal/hal_sdio.c | 1 -
drivers/staging/rtl8723bs/hal/odm.c | 82 ++----
drivers/staging/rtl8723bs/hal/odm.h | 56 ++---
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
drivers/staging/rtl8723bs/hal/odm_DIG.c | 64 ++---
drivers/staging/rtl8723bs/hal/odm_DIG.h | 4 +-
.../rtl8723bs/hal/odm_DynamicBBPowerSaving.c | 12 +-
drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 22 +-
drivers/staging/rtl8723bs/hal/odm_HWConfig.h | 1 -
drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.c | 1 -
drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h | 6 +-
drivers/staging/rtl8723bs/hal/odm_interface.h | 11 -
drivers/staging/rtl8723bs/hal/odm_types.h | 7 -
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 38 ++-
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 19 +-
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 124 ++++-----
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 67 ++---
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 +-
drivers/staging/rtl8723bs/hal/rtl8723b_rxdesc.c | 1 -
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +-
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 29 +--
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 96 ++-----
drivers/staging/rtl8723bs/hal/sdio_ops.c | 174 ++-----------
drivers/staging/rtl8723bs/include/HalVerDef.h | 85 -------
drivers/staging/rtl8723bs/include/cmd_osdep.h | 2 -
drivers/staging/rtl8723bs/include/drv_types.h | 9 +-
drivers/staging/rtl8723bs/include/hal_com.h | 3 -
drivers/staging/rtl8723bs/include/hal_com_reg.h | 104 ++++----
drivers/staging/rtl8723bs/include/hal_data.h | 8 +-
drivers/staging/rtl8723bs/include/hal_intf.h | 31 +--
drivers/staging/rtl8723bs/include/hal_phy.h | 4 +-
drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 182 +++++++-------
drivers/staging/rtl8723bs/include/ieee80211.h | 54 ++--
drivers/staging/rtl8723bs/include/osdep_service.h | 56 -----
drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 -
drivers/staging/rtl8723bs/include/rtl8723b_dm.h | 1 -
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 3 +-
drivers/staging/rtl8723bs/include/rtl8723b_recv.h | 2 +-
drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 88 +++----
drivers/staging/rtl8723bs/include/rtw_btcoex.h | 11 +-
drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 +-
drivers/staging/rtl8723bs/include/rtw_efuse.h | 14 +-
drivers/staging/rtl8723bs/include/rtw_ht.h | 16 +-
drivers/staging/rtl8723bs/include/rtw_io.h | 16 --
drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 1 -
drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 17 +-
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +-
drivers/staging/rtl8723bs/include/rtw_recv.h | 8 +-
drivers/staging/rtl8723bs/include/rtw_wifi_regd.h | 1 -
drivers/staging/rtl8723bs/include/rtw_xmit.h | 25 +-
drivers/staging/rtl8723bs/include/sdio_ops.h | 5 +-
drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 -
drivers/staging/rtl8723bs/include/wifi.h | 28 +--
drivers/staging/rtl8723bs/include/xmit_osdep.h | 1 -
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 63 ++---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 27 +-
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 20 +-
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 4 +-
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 18 +-
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 15 +-
drivers/staging/sm750fb/ddk750_chip.c | 145 +++++------
drivers/staging/sm750fb/ddk750_power.c | 17 --
drivers/staging/sm750fb/ddk750_power.h | 5 -
drivers/staging/sm750fb/sm750.c | 60 ++---
drivers/staging/sm750fb/sm750.h | 12 +-
drivers/staging/sm750fb/sm750_accel.c | 62 ++---
drivers/staging/sm750fb/sm750_accel.h | 6 +-
drivers/staging/sm750fb/sm750_cursor.c | 58 -----
drivers/staging/sm750fb/sm750_cursor.h | 2 -
drivers/staging/sm750fb/sm750_hw.c | 38 +--
drivers/staging/vme_user/vme.c | 24 +-
139 files changed, 1622 insertions(+), 2879 deletions(-)
delete mode 100644 drivers/staging/rtl8723bs/include/HalVerDef.h
^ permalink raw reply
* [PATCH] staging: media: atomisp: sh_css_mmu: use %s/__func__ in debug trace
From: Batu Ada Tutkun @ 2026-06-22 14:50 UTC (permalink / raw)
To: hansg, gregkh; +Cc: linux-staging, linux-media, Batu Ada Tutkun
Replace hardcoded function name strings in ia_css_debug_dtrace() calls
with the '%s', __func__ pattern, as preferred by the kernel coding style.
Signed-off-by: Batu Ada Tutkun <batuadatutkun@gmail.com>
---
drivers/staging/media/atomisp/pci/sh_css_mmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_mmu.c b/drivers/staging/media/atomisp/pci/sh_css_mmu.c
index f2a84c1d6..bcc973b22 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_mmu.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_mmu.c
@@ -19,7 +19,7 @@ ia_css_mmu_invalidate_cache(void)
unsigned int HIVE_ADDR_ia_css_dmaproxy_sp_invalidate_tlb;
ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE,
- "ia_css_mmu_invalidate_cache() enter\n");
+ "%s() enter\n", __func__);
/* if the SP is not running we should not access its dmem */
if (sh_css_sp_is_running()) {
@@ -32,7 +32,7 @@ ia_css_mmu_invalidate_cache(void)
true);
}
ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE,
- "ia_css_mmu_invalidate_cache() leave\n");
+ "%s() leave\n", __func__);
}
void
--
2.53.0
^ permalink raw reply related
* [PATCH] staging: atomisp: anr: move trailing statement to its own line
From: Mani Bharadwaj @ 2026-06-22 15:02 UTC (permalink / raw)
To: hansg, mchehab, sakari.ailus, andy, gregkh
Cc: linux-media, linux-kernel, linux-staging, Mani Bharadwaj
Move the return statement in ia_css_anr_dump() to its own line
to fix the following checkpatch error:
ERROR: trailing statements should be on next line
No functional change.
Signed-off-by: Mani Bharadwaj <manibharadwajcr@gmail.com>
---
.../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 899d56623..fd50a20ac 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -36,7 +36,8 @@ ia_css_anr_dump(
const struct sh_css_isp_anr_params *anr,
unsigned int level)
{
- if (!anr) return;
+ if (!anr)
+ return;
ia_css_debug_dtrace(level, "Advance Noise Reduction:\n");
ia_css_debug_dtrace(level, "\t%-32s = %d\n",
"anr_threshold", anr->threshold);
--
2.50.1 (Apple Git-155)
^ permalink raw reply related
* [PATCH v2] staging: atomisp: anr: move trailing statement to its own line
From: Mani Bharadwaj @ 2026-06-22 15:05 UTC (permalink / raw)
To: hansg, mchehab, sakari.ailus, andy, gregkh
Cc: linux-media, linux-kernel, linux-staging, Mani Bharadwaj
Move the return statement in ia_css_anr_dump() to its own line
to fix the following checkpatch error:
ERROR: trailing statements should be on next line
No functional change.
Changes in v2:
- Resend with proper formatting via git-send-email.
The earlier submission had formatting issues due to a
misconfigured mail client.
Signed-off-by: Mani Bharadwaj <manibharadwajcr@gmail.com>
---
.../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 899d56623..fd50a20ac 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -36,7 +36,8 @@ ia_css_anr_dump(
const struct sh_css_isp_anr_params *anr,
unsigned int level)
{
- if (!anr) return;
+ if (!anr)
+ return;
ia_css_debug_dtrace(level, "Advance Noise Reduction:\n");
ia_css_debug_dtrace(level, "\t%-32s = %d\n",
"anr_threshold", anr->threshold);
--
2.54.0
^ permalink raw reply related
* [PATCH v2 0/4] drm/ssd130x: Add support for the Solomon SSD1351 OLED controller
From: Amit Barzilai @ 2026-06-22 15:25 UTC (permalink / raw)
To: javierm, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
robh, krzk+dt, conor+dt, andy, gregkh, deller
Cc: azuddinadam, chintanlike, dri-devel, devicetree, linux-kernel,
linux-fbdev, linux-staging, Amit Barzilai
This series adds support for the Solomon SSD1351, a 128x128 65k-color
RGB OLED controller, to the ssd130x DRM driver, and removes the legacy
fbtft fb_ssd1351 driver it supersedes.
v1 [1] was a self-contained ssd1351.c driver. Following Javier's review,
the SSD1351 is instead folded into ssd130x as a new color family, which
also brings 65k color to the existing SSD1331. The work is split as:
- Patch 1 adds the device tree binding. It was previously posted
standalone as a v2 [2]; it is folded into this series here, as Conor
asked, so the binding lands together with the driver and the fbtft
removal.
- Patch 2 changes the SSD133X family to drive RGB565 instead of
RGB332, via a per-variant flag in deviceinfo. The SSD1331 is the
only current member and gains 65k color from this.
- Patch 3 adds the SSD1351 as a new SSD135X_FAMILY, reusing the
SSD133X plane/CRTC and blit/clear helpers. The only data-path
difference is the explicit Write RAM command (0x5c) the SSD1351
needs before pixel data; it also gets its own init sequence and a
longer post-reset settle delay.
- Patch 4 removes the now-redundant staging fbtft fb_ssd1351 driver.
Testing:
- The SSD1351 (patches 1 and 3) is tested on hardware.
- The SSD1331 RGB565 change (patch 2) is compile-tested only; I do not
currently have a working SSD1331 panel. Javier has kindly offered to
test it on his SSD1331.
Dependency:
The SSD1351 reuses ssd133x_update_rect(), which programs the column
and row *end* address as a relative offset rather than an absolute
coordinate. This breaks partial updates that do not start at (0,0). A
separate fix is posted at [3]; until it lands, the SSD1351 shows the
same partial-redraw artifacts. This series applies independently of
that fix, but the two are best merged together.
Based on drm-misc-next.
[1] standalone v1 driver:
https://lore.kernel.org/dri-devel/20260615181253.97551-1-amit.barzilai22@gmail.com
[2] standalone v2 binding:
https://lore.kernel.org/dri-devel/20260615175620.88828-1-amit.barzilai22@gmail.com
[3] ssd132x/ssd133x update_rect end-address fix:
https://lore.kernel.org/dri-devel/20260622122604.32500-1-amit.barzilai22@gmail.com
---
Changes since v1:
- Fold the SSD1351 into ssd130x as a new SSD135X family instead of a
standalone ssd1351.c driver (per Javier).
- Add RGB565 to the SSD133X family, so the SSD1331 also gains 65k color.
- Drop native 256k color (no matching DRM fourcc) and the 0/180
rotation support, to keep the series focused; both can return later.
- Binding: drop solomon,width / solomon,height (deducible from the
compatible) and the rotation property (no consumer), per Krzysztof;
use dt-bindings/gpio/gpio.h flag defines in the example.
- Remove the staging fbtft fb_ssd1351 driver in the same series (per
Conor).
Amit Barzilai (4):
dt-bindings: display: Add Solomon SSD1351 OLED controller
drm/ssd130x: Add RGB565 support to SSD133X family
drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support
staging: fbtft: remove fb_ssd1351 driver
.../bindings/display/solomon,ssd1351.yaml | 42 +++
drivers/gpu/drm/solomon/ssd130x-spi.c | 7 +
drivers/gpu/drm/solomon/ssd130x.c | 269 +++++++++++++++---
drivers/gpu/drm/solomon/ssd130x.h | 12 +-
drivers/staging/fbtft/Kconfig | 5 -
drivers/staging/fbtft/Makefile | 1 -
drivers/staging/fbtft/fb_ssd1351.c | 240 ----------------
7 files changed, 283 insertions(+), 293 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
delete mode 100644 drivers/staging/fbtft/fb_ssd1351.c
--
2.54.0
^ permalink raw reply
* [PATCH v2 1/4] dt-bindings: display: Add Solomon SSD1351 OLED controller
From: Amit Barzilai @ 2026-06-22 15:25 UTC (permalink / raw)
To: javierm, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
robh, krzk+dt, conor+dt, andy, gregkh, deller
Cc: azuddinadam, chintanlike, dri-devel, devicetree, linux-kernel,
linux-fbdev, linux-staging, Amit Barzilai
In-Reply-To: <20260622152506.78627-1-amit.barzilai22@gmail.com>
Add a device tree binding for the Solomon SSD1351, a 128x128 65k-color
RGB OLED display controller driven over a 4-wire SPI bus. The binding
builds on the shared solomon,ssd-common.yaml properties already used by
the other Solomon display controllers.
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Amit Barzilai <amit.barzilai22@gmail.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
.../bindings/display/solomon,ssd1351.yaml | 42 +++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
new file mode 100644
index 000000000000..80850c2ab5b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/solomon,ssd1351.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Solomon SSD1351 OLED Display Controller
+
+maintainers:
+ - Amit Barzilai <amit.barzilai22@gmail.com>
+ - Javier Martinez Canillas <javierm@redhat.com>
+
+allOf:
+ - $ref: solomon,ssd-common.yaml#
+
+properties:
+ compatible:
+ enum:
+ - solomon,ssd1351
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ oled@0 {
+ compatible = "solomon,ssd1351";
+ reg = <0x0>;
+ reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
+ dc-gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
+ spi-max-frequency = <10000000>;
+ };
+ };
--
2.54.0
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox