From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-221.mail.qq.com (out203-205-221-221.mail.qq.com [203.205.221.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CEB21C9F9; Thu, 13 Nov 2025 13:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.221 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763041204; cv=none; b=i/AbvwlizjARCvQbwYSkO2UkRb92FoaOV3w36MVRaBFZ5quR0Yl1BBIxDgh4KkyWCZxR8MRwgfI2PruqsXXI3xeSGeyiSgaQhEb/N7JI8vF4+U9QFtxqfQCWzEJ1P45fWKziEemKCJRXdUYrfDwPoBDjKirKKR81uDGtTLRDpKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763041204; c=relaxed/simple; bh=xRVLeggvTFpxhmDMhe6RFRSWS0nSpHS/MwOalgoq1Ho=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N0iB21AfmBnSpn0DAj9/GfM10jIigp6GHcmpbQqgvsrl6wRyCRYyZASaYenFAflUdg7GjexiDUL6NqDVuzY6onsVNZpRIrWpSlr+eSOsb4SqrhP7efdJS8TgrX+O8wVnXlPM2lcblU/9/v3hVPbcaWGErtt7q9nIR4nuEwrwNsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=ky16znsD; arc=none smtp.client-ip=203.205.221.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="ky16znsD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1763041198; bh=yncWPINDR52pv1d4G/0cf1imkpwN4ckdlyrwN55xFuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ky16znsDkRVEQfcfDUDWr1pnYmDt1Kh+QdNE3sgNUPUpJzN2YFjOv2Ch8plZqePxQ QHjmABMF4vfI4FrAiMC5cW1TObKaSNSQO63ynebACbtyGVIwVDCeLLWThR+1z/ECKl ct/T55Okb/+P7+LsKER4cRCvHCLlsk5IGhu55vhg= Received: from cjz-VMware-Virtual-Platform ([110.176.66.153]) by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP id 9F72569E; Thu, 13 Nov 2025 21:39:55 +0800 X-QQ-mid: xmsmtpt1763041195t2zcvgezd Message-ID: X-QQ-XMAILINFO: MDbayGdXPuoeQywFlMHCgen52JUQLc1cmq2dV28SszkRuGBqVKM7Cjf/40tDG8 bRJME2qqMhvfI5ygmbW1mPOv1PRrakSmUQ35T/GwhUfF20TJdsdlpJ8Bl3SrFDZdQUGMiOHLDuyt qKpgUIT/cdDeh3ChhYINPf8STcL0tkFVs7+Xnd5l0bh+fumoO4h1S7d7ew4dcil4o0Y/xVE1W89n 6Aym1Kjw9uH7hZQolbsQt4UuGQc5XLFee4VXMvUQRRSe2HtDrlJJ/c5jPMCF5NiacEH/94AWiLfM v6YbCfX7qSBFLwVtJbZ3298+thQMw9bQH2aH/8h1dmBTH1WKlswgbt5XGWga7usUcOPbUl9Hq40D 6sDQGbrbWUMHX1WXHu6jq1fdgP+LOVPIKpF/pD5VpN5+XDYlGtFDKqZB9kAlgvWc/7Mtwf9MkD38 b6nRbD15McDQs0HBgaHv7UzI0/73Q4mWN+yU0g+6lF8DAm0rMHZMusmVBvxruJthWSnvWaIthhMI FDJKCpdglTjeSwgUo5T2/qvluoJitYNfRSq+ukr3Lede+mMfLiC5JGqFjmq7eXy0eO4mN9hga9b0 WrYDmhm/siFdLZTfQSzVVp/wbiyC4pz1tqvE+9TJIscNcBfz/S++fdkvgN9W4mS9aX1HcUPTBJb1 YjMzmB/xB4dGYqq4t+1XUfQLbVeXEs+uZMwGqnIaooun+PncygTN5nBbxzX1kFJBJP6Xb+T3z9GG zRDzw448GFwLdkudnKJD7ibUZzjELFo5nKu6P7W0t85bOBDshE7HRh3qvPhYatXumkRHWGIAVygZ vSy6efJBndOhps7miQSuwaVdzwSb/Y1u7UZcZrj2TGcvpm4bt1ZRDY2wSieNsWTI9fQPii79B3uQ ta7g2aX0TJdx8+8vUSi5P7XTS/Z8LzWG8O1SsGFJUyOXhw/cmRak3CWFrKFmW/+QUlMd9FGQYkhz cZnRAmDY0VAMjW2d9nqutya34vXJd0OCV6gpwgdnNN3ScUegC9gwBz3+f067SLhZCC9AGfyylUzO 7NUzATjM24buqs1Y7i17Bi8PvHuVw= X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= Date: Thu, 13 Nov 2025 21:39:54 +0800 From: cjz_VM To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, guagua210311@qq.com Subject: Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const X-OQ-MSGID: References: <2025111341-attendee-ferment-262b@gregkh> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025111341-attendee-ferment-262b@gregkh> Hi Greg, Thanks for reviewing my patch! For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all. For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis. If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend. Thanks again for your time and guidance! Best regards, Chang JunzhengFrom: cjz_VM To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, guagua210311@qq.com Subject: Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const Reply-To: In-Reply-To: <2025111341-attendee-ferment-262b@gregkh> Hi Greg, Thanks for reviewing my patch! For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all. For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis. If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend. Thanks again for your time and guidance! Best regards, Chang Junzheng