From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B401C7683 for ; Tue, 3 Sep 2024 10:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725360775; cv=none; b=JfjEeeDLa5qvkv4WAyETaKCRL4MGx1tudY2gxpoOEKa8t+ExhUBUpdyH3E+bRbrCvZE3v+UorL47DDKPNHNsG9cL56EjW4dzqMXiDeAnUynM6+GzNYN7V3zhzFsRRmXoIWqsjmf+i4Sko3zrJ7xsw65PathJtr48JOA+3mveXXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725360775; c=relaxed/simple; bh=TCa9XECvj6a95ytuCJ/rfxMfMjBBJHeKZNA431XrJLI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Kz6e6P1ZqtitgvrOXZjbbNeDv9SA/PYNRaOHTEj4CyRU4Vn/b57tKG21vifQPgzIDi5FmGWgM5kyUaFnoBUFYR9g7c7W3lCE3tHe4Mfai08655O0oBbD7WNQtyOQKk3WHPJU+z/owuNGlM2Fyj8mWunAtXeT4RMtty1F3hGMHOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Wyj9k0Zx5z145xm; Tue, 3 Sep 2024 18:51:54 +0800 (CST) Received: from kwepemd500012.china.huawei.com (unknown [7.221.188.25]) by mail.maildlp.com (Postfix) with ESMTPS id 262C31800FE; Tue, 3 Sep 2024 18:52:50 +0800 (CST) Received: from [10.67.111.176] (10.67.111.176) by kwepemd500012.china.huawei.com (7.221.188.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Tue, 3 Sep 2024 18:52:49 +0800 Message-ID: <021d4b46-a559-4047-a6ca-98e30fd3e6b3@huawei.com> Date: Tue, 3 Sep 2024 18:52:48 +0800 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 11/12] wifi: wilc1000: Convert using devm_clk_get_optional_enabled() in wilc_sdio_probe() To: Kalle Valo CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20240831021334.1907921-1-lizetao1@huawei.com> <20240831021334.1907921-12-lizetao1@huawei.com> <87a5gqko2q.fsf@kernel.org> From: Li Zetao In-Reply-To: <87a5gqko2q.fsf@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggpeml500005.china.huawei.com (7.185.36.59) To kwepemd500012.china.huawei.com (7.221.188.25) Hi, 在 2024/9/3 0:38, Kalle Valo 写道: > Li Zetao writes: > >> Use devm_clk_get_optional_enabled() instead of devm_clk_get_optional() + >> clk_prepare_enable(), which can make the clk consistent with the device >> life cycle and reduce the risk of unreleased clk resources. Since the >> device framework has automatically released the clk resource, there is >> no need to execute clk_disable_unprepare(clk) on the error path, drop >> the clk_disable_unprepare label, and the original error process can change >> to dispose_irq. >> >> Signed-off-by: Li Zetao >> --- >> drivers/net/wireless/microchip/wilc1000/sdio.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) > > wifi patches (patches 11 and 12) go via wireless-next, please submit > those separately. Ok, I will resend those separately. > Thanks, Li Zetao.