From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5927E for ; Fri, 20 May 2022 07:57:30 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id y32so12962281lfa.6 for ; Fri, 20 May 2022 00:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LDOJGy883Whj2KPtZJS2ToqHv52wGZqpYAqQT+XUcgE=; b=isUGeH7YJ9hSFqU+LajDXfZhlKfVb7CX45XzIRyUTr6nxi+RtAGNgqGbnlsEQhvwYj DtZarkhGFwdzhP4U7a50sc89MgvxBhO8zNUt5YEZLuwaQ0rbV7tuhw9C3OHVafO+ZDPE ibZL6Q24dpZhKvcW2XmyFRDEbJHcahhp/Xga8jIN54sHD4+Vk7luFlD2au3HrMJQz8Z2 7s5UjC357gY4A1NloCW8kQDC3228Q254aC/poWeNagQEYcyaCCOIcDzHwut3LSow/2Cc AEp2zS8qrGbxkv0vEqfQriAoUknEGaCL+Xvtqsje2IVe+y2wtuZ4TmLz4ETDf4swtJ5j o0xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LDOJGy883Whj2KPtZJS2ToqHv52wGZqpYAqQT+XUcgE=; b=npYmYdMg3Lzra5s+JgVdzuXpnLdhQJsh/9063ZB4DNpjQEtQN+0gX/gxUrZOa4efOr KLn/BkwMDvDf0EO73CVlVDgUCZM437OKb0x7I5Ze57lPlmXsgXZu/SV3dyJucJ+cxtGx 9zoRUiNzzsrN4Iei+xKjE14XPyWr5Lrc4kbffQVDKTdbpnEcn4Gflw/xf/iX8C+xuafB nN5EqwUOKDeXHp8jl6rjGdqS9c0GZNTMvcLzbT5EBEFPbmwfDsB1Sw/L/nS4rDpNA1rR hhlEnb20A+dOOGAtESeaWtwxCuOaZnIodfWhVfeRaSYIEy3w840V240WOMk510cm+SdT du6w== X-Gm-Message-State: AOAM531/YU4LnyinkvO0PkbojOiTemTqF2uzgSlCHKCh2H4eXW+7ouCE rnHuO+Q5GcdrwwvEpSKsobx9oQ== X-Google-Smtp-Source: ABdhPJxwdWspWTlCev1Y+CnP3ttUl/Y734MOSgWU+vOZrJzIFaH1ePOp5e8j6NN5qbVKN4ceOqCbGQ== X-Received: by 2002:a05:6512:1319:b0:44a:c200:61e5 with SMTP id x25-20020a056512131900b0044ac20061e5mr6159427lfu.550.1653033448712; Fri, 20 May 2022 00:57:28 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020ac25505000000b004778c285166sm559287lfk.216.2022.05.20.00.57.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 00:57:28 -0700 (PDT) Message-ID: <0518eef1-75a6-fbfe-96d8-bb1fc4e5178a@linaro.org> Date: Fri, 20 May 2022 09:57:26 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Content-Language: en-US To: Mark Brown , Andrew Lunn Cc: Corentin Labbe , calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org References: <20220518200939.689308-1-clabbe@baylibre.com> <20220518200939.689308-5-clabbe@baylibre.com> <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/05/2022 17:49, Mark Brown wrote: > On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote: >> On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote: >>> On 19/05/2022 13:31, Mark Brown wrote: >>>> On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote: >>>>> On 18/05/2022 22:09, Corentin Labbe wrote: > >>>>>> + regulators: >>>>>> + description: >>>>>> + List of phandle to regulators needed for the PHY > >>>>> I don't understand that... is your PHY defining the regulators or using >>>>> supplies? If it needs a regulator (as a supply), you need to document >>>>> supplies, using existing bindings. > >>>> They're trying to have a generic driver which works with any random PHY >>>> so the binding has no idea what supplies it might need. > >>> OK, that makes sense, but then question is why not using existing >>> naming, so "supplies" and "supply-names"? > >> I'm not saying it is not possible, but in general, the names are not >> interesting. All that is needed is that they are all on, or >> potentially all off to save power on shutdown. We don't care how many >> there are, or what order they are enabled. > > I think Krzysztof is referring to the name of the property rather than > the contents of the -names property there. Yes, exactly. Existing pattern for single regulator supply is "xxx-supply", so why this uses a bit different pattern instead of something more consistent ("supplies" and "supply-names")? Best regards, Krzysztof