From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6402E31F995; Fri, 21 Aug 2026 13:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787319617; cv=none; b=WCfrU2kQI21wEjLaWBJR80BNaOFITmxMJ6CYuE5ZePikbfXdsUAoPtGTVEUP8vUYtgJRZDGENSLwx7eLnTjiTKBjVElyF0Qp2DJw28+VAE6ykbp87OJoT/0F+OQQTZ/DSfNRSCRJCEnGSdaIvGLS4zLBC0dBB4ncLxvQfCRHH4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787319617; c=relaxed/simple; bh=nZtcGenSSy82MXscgS3TQDHNGhXxDRFUvHEV/XVmaDg=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=jsY5Q4VDjzvu2nPpSIZYtAD0IrB/KDS2wvQLiCOJ3620FAcMmC+Q6XGxa4jRrxGPxrRTr6rfk9jfCyKGqdsRD8TyRxcv5Q4JW8RGlyjkvJyHXl0vaHM7mBqYmv615kFpW0HGwNpCaRsFdBAuHu2oA15ZSQemWzFDJsG9RacKRQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=1kbLw/lN; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="1kbLw/lN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1787319615; x=1818855615; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nZtcGenSSy82MXscgS3TQDHNGhXxDRFUvHEV/XVmaDg=; b=1kbLw/lN9LaF6GPjQG+zYeSY/Dunhmd7vIjEJGmq/NATEccZYUMPy8Z8 JzqdrnY8i5O2vA/FfC5eEXRQbzqQR8ZWvwMFtkaX90aLkYOTJWEMfOBGG e3xTxeYrhlhFq6K8hwveQ82RZrU8PpR76gNlkwKy/fDFWncvvgZhHnGhY JokmW9n/WNL9BrwoqKxWoY6eLDGfT/yLvSMknfkflSoYOQ68UXUvifKsk dbGYk0SrgfIPACOD1dPuza0BbqVA5rxtVub48wkKjr1fE1izY1o5LwueK IS6mYarirVjc4TFF784h7emDtqq6Ivxa3pj9V26Jfmxv7EfJv5BEGxyLf g==; X-CSE-ConnectionGUID: HyXRN8+nRO6IAOBi+2U6dQ== X-CSE-MsgGUID: F1ngVutmTiOQH0sP1B/9VA== X-IronPort-AV: E=Sophos;i="6.25,235,1779174000"; d="scan'208";a="62471628" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Aug 2026 06:40:05 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Fri, 21 Aug 2026 06:40:04 -0700 Received: from [10.171.248.60] (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Fri, 21 Aug 2026 06:39:47 -0700 Message-ID: <0903bc22-e913-4e14-99f6-db6b97aa3a27@microchip.com> Date: Fri, 21 Aug 2026 15:39:46 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/45] clk: at91: Make sure clk_init_data is fully initialized To: Geert Uytterhoeven , Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , =?UTF-8?Q?Emilio_L=C3=B3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger CC: , , , , , , , , , , , , , , , References: From: Nicolas Ferre Content-Language: en-US, fr Organization: microchip In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 21/08/2026 at 10:53, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. > --- > drivers/clk/at91/clk-audio-pll.c | 4 ++-- > drivers/clk/at91/clk-h32mx.c | 2 +- > drivers/clk/at91/clk-main.c | 2 +- > drivers/clk/at91/clk-pll.c | 2 +- > drivers/clk/at91/clk-plldiv.c | 2 +- > drivers/clk/at91/clk-slow.c | 2 +- > drivers/clk/at91/clk-smd.c | 2 +- > drivers/clk/at91/clk-usb.c | 6 +++--- > drivers/clk/at91/sckc.c | 2 +- > 9 files changed, 12 insertions(+), 12 deletions(-) Acked-by: Nicolas Ferre Thanks Geert, Nicolas