From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 146AE122AB for ; Mon, 7 Nov 2022 19:09:25 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id f5so32797291ejc.5 for ; Mon, 07 Nov 2022 11:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wc34CxtEOLkSkiQr361kqOgarEc3e05LL4CC8n3q+Yg=; b=MfJt6vqUvl9d2QwzN79EWkGlv9xQvsKg6qW/nuvZj3vutK07lQREteD9jvTdwD4mUs cCe2VwZo3iEJF6ZVHT4lp+dSS5XgBxg9O/SdckevvjaiK92s6OPeQtPRbE26fiKGNr1s Xm05WlDJc9s4nVcFIcISpz4vHrFkOpb87Kvx/AggAEjHwP97g78jEUq9nU3YIlVk+yvX Vw2UGW6EOVcTEs8cesZj5GtkEndzTKKIBL8mZdR0Gs+x5RWLcU/oNIYPNcDmXvfkkAp+ 31I9CxdidxbQ30o8A6EqGJ2W4STLOoG/uss/ng536xqR6ijghJbrTrnO++Jps53BaECt lPNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wc34CxtEOLkSkiQr361kqOgarEc3e05LL4CC8n3q+Yg=; b=x1xHXBPWd8OBoW0F3Vferugg7ezP/GIDJ7nULj7Zvw/ksZRWRSjn3dkwyuNGzwxLKs rh1IKBhUQIX909CAxEJECe9dwuV4l9ctJBXO8OxtNM8PCN/mP1wKfgqelXrSyeX3fIvj eaPvYU4A0RU3ErGb90MOKMj8r39MowqMb2FLYB3d6pPWSk1BiEiZXjpB3uKPUnDHErdM POh/AcTWbPGQCk5RN5nwax973caTvS9V6vgLU6vApSpflVCPvi0a1bdCzwbSgQdTD4P2 sdCQ38qoXrgPl25KPRA+EHHKcZyZ2hLAAmYBZii23c5DWH+YBdnj2SqpvJ4ab16GJDrO i1zQ== X-Gm-Message-State: ACrzQf358zeScU4uwFPXnp0nyQjlNuZ5oJcTAcEI8TtgsI1eRP7+Wskk Rr9jVF9XNgqrAA0tZe7Kchg= X-Google-Smtp-Source: AMsMyM7RT31J7AYXOqj7NXxs7sV37GSZBoUybdyBFoXG5ZdfIxCN8Q5j0SVVcDS70m8z7me697XQFA== X-Received: by 2002:a17:906:730d:b0:78e:9ca5:3269 with SMTP id di13-20020a170906730d00b0078e9ca53269mr49378907ejc.366.1667848164346; Mon, 07 Nov 2022 11:09:24 -0800 (PST) Received: from kista.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id k10-20020a17090632ca00b007adaca75bd0sm3783218ejk.179.2022.11.07.11.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 11:09:23 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Samuel Holland , Chen-Yu Tsai , Kishon Vijay Abraham I , Vinod Koul , Andre Przywara Cc: Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Karl Kurbjun , Icenowy Zheng Subject: Re: [PATCH v2 0/7] arm64: sunxi: h616: Add USB support Date: Mon, 07 Nov 2022 20:09:22 +0100 Message-ID: <111191160.nniJfEyVGO@kista> In-Reply-To: <20221031111358.3387297-1-andre.przywara@arm.com> References: <20221031111358.3387297-1-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne ponedeljek, 31. oktober 2022 ob 12:13:51 CET je Andre Przywara napisal(a): > This is a fixed and rebased update of the previous version, with only > the DT binding and one DT seeing changes, triggered by Krzysztof's > comments. For a changelog see below. > Thanks to Karl for testing this on the OrangePi Zero 2! > > ------------------------ > The USB IP used in the Allwinner H616 SoC is very similar to the one > used in the H3 chip: it contains four USB 2.0 host controllers and four > PHYs, where the first PHY is shared with a separate USB-OTG controller. > > But out of the four ports, only port 2 works out of the box, the other > ports require some resources and registers of port 2 to be enabled as > well. > > Implement the required workaround in the Allwinner USB PHY driver, and > key this off the respective compatible string. This core code is > contained in patch 3/7. The first two patches add the respective DT > binding documentation, whereas patch 4/7 encodes all the configuration > options for the H616 USB PHY into the driver. > The last three patches add the respective devicetree nodes, to the H616 > .dtsi, but also to the DTs of the two supported boards. > > This allows USB to be used on any H616 based machine. This was tested on > the X96 Mate box. > > The patches in this series were originally contained in the initial H616 > support series, but where dropped there to speed up mainlining of the > basic support. > > It is now based on v6.1-rc3 and is also available here: > https://github.com/apritzel/linux/commits/h616-usb-v2 > > Please have a look and test on your hardware, especically on all ports > exposed on header pins of the OrangePi Zero2 board. > > Cheers, > Andre > > Changelog v1 .. v2: > - Add Krzysztof's ACK > - wrap If: clause in allOf: (patch 2/7) > - limit old (H3) PHYs to 4 clocks (else clause, patch 2/7) > - change subsystem to phy: in subject (patch 2/7) > - use "regulator-" prefix for DT node name (patch 6/7) > - drop unneeded status property in regulator node (patch 6/7) > > Andre Przywara (7): > dt-bindings: usb: Add H616 compatible string > dt-bindings: phy: Add special clock for Allwinner H616 PHY > phy: sun4i-usb: Introduce port2 SIDDQ quirk > phy: sun4i-usb: Add support for the H616 USB PHY > arm64: dts: allwinner: h616: Add USB nodes > arm64: dts: allwinner: h616: OrangePi Zero 2: Add USB nodes > arm64: dts: allwinner: h616: X96 Mate: Add USB nodes Applied patches 1, 5, 6, 7. Thanks! Best regards, Jernej