From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5EDF645 for ; Fri, 12 Aug 2022 10:49:26 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id v2so830831lfi.6 for ; Fri, 12 Aug 2022 03:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=UJnFvf2CipkkOM+lYgM36L0ZtmP7Hx57QaN536b3YCw=; b=GOKMFNg1REVIwFrExYqDnxeUxvmN6E6p1tHUohNkXRce3yIDW9omFNKeKDn50YdSj7 jR+iLaL7K7o1v1j+HwmvXdLnGwH/Z4n7sra00irgT2f7Wk4Bv28PT1fqBGO0XV2WQSRH FtIqjm63bbe8hZEAVGKm+hELlLOmxMqxInFpYj27Ap1mRoWRDVEvzIbAM9fCd8njNmYw ZLy1OQXmqj9WtiJM2UEdbgb+9QJJGrhPewkdoh7QsIclb1Ip0jSPzjdZ7z3fSmGF4Aq1 syIo5izG7Mk7/uh40LPecqsMusRl25/M2WVcFcl+iVulYvxUi9jx4q5FEjRLv/M8fs0G Z5Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=UJnFvf2CipkkOM+lYgM36L0ZtmP7Hx57QaN536b3YCw=; b=d7m+yFdmubQofUSUlLOVsbz0gjsLnPXu99ccfwKj3wCtqFI6NjOs7GGSv9QTN/I5WP 3oDoIqBu6kK/Lqfh6HYP8F1C7LNaQeU29vilYclHWy8yx52JBqQzmNg83hN8HvVPdJIR 9OeMSnfEEFgdNFf1H0UeVmB4uf3xMxWJGn5qR/N3v9vCOAAUgJDFzLPrsftCHOJUfq2a 8yzzS+4XVumicWTcrmXxVDxOqC7cF3y0UaG9rgXjYbcMX62Fjl4MIFBZOP+oFmL7xo4X jL5mXL7FUVRHcj/Qf/RlEsKetkqTIgZmufTrRC9ku9JXXOPejsnltb/XHzRanix0vc0z xRZA== X-Gm-Message-State: ACgBeo1FvoNu8WRT/5HwvBZrxLUcEqfgIots4Or2apAwS0zzHQvqaA11 dJdjlz/TgzizSsW0lOLI72GGhQ== X-Google-Smtp-Source: AA6agR5b1udKMfU6HMSFMRaqG2/gb4fi6eYQzjti5Wtvya5ucwIJC/D1/rchFHsRLMSOw7dMOtSjPw== X-Received: by 2002:ac2:5cc6:0:b0:48a:f879:f6ef with SMTP id f6-20020ac25cc6000000b0048af879f6efmr1018055lfq.347.1660301364948; Fri, 12 Aug 2022 03:49:24 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id p8-20020ac24ec8000000b0048b29b13d22sm166371lfr.299.2022.08.12.03.49.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 03:49:24 -0700 (PDT) Message-ID: <13fcaa01-d2c0-e57f-bedc-b2e0536a55f9@linaro.org> Date: Fri, 12 Aug 2022 13:49:19 +0300 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/4] dt-bindings: display: sun6i-dsi: Add the A100 variant Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard Cc: Daniel Vetter , David Airlie , Jagan Teki , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20220812074257.58254-1-samuel@sholland.org> <20220812074257.58254-3-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20220812074257.58254-3-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/08/2022 10:42, Samuel Holland wrote: > The "40nm" MIPI DSI controller found in the A100 and D1 SoCs has the > same register layout as previous SoC integrations. However, its module > clock now comes from the TCON, which means it no longer runs at a fixed > rate, so this needs to be distinguished in the driver. > > The controller also now uses pins on Port D instead of dedicated pins, > so it drops the separate power domain. > > Signed-off-by: Samuel Holland > --- > Removal of the vcc-dsi-supply is maybe a bit questionable. Since there > is no "VCC-DSI" pin anymore, it's not obvious which pin actually does > power the DSI controller/PHY. Possibly power comes from VCC-PD or VCC-IO > or VCC-LVDS. So far, all boards have all of these as always-on supplies, > so it is hard to test. > > .../display/allwinner,sun6i-a31-mipi-dsi.yaml | 28 +++++++++++++++---- > 1 file changed, 23 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > index ae55ef3fb1fe..c53c25b87bd4 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > @@ -12,9 +12,14 @@ maintainers: > > properties: > compatible: > - enum: > - - allwinner,sun6i-a31-mipi-dsi > - - allwinner,sun50i-a64-mipi-dsi > + oneOf: > + - enum: > + - allwinner,sun6i-a31-mipi-dsi > + - allwinner,sun50i-a64-mipi-dsi > + - allwinner,sun50i-a100-mipi-dsi While you are moving code, how about bringing alphabetical order? > + - items: > + - const: allwinner,sun20i-d1-mipi-dsi > + - const: allwinner,sun50i-a100-mipi-dsi > > reg: > maxItems: 1 > @@ -59,7 +64,6 @@ required: > - phys > - phy-names > - resets > - - vcc-dsi-supply > - port > > allOf: > @@ -68,7 +72,9 @@ allOf: > properties: > compatible: > contains: > - const: allwinner,sun6i-a31-mipi-dsi > + enum: > + - allwinner,sun6i-a31-mipi-dsi > + - allwinner,sun50i-a100-mipi-dsi Here as well > > then: > properties: > @@ -83,6 +89,18 @@ allOf: > clocks: > maxItems: 1 > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - allwinner,sun6i-a31-mipi-dsi > + - allwinner,sun50i-a64-mipi-dsi and here Best regards, Krzysztof