From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F51A11182 for ; Mon, 19 Jun 2023 14:13:51 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5149aafef44so4180332a12.0 for ; Mon, 19 Jun 2023 07:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687184029; x=1689776029; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jVJ0BYxgwjT3FqtgMQASJ1B7HEopYnAjVGB5hh3e82E=; b=M9z4P28nrWagW+IjU4/HCdHHlcaQEqWX7EhrBPn1H9FU9ONO2pp1EL7jsnMEg7I4ll 8xceJ4/OUlji0kH8mkofXiti0XNSLOkB+0Wf65ZU6tfTxko/+anKk/1IzQtfC9nnhqSn v0saRZq6uSUhQLNS5JT3kdhnjZ1/DyphBy0cqE3yW2OKeZHjRnC6OjUVX+4oCtNaiyT0 nEvPBH35+Sk+tWFKYpqAJs0dpnJouPKSb3L5KOAJ2FDdXEY0jtAzK+tNFs328b615JL0 /6vKlg8BGmt4r1XepjO9UvUPwEkZC6srmp/+i8Iy9RuuagsWQKejiIk0zVJtpTdvqsaa zNpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687184029; x=1689776029; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jVJ0BYxgwjT3FqtgMQASJ1B7HEopYnAjVGB5hh3e82E=; b=hKNcW1cyy4pryDi248PBnbXzwobL/448q38kbq8LZ1Ossk3eQ09wy/ZFsTGVJ0+mdm xepP/NxAxCuY6k/8E5Oi6boq5lQ2UlOWmITN5QbcUOzQzetN5f5qvDjW7diDzOg4+h2v OCSU3u75M9NskD1Qa3AyHelO2O+EZk/jkoSx+HZGQ4hq7GBhrOUduoh8ndFCVgjFfVRE PotQQFmH6JLL3Fx6xdQhhaMtbIwvi8CqtKHNTFg3KkEu/TMFPUTYSVgAg+KlEHLvucVk rRw7DhwLJopdr6412wXiMSBWxw5GyiNpfVvqr5DNFhZ6ogplW4A0zyzYuu2gFmUyM9wV ayPA== X-Gm-Message-State: AC+VfDx2Jdx1u6rOfCTxWTN3ZBaS6StrCdax//NGWVTW85dW6FmVGtJF 0RKx2Fzrm8rsarMyLgj2TmHr7A== X-Google-Smtp-Source: ACHHUZ7O2sSAG3s4Vml5tVOvx0rnJQoDa5gdvDzwpYu+SWO687o/I76se/9w1hJ7dH9KrjVmuODOeQ== X-Received: by 2002:a05:6402:164c:b0:51a:4452:ae0c with SMTP id s12-20020a056402164c00b0051a4452ae0cmr4540560edx.35.1687184029619; Mon, 19 Jun 2023 07:13:49 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id p4-20020a05640210c400b005158563be4asm13096759edu.33.2023.06.19.07.13.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 07:13:49 -0700 (PDT) Message-ID: <158425ec-86e8-ca3e-eed8-e14b37c42730@linaro.org> Date: Mon, 19 Jun 2023 16:13:44 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table To: Sakari Ailus , Hans Verkuil Cc: Joe Tessler , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> <98a77653-ec58-56c4-9893-3b424f67c87e@linaro.org> <5afcec8b-b8f6-35b0-278a-5de185e4a7a2@xs4all.nl> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25/05/2023 15:19, Sakari Ailus wrote: > Hi folks, > > On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote: >> Hi Hans, >> >> On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: >>> On 12/05/2023 18:35, Krzysztof Kozlowski wrote: >>>> On 12/03/2023 14:12, Krzysztof Kozlowski wrote: >>>>> The driver can match only via the DT table so the table should be always >>>>> used and the of_match_ptr does not have any sense (this also allows ACPI >>>>> matching via PRP0001, even though it might not be relevant here). >>>>> >>>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski >>>>> --- >>>> >>>> Hans, Sakari, >>>> >>>> Can you pick up the patchset? There was positive feedback: >>>> https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ >>>> >>>> but it seems it was not applied. >>> >>> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't >>> see a corresponding pull request for this series. >>> >>> Sakari, did something go wrong? >> >> I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for >> this --- I intended to take these but I think I must have missed something >> important in the process. I'll take them now. >> >> Thanks. > > This no longer applied cleanly. Mostly there was fuzz near .of_match_table > changes as probe_new (and remove_new?) changes have been recently merged. > There were other issues as well, I marked a few patches in the set "not > applicable" as other patches had already done equivalent changes earlier. > > There were substance-changing changes in the 20th patch, replied to the > disuccsion there. > > I've pushed the result here and intend to send PR to Mauro soon if there > are no issues: > > One month later, I still don't see this set in the linux-next. What's happening here? Best regards, Krzysztof