From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [5.144.164.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179A6C14B for ; Mon, 4 Sep 2023 20:02:19 +0000 (UTC) Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id B39993F289; Mon, 4 Sep 2023 21:43:56 +0200 (CEST) Date: Mon, 04 Sep 2023 21:43:49 +0200 From: Martin Botka Subject: Re: [PATCH 5/6] arm64: dts: allwinner: h616: Add CPU Operating Performance Points table To: Krzysztof Kozlowski Cc: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Rogerio Goncalves , Martin Botka Message-Id: <158H0S.OVEJGSQROBDV1@somainline.org> In-Reply-To: References: <20230904-cpufreq-h616-v1-0-b8842e525c43@somainline.org> <20230904-cpufreq-h616-v1-5-b8842e525c43@somainline.org> X-Mailer: geary/43.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed On Mon, Sep 4 2023 at 09:33:33 PM +02:00:00, Krzysztof Kozlowski wrote: > On 04/09/2023 17:57, Martin Botka wrote: >> Add an Operating Performance Points table for the CPU cores to >> enable Dynamic Voltage & Frequency Scaling on the H616. >> > > ... > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> index 063db9634e5f..78e79c591dba 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> @@ -143,6 +143,10 @@ sid: efuse@3006000 { >> ths_calibration: thermal-sensor-calibration@14 { >> reg = <0x14 0x8>; >> }; >> + >> + cpu_speed_grade: cpu_speed_grade@0 { > > Underscores are no allowed in node names. > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). I actually did. And did rerun it just now to check. No error or warning was reported by dtbs_check W=1 for this. But I will correct it in V2 and look if my setup is doing something wrong that its not reporting these issues. Cheers, Martin > > Best regards, > Krzysztof >