[PATCH V5 3/3] riscv: tlbflush: Optimize coding convention

guoren
2021-06-06T09:05:20Z

From: Guo Ren <guoren@linux.alibaba.com>

Passing the mm_struct as the first argument, as we can derive both
the cpumask and asid from it instead of doing that in the callers.

But more importantly, the static branch check can be moved deeper
into the code to avoid a lot of duplication.

Also add FIXME comment on the non-ASID code switches to a global
flush once flushing more than a single page.

Link: https://lore.kernel.org/linux-riscv/CAJF2gTQpDYtEdw6ZrTVZUYqxGdhLPs25RjuUiQtz=xN2oKs2fw@mail.gmail.com/T/#m30f7e8d02361f21f709bc3357b9f6ead1d47ed43
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Co-Developed-by: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: Anup Patel <anup.patel@wdc.com>
Cc: Atish Patra <atish.patra@wdc.com>
---
arch/riscv/mm/tlbflush.c | 91 ++++++++++++++++++++++--------------------------
1 file changed, 41 insertions(+), 50 deletions(-)

diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c
index 87b4e52..facca6e 100644
--- a/arch/riscv/mm/tlbflush.c
+++ b/arch/riscv/mm/tlbflush.c
@@ -12,56 +12,59 @@ void flush_tlb_all(void)
}

/*
- * This function must not be called with cmask being null.
+ * This function must not be called with mm_cpumask(mm) being null.
* Kernel may panic if cmask is NULL.
*/
-static void __sbi_tlb_flush_range(struct cpumask *cmask, unsigned long start,
+static void __sbi_tlb_flush_range(struct mm_struct *mm,
+ unsigned long start,
unsigned long size)
{
+ struct cpumask *cmask = mm_cpumask(mm);
struct cpumask hmask;
unsigned int cpuid;
+ bool local;

if (cpumask_empty(cmask))
return;

cpuid = get_cpu();

- if (cpumask_any_but(cmask, cpuid) >= nr_cpu_ids) {
- /* local cpu is the only cpu present in cpumask */
- if (size <= PAGE_SIZE)
- local_flush_tlb_page(start);
- else
- local_flush_tlb_all();
- } else {
- riscv_cpuid_to_hartid_mask(cmask, &hmask);
- sbi_remote_sfence_vma(cpumask_bits(&hmask), start, size);
- }
+ /*
+ * check if the tlbflush needs to be sent to other CPUs, local
+ * cpu is the only cpu present in cpumask.
+ */
+ local = !(cpumask_any_but(cmask, cpuid) < nr_cpu_ids);

- put_cpu();
-}
-
-static void __sbi_tlb_flush_range_asid(struct cpumask *cmask,
- unsigned long start,
- unsigned long size,
- unsigned long asid)
-{
- struct cpumask hmask;
- unsigned int cpuid;
-
- if (cpumask_empty(cmask))
- return;
-
- cpuid = get_cpu();
+ if (static_branch_likely(&use_asid_allocator)) {
+ unsigned long asid = atomic_long_read(&mm->context.id);

- if (cpumask_any_but(cmask, cpuid) >= nr_cpu_ids) {
- if (size == -1)
- local_flush_tlb_all_asid(asid);
- else
- local_flush_tlb_range_asid(start, size, asid);
+ if (likely(local)) {
+ if (size == -1)
+ local_flush_tlb_all_asid(asid);
+ else
+ local_flush_tlb_range_asid(start, size, asid);
+ } else {
+ riscv_cpuid_to_hartid_mask(cmask, &hmask);
+ sbi_remote_sfence_vma_asid(cpumask_bits(&hmask),
+ start, size, asid);
+ }
} else {
- riscv_cpuid_to_hartid_mask(cmask, &hmask);
- sbi_remote_sfence_vma_asid(cpumask_bits(&hmask),
- start, size, asid);
+ if (likely(local)) {
+ /*
+ * FIXME: The non-ASID code switches to a global flush
+ * once flushing more than a single page. It's made by
+ * commit 6efb16b1d551 (RISC-V: Issue a tlb page flush
+ * if possible).
+ */
+ if (size <= PAGE_SIZE)
+ local_flush_tlb_page(start);
+ else
+ local_flush_tlb_all();
+ } else {
+ riscv_cpuid_to_hartid_mask(cmask, &hmask);
+ sbi_remote_sfence_vma(cpumask_bits(&hmask),
+ start, size);
+ }
}

put_cpu();
@@ -69,28 +72,16 @@ static void __sbi_tlb_flush_range_asid(struct cpumask *cmask,

void flush_tlb_mm(struct mm_struct *mm)
{
- if (static_branch_unlikely(&use_asid_allocator))
- __sbi_tlb_flush_range_asid(mm_cpumask(mm), 0, -1,
- atomic_long_read(&mm->context.id));
- else
- __sbi_tlb_flush_range(mm_cpumask(mm), 0, -1);
+ __sbi_tlb_flush_range(mm, 0, -1);
}

void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
{
- if (static_branch_unlikely(&use_asid_allocator))
- __sbi_tlb_flush_range_asid(mm_cpumask(vma->vm_mm), addr, PAGE_SIZE,
- atomic_long_read(&vma->vm_mm->context.id));
- else
- __sbi_tlb_flush_range(mm_cpumask(vma->vm_mm), addr, PAGE_SIZE);
+ __sbi_tlb_flush_range(vma->vm_mm, addr, PAGE_SIZE);
}

void flush_tlb_range(struct vm_area_struct *vma, unsigned long start,
unsigned long end)
{
- if (static_branch_unlikely(&use_asid_allocator))
- __sbi_tlb_flush_range_asid(mm_cpumask(vma->vm_mm), start, end - start,
- atomic_long_read(&vma->vm_mm->context.id));
- else
- __sbi_tlb_flush_range(mm_cpumask(vma->vm_mm), start, end - start);
+ __sbi_tlb_flush_range(vma->vm_mm, start, end - start);
}
--
2.7.4