From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25BE2FAE for ; Fri, 3 Sep 2021 15:56:15 +0000 (UTC) Received: by mail-ot1-f43.google.com with SMTP id q11-20020a9d4b0b000000b0051acbdb2869so7090976otf.2 for ; Fri, 03 Sep 2021 08:56:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=Qw1bAMElDkYxGWDBqnwHtgJcwFZ+rm2etjwEK2p/4FE=; b=I3YoNdZuxmtrg6Mr4eWkZDe34iTdvMrSHkEhW2Gty+zNajwLYgVvSCwmq9DRlG/HdL oEGSAEk0WTRK9zXn0IKlbN/h4wJVrPzJscz+qSo1+VTFfaCavZOxOaKiD4jOJx1c9khE 6Ak2jkSigaUDuJZT2PDu093OGrZY5KDqdq5TQIpeFNh3kAdYRWAU5qLlFLf+mLBZ4uv/ jxbJtH02Ss4kHQZxvG389ICJ/qXOK3/GTquYZq7oh31h32NKEoNgb4qJva/fNgep0hPd OwEZDMswp2XAqQJLI8xryrWjUAgj8buVWfILv1DuGcX4RguHnJi6qhRUHCEvc9MXvM8D yknQ== X-Gm-Message-State: AOAM531U7vThT2DmejxHZA1reJWhwAVPvFTzfLJk4V/fGDc6jCLUpFFO cBD3WH2OY2+DKLiXJQoFSA== X-Google-Smtp-Source: ABdhPJyAMzmsbFER7typFkPmoLeoFJ2qnfJ2IG5LxBRRPRujgg0zeim5BgpDaIjgj5gWlPBji7nqUw== X-Received: by 2002:a9d:1c97:: with SMTP id l23mr3638349ota.230.1630684573465; Fri, 03 Sep 2021 08:56:13 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id r31sm1043893otv.45.2021.09.03.08.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 08:56:12 -0700 (PDT) Received: (nullmailer pid 3010407 invoked by uid 1000); Fri, 03 Sep 2021 15:56:11 -0000 From: Rob Herring To: Samuel Holland Cc: Rob Herring , linux-leds@vger.kernel.org, Pavel Machek , Maxime Ripard , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , Icenowy Zheng , linux-sunxi@lists.linux.dev In-Reply-To: <20210902234228.32223-1-samuel@sholland.org> References: <20210902234228.32223-1-samuel@sholland.org> Subject: Re: [PATCH 1/2] dt-bindings: leds: Add Allwinner R329/D1 LED controller Date: Fri, 03 Sep 2021 10:56:11 -0500 Message-Id: <1630684571.592582.3010406.nullmailer@robh.at.kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: On Thu, 02 Sep 2021 18:42:27 -0500, Samuel Holland wrote: > The Allwinner R329 and D1 SoCs contain an LED controller designed to > drive a series of RGB LED pixels. It supports PIO and DMA transfers, and > has configurable timing and pixel format. > > Signed-off-by: Samuel Holland > --- > .../leds/allwinner,sun50i-r329-ledc.yaml | 141 ++++++++++++++++++ > 1 file changed, 141 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/allwinner,sun50i-r329-ledc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/leds/allwinner,sun50i-r329-ledc.yaml:83:3: [error] duplication of key "t1h-ns" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/leds/allwinner,sun50i-r329-ledc.example.dts' Traceback (most recent call last): File "/usr/local/bin/dt-extract-example", line 45, in binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 122, in get_single_data return self.construct_document(node) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 132, in construct_document for _dummy in generator: File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 722, in construct_yaml_map value = self.construct_mapping(node) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 446, in construct_mapping return BaseConstructor.construct_mapping(self, node, deep=deep) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 264, in construct_mapping if self.check_mapping_key(node, key_node, mapping, key, value): File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 295, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "", line 17, column 3 found duplicate key "t1h-ns" with value "{}" (original value: "{}") in "", line 83, column 3 To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/leds/allwinner,sun50i-r329-ledc.example.dts] Error 1 Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 25, in check_doc testtree = dtschema.load(filename, line_number=line_number) File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 623, in load return yaml.load(f.read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 122, in get_single_data return self.construct_document(node) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 132, in construct_document for _dummy in generator: File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 722, in construct_yaml_map value = self.construct_mapping(node) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 446, in construct_mapping return BaseConstructor.construct_mapping(self, node, deep=deep) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 264, in construct_mapping if self.check_mapping_key(node, key_node, mapping, key, value): File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 295, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "", line 17, column 3 found duplicate key "t1h-ns" with value "{}" (original value: "{}") in "", line 83, column 3 To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 67, in ret = check_doc(f) File "/usr/local/bin/dt-doc-validate", line 30, in check_doc print(filename + ":", exc.path[-1], exc.message, file=sys.stderr) AttributeError: 'DuplicateKeyError' object has no attribute 'path' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/allwinner,sun50i-r329-ledc.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/leds/allwinner,sun50i-r329-ledc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1523964 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.