From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F6D47A for ; Fri, 22 Apr 2022 21:10:52 +0000 (UTC) Received: by mail-oi1-f171.google.com with SMTP id a10so10395193oif.9 for ; Fri, 22 Apr 2022 14:10:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=J6rqRfMieshNlsEnUPYfVWhJgAntYIwqBg8y4VOu9MM=; b=4j6KWvIiyuJr/brUQNdCmFk+Oe8uoYdPfA7a8yrtsEcTYjXZ5L1xHKbYx3dgrmfpi5 L32gVPbhHIP7Vf7atbQJrBTknz9HKHqSa7o4UR2my9PbqzfuPNhYmOfMfsMi0/hAsU9Z MT+MZ5ICWLaENfInrjydQ4xwvWVHqVUzf1hKX39Rd5WtdNWCphtawuMxOo+RYkoolgNb oFGdazWQvMdVFbKmqFl9ktO+g32aHtAj36kiEsxV6tCE1xBGGpmL9TY4E8ErGIUkUWAg GvOBbUjLS3InHyYHZvAriHZDd6d/fgAulHQDtgyNj1wl5rMEeXS1B0lMtlgr6kDlH8Nd z+nA== X-Gm-Message-State: AOAM531n2kCtwZeqUAC9Hpa7jLltkssy3tyluq9iLdObV/lK0+jUQyb1 lG1VQZXF06Q7HL99JOd57A== X-Google-Smtp-Source: ABdhPJw3FMFldMU2qxgLgJpZScY+EUzAC+IZqNRhFvnPBjaTLofwsJMPu2/vSLA8NxsTdHjlGDDTYA== X-Received: by 2002:a05:6808:10c6:b0:2f9:a7fb:823b with SMTP id s6-20020a05680810c600b002f9a7fb823bmr7798368ois.249.1650661851222; Fri, 22 Apr 2022 14:10:51 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x21-20020a4a6215000000b0033993dc1d65sm1230760ooc.8.2022.04.22.14.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 14:10:50 -0700 (PDT) Received: (nullmailer pid 2784288 invoked by uid 1000); Fri, 22 Apr 2022 21:10:47 -0000 From: Rob Herring To: icenowy@outlook.com Cc: "Rafael J . Wysocki" , Daniel Lezcano , linux-kernel@vger.kernel.org, Amit Kucheria , Samuel Holland , linux-arm-kernel@lists.infradead.org, Yangtao Li , Rob Herring , devicetree@vger.kernel.org, Vasily Khoruzhick , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, linux-pm@vger.kernel.org, Icenowy Zheng , Jernej Skrabec , Zhang Rui In-Reply-To: References: Subject: Re: [PATCH 1/2] dt-bindings: thermal: sun8i-thermal: add binding for R329 THS Date: Fri, 22 Apr 2022 16:10:47 -0500 Message-Id: <1650661847.274095.2784287.nullmailer@robh.at.kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: On Sat, 23 Apr 2022 00:11:55 +0800, icenowy@outlook.com wrote: > From: Icenowy Zheng > > R329 has a thermal sensor controller that has only one sensor, and the > structure of it is like the H6 one. > > Add device tree binding for it. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml:90:13: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.example.dts' Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml: found duplicate key "const" with value "allwinner,sun8i-r329-ths" (original value: "allwinner,sun8i-h3-ths") make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 25, in check_doc testtree = dtschema.load(filename, line_number=line_number) File "/usr/local/lib/python3.10/dist-packages/dtschema/lib.py", line 912, in load return yaml.load(f.read()) File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/main.py", line 434, in load return constructor.get_single_data() File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 121, in get_single_data return self.construct_document(node) File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 131, in construct_document for _dummy in generator: File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 674, in construct_yaml_map value = self.construct_mapping(node) File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 445, in construct_mapping return BaseConstructor.construct_mapping(self, node, deep=deep) File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 263, in construct_mapping if self.check_mapping_key(node, key_node, mapping, key, value): File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 294, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "", line 89, column 13 found duplicate key "const" with value "allwinner,sun8i-r329-ths" (original value: "allwinner,sun8i-h3-ths") in "", line 90, column 13 To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 74, in ret = check_doc(f) File "/usr/local/bin/dt-doc-validate", line 30, in check_doc print(filename + ":", exc.path[-1], exc.message, file=sys.stderr) AttributeError: 'DuplicateKeyError' object has no attribute 'path' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml: ignoring, error parsing file make: *** [Makefile:1401: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.