ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: Rob Herring <robh+dt@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-kernel@vger.kernel.org,
	Andre Przywara <andre.przywara@arm.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	linux-sunxi@lists.linux.dev,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller
Date: Sun, 27 Nov 2022 10:25:30 -0600	[thread overview]
Message-ID: <166956617204.3782.6939462747953664680.robh@kernel.org> (raw)
In-Reply-To: <20221127073140.2093897-3-uwu@icenowy.me>


On Sun, 27 Nov 2022 15:31:36 +0800, Icenowy Zheng wrote:
> The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
> features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can
> be bypassed) and an external reset pin.
> 
> Add a device tree binding for its USB protocol part. The internal LDO is
> not covered by this and can just be modelled as a fixed regulator.
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> ---
>  .../bindings/usb/genesys,gl850g.yaml          | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/usb/genesys,gl850g.yaml: $id: relative path/filename doesn't match actual path or filename
	expected: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml: duplicate '$id' value 'http://devicetree.org/schemas/usb/realtek,rts5411.yaml#'
Error: Documentation/devicetree/bindings/usb/genesys,gl850g.example.dts:26.41-42 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/genesys,gl850g.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221127073140.2093897-3-uwu@icenowy.me

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command.


  reply	other threads:[~2022-11-27 16:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-27  7:31 [PATCH 0/6] Rongpin RP-H6B support (and support for GL850G) Icenowy Zheng
2022-11-27  7:31 ` [PATCH 1/6] dt-bindings: vendor-prefixes: add Genesys Logic Icenowy Zheng
2022-11-28  8:44   ` Krzysztof Kozlowski
2022-11-27  7:31 ` [PATCH 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller Icenowy Zheng
2022-11-27 16:25   ` Rob Herring [this message]
2022-11-28  8:47   ` Krzysztof Kozlowski
2022-11-27  7:31 ` [PATCH 3/6] usb: misc: onboard_usb_hub: add Genesys Logic GL850G hub support Icenowy Zheng
2022-11-28 18:01   ` Matthias Kaehlcke
2022-11-27  7:31 ` [PATCH 4/6] vendor-prefixes: Add Shenzhen Rongpin Electronics Co., Ltd Icenowy Zheng
2022-11-28  8:47   ` Krzysztof Kozlowski
2022-11-27  7:31 ` [PATCH 5/6] dt-bindings: arm: sunxi: add Rongpin RP-H6B board Icenowy Zheng
2022-11-28  8:48   ` Krzysztof Kozlowski
2022-11-27  7:31 ` [PATCH 6/6] arm64: dts: allwinner: h6: add Rongpin RP-H6C SoM and " Icenowy Zheng
2022-11-28  8:50   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166956617204.3782.6939462747953664680.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andre.przywara@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-usb@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=uwu@icenowy.me \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox