[PATCH] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

[PATCH] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

[Chen-Yu Tsai]

When sun4i_spdif_quirks was recently expanded, the kerneldoc covering
the structure was not expanded to match. This ends up causing a warning
when the documents are built.

Add the missing fields.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501311953.0Ox9CW5w-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202503060947.QKUUR62l-lkp@intel.com/
Fixes: 0a2319308de8 ("ASoC: sun4i-spdif: Add clock multiplier settings")
Fixes: 4a5ac6cd05a7 ("ASoC: sun4i-spdif: Support SPDIF output on A523 family")
Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
---
 sound/soc/sunxi/sun4i-spdif.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 2e7ac8ab71bb..1e755a716c63 100644
--- a/sound/soc/sunxi/sun4i-spdif.c
+++ b/sound/soc/sunxi/sun4i-spdif.c
@@ -171,6 +171,8 @@
  * @reg_dac_txdata: TX FIFO offset for DMA config.
  * @has_reset: SoC needs reset deasserted.
  * @val_fctl_ftx: TX FIFO flush bitmask.
+ * @mclk_multiplier: ratio of internal MCLK divider
+ * @tx_clk_name: name of TX module clock if split clock design
  */
 struct sun4i_spdif_quirks {
 	unsigned int reg_dac_txdata;
-- 
2.47.3

Re: [PATCH] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

[Code Kipper]

On Sun, 21 Dec 2025 at 04:58, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> When sun4i_spdif_quirks was recently expanded, the kerneldoc covering
> the structure was not expanded to match. This ends up causing a warning
> when the documents are built.
>
> Add the missing fields.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501311953.0Ox9CW5w-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202503060947.QKUUR62l-lkp@intel.com/
> Fixes: 0a2319308de8 ("ASoC: sun4i-spdif: Add clock multiplier settings")
> Fixes: 4a5ac6cd05a7 ("ASoC: sun4i-spdif: Support SPDIF output on A523 family")
> Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
Hi Wens,
thanks for fixing this up.
Reviewed-by: Marcus Cooper <codekipper@gmail.com>
BR,
CK
> ---
>  sound/soc/sunxi/sun4i-spdif.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
> index 2e7ac8ab71bb..1e755a716c63 100644
> --- a/sound/soc/sunxi/sun4i-spdif.c
> +++ b/sound/soc/sunxi/sun4i-spdif.c
> @@ -171,6 +171,8 @@
>   * @reg_dac_txdata: TX FIFO offset for DMA config.
>   * @has_reset: SoC needs reset deasserted.
>   * @val_fctl_ftx: TX FIFO flush bitmask.
> + * @mclk_multiplier: ratio of internal MCLK divider
> + * @tx_clk_name: name of TX module clock if split clock design
>   */
>  struct sun4i_spdif_quirks {
>         unsigned int reg_dac_txdata;
> --
> 2.47.3
>
>

<http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.www.avg.com
<http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

Re: [PATCH] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

[Jernej Škrabec]

Dne nedelja, 21. december 2025 ob 04:57:13 Srednjeevropski standardni čas je Chen-Yu Tsai napisal(a):
> When sun4i_spdif_quirks was recently expanded, the kerneldoc covering
> the structure was not expanded to match. This ends up causing a warning
> when the documents are built.
> 
> Add the missing fields.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501311953.0Ox9CW5w-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202503060947.QKUUR62l-lkp@intel.com/
> Fixes: 0a2319308de8 ("ASoC: sun4i-spdif: Add clock multiplier settings")
> Fixes: 4a5ac6cd05a7 ("ASoC: sun4i-spdif: Support SPDIF output on A523 family")
> Signed-off-by: Chen-Yu Tsai <wens@kernel.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

Re: [PATCH] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks

[Mark Brown]

On Sun, 21 Dec 2025 11:57:13 +0800, Chen-Yu Tsai wrote:
> When sun4i_spdif_quirks was recently expanded, the kerneldoc covering
> the structure was not expanded to match. This ends up causing a warning
> when the documents are built.
> 
> Add the missing fields.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sun4i-spdif: Add missing kerneldoc fields for sun4i_spdif_quirks
      commit: 6c11aa2b4cf767f5ccfe290b2572d53102dbe5ea

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark