From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C3A854BFF for ; Tue, 26 Mar 2024 22:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492653; cv=none; b=A8020IGhSnAXO1acQSS8UNSqLQfQ5HVq/gagrRxYqxrwXXu6ODoe/79btrZLAAZPGXOWUJuN4CWEkmYHxYs6odbea6NbXVNGKPHvqD56IJWYif77/3nMrCMhGsHQNVt0wGiv+nXsB37dlA+9EllY7PXe3b4CRoHwgMEUjH+b0rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492653; c=relaxed/simple; bh=4yoVptj1UWplyDzAq7Tjl/TVNzbjsEvuyOqlRXRE7k4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pcgPTtS8dTRWE6y0MspN425bFPq/mOzD12i/ewTbdb/1YFnRb1ydV4shYjoXRAh6EUfttLDnOXxLaLqraIoZdhQRRvx2ru/NMq3fTIUdgEGJfqKd6gqmE6bvoZSouT6F61MpEINxOJU2k0U944quyUM3Iv93/wN9Y+Fihhexksk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bEGEY4Gv; arc=none smtp.client-ip=209.85.166.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bEGEY4Gv" Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7d0486cf91aso131633839f.1 for ; Tue, 26 Mar 2024 15:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711492650; x=1712097450; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SA/GLZl3h7HpI8vEB/ZyUsu3mvxu5V+a+bI3pQOrjds=; b=bEGEY4GvdOy6FhXFs5wpulfdh85aSLfAYP3oFjuDpGmutvxdqi/+jauBarSMrnUhnC B7R/+e9NrkaBOctK0bvXmkCLpBP01iAGnj2LPqzzK4VS5s0DIZBwdcHWw0Ss62e5h0VP zaLqaIOU42gH0g3thsIuSa9aCsDBzwKDddt9N8FXeFlcPUJhimZZJ5o7gJL5q2zZ3Px+ bOhMgSiKiKNol3px2WM7HizlgSbdS/HMrAGdjiNHT2MqTgLznMV9r70xiKfLp4erfDqK IHSoyA9gTesps3zeZPJ+6HsDCsJlwyKPoGCiDYy8auk+w8VbY8Wdbw/s+lgzninbUMkk bwZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711492650; x=1712097450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SA/GLZl3h7HpI8vEB/ZyUsu3mvxu5V+a+bI3pQOrjds=; b=Av6zvRRz1g2plK5iOqKPCNX6mWabqRhvCUy6H5YDRcR0UTed17vecwTJd+nMYE5uBo rB1PYVUT9azzg1umCVWMoMPuCR+U3DrEh8zsO2qwGE58zYcUJmj/3CaaX8DIsbLXEjYk FZxJVYo6vvKO1SG+DWS/M0WlrkJDp4Bj0bq5PpAtnao3N3MR5ged9Flo65RwFwh9I5WA ImtMlZmebbyUPmjkngEpGcbyQgXJd0Uh7kFcfSTdjHFaJ+Adwpefpieyce+KvHhM0qw2 dSXIbRAo/5WbzlEWUaEOMy9mrddo3UbRuWoDuyl9EaYfVHGy9luk/VG4SIRAKVJ0P8GK 4rZw== X-Forwarded-Encrypted: i=1; AJvYcCVS/7GX8o7nSePn92iTuQ4c6jJza0sq7eMI8f4Sknfba5XYuQxzFLDxUvaftavqd+66PPASpieUVtXdQUa919vUDkSehtH0u/l+gyI= X-Gm-Message-State: AOJu0YxBVTJPiZkNDsN958NQ44SGtOMLH4I0hJiie0/VoO3rvJFAz9ec L3k0zyzpIBb92p1jt3adUrcme36uDbzuNut0tV2stE5ZC7/It9NF X-Google-Smtp-Source: AGHT+IEsZu1f6Tc3oBDcbNx9nMtrh3Lz5apUbtKBHtrG7Zi1dBfQ06ge4SOqm91WZkV/knfGjfY5oQ== X-Received: by 2002:a05:6602:1d54:b0:7d0:5735:c460 with SMTP id hi20-20020a0566021d5400b007d05735c460mr7502224iob.3.1711492650493; Tue, 26 Mar 2024 15:37:30 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id it21-20020a056638859500b0047436275c32sm2950406jab.1.2024.03.26.15.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 15:37:30 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Denis Burkov Cc: Denis Burkov Subject: Re: [PATCH v2 2/2] ARM: dts: sun5i: Add PocketBook 614 Plus support Date: Tue, 26 Mar 2024 23:37:26 +0100 Message-ID: <1959471.PYKUYFuaPT@jernej-laptop> In-Reply-To: <20240317083445.4668-2-hitechshell@mail.ru> References: <20240317083445.4668-1-hitechshell@mail.ru> <20240317083445.4668-2-hitechshell@mail.ru> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Dne nedelja, 17. marec 2024 ob 09:34:45 CET je Denis Burkov napisal(a): > What works: > > - Serial console > - mmc0, mmc2 (both microSD card slots on the board) > - All buttons (gpio and lradc based) > - Power LED > - PMIC > - RTC > - USB OTG/gadgets mode > > Signed-off-by: Denis Burkov > --- > arch/arm/boot/dts/allwinner/Makefile | 1 + > .../sun5i-a13-pocketbook-614-plus.dts | 215 ++++++++++++++++++ > 2 files changed, 216 insertions(+) > create mode 100644 arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts > > diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/allwinner/Makefile > index 5fbb44ddacd0..6209243ad975 100644 > --- a/arch/arm/boot/dts/allwinner/Makefile > +++ b/arch/arm/boot/dts/allwinner/Makefile > @@ -61,6 +61,7 @@ dtb-$(CONFIG_MACH_SUN5I) += \ > sun5i-a13-olinuxino.dtb \ > sun5i-a13-olinuxino-micro.dtb \ > sun5i-a13-pocketbook-touch-lux-3.dtb \ > + sun5i-a13-pocketbook-614-plus.dtb \ > sun5i-a13-q8-tablet.dtb \ > sun5i-a13-utoo-p66.dtb \ > sun5i-gr8-chip-pro.dtb \ > diff --git a/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts b/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts > new file mode 100644 > index 000000000000..b5449301789a > --- /dev/null > +++ b/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts > @@ -0,0 +1,215 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2024 Denis Burkov > + */ > + > +/dts-v1/; > +#include "sun5i-a13.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > +#include > + > +/ { > + model = "PocketBook 614 Plus"; > + compatible = "pocketbook,614-plus", "allwinner,sun5i-a13"; > + > + aliases { > + serial0 = &uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + led { led-0 is preferred by the DT binding. Please also add function and color properties. Please run DT check with W=2 to catch andy other potential issues. Best regards, Jernej > + gpios = <&pio 4 8 GPIO_ACTIVE_LOW>; /* PE8 */ > + default-state = "on"; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + key-right { Key node names should contain key-[number], starting with 0. > + label = "Right"; > + linux,code = ; > + gpios = <&pio 6 9 GPIO_ACTIVE_LOW>; /* PG9 */ > + }; > + > + key-left { > + label = "Left"; > + linux,code = ; > + gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 */ > + }; > + }; > + > + reg_3v3_mmc0: regulator-mmc0 { > + compatible = "regulator-fixed"; > + regulator-name = "vdd-mmc0"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 4 4 GPIO_ACTIVE_LOW>; /* PE4 */ > + vin-supply = <®_vcc3v3>; > + }; > +}; > + > +&cpu0 { > + cpu-supply = <®_dcdc2>; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&i2c0 { > + status = "okay"; > + > + axp209: pmic@34 { > + compatible = "x-powers,axp209"; > + reg = <0x34>; > + interrupts = <0>; > + }; > +}; > + > +#include "axp209.dtsi" > + > +&i2c1 { > + status = "okay"; > + > + pcf8563: rtc@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + #clock-cells = <0>; > + }; > +}; > + > +&lradc { > + vref-supply = <®_ldo2>; > + status = "okay"; > + > + button-300 { > + label = "Down"; > + linux,code = ; > + channel = <0>; > + voltage = <300000>; > + }; > + > + button-700 { > + label = "Up"; > + linux,code = ; > + channel = <0>; > + voltage = <700000>; > + }; > + > + button-1000 { > + label = "Left"; > + linux,code = ; > + channel = <0>; > + voltage = <1000000>; > + }; > + > + button-1200 { > + label = "Menu"; > + linux,code = ; > + channel = <0>; > + voltage = <1200000>; > + }; > + > + button-1500 { > + label = "Right"; > + linux,code = ; > + channel = <0>; > + voltage = <1500000>; > + }; > +}; > + > +&mmc0 { > + vmmc-supply = <®_3v3_mmc0>; > + bus-width = <4>; > + cd-gpios = <&pio 6 0 GPIO_ACTIVE_LOW>; /* PG0 */ > + status = "okay"; > +}; > + > +&mmc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc2_4bit_pc_pins>; > + vmmc-supply = <®_vcc3v3>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&otg_sram { > + status = "okay"; > +}; > + > +®_dcdc2 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1500000>; > + regulator-name = "vdd-cpu"; > +}; > + > +®_dcdc3 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + regulator-name = "vdd-int-dll"; > +}; > + > +®_ldo1 { > + regulator-name = "vdd-rtc"; > +}; > + > +®_ldo2 { > + regulator-always-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-name = "avcc"; > +}; > + > +®_usb0_vbus { > + status = "okay"; > + gpio = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > +}; > + > +®_usb1_vbus { > + gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */ > + status = "okay"; > +}; > + > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pg_pins>; > + status = "okay"; > +}; > + > +&usb_otg { > + dr_mode = "otg"; > + status = "okay"; > +}; > + > +&usb_power_supply { > + status = "okay"; > +}; > + > +&battery_power_supply { > + status = "okay"; > +}; > + > +&usbphy { > + usb0_id_det-gpios = <&pio 6 2 GPIO_ACTIVE_HIGH>; /* PG2 */ > + usb0_vbus_det-gpios = <&axp_gpio 1 GPIO_ACTIVE_HIGH>; > + usb0_vbus-supply = <®_usb0_vbus>; > + usb1_vbus-supply = <®_usb1_vbus>; > + status = "okay"; > +}; >