From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Li Zetao <lizetao1@huawei.com>,
andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org,
heiko@sntech.de, yisen.zhuang@huawei.com, salil.mehta@huawei.com,
hauke@hauke-m.de, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
wellslutw@gmail.com, radhey.shyam.pandey@amd.com,
michal.simek@amd.com, ajay.kathat@microchip.com,
claudiu.beznea@tuxon.dev, kvalo@kernel.org,
u.kleine-koenig@pengutronix.de, jacky_chou@aspeedtech.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 01/12] net: dsa: bcm_sf2: Convert using devm_clk_get_optional_enabled() in bcm_sf2_sw_probe()
Date: Mon, 2 Sep 2024 08:20:35 -0700 [thread overview]
Message-ID: <1e92f33b-9900-4834-80e1-dcbb48cd8394@broadcom.com> (raw)
In-Reply-To: <20240831021334.1907921-2-lizetao1@huawei.com>
On 8/30/2024 7:13 PM, Li Zetao wrote:
> Use devm_clk_get_optional_enabled() instead of devm_clk_get_optional() +
> clk_prepare_enable(), which can make the clk consistent with the device
> life cycle and reduce the risk of unreleased clk resources. Since the
> device framework has automatically released the clk resource, there is
> no need to execute clk_disable_unprepare(clk) on the error path, drop
> the out_clk_mdiv and out_clk labels, and the original error process can
> be returned directly.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2024-09-02 15:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 2:13 [PATCH net-next 00/12] net: Convert using devm_clk_get_enabled()/devm_clk_get_optional_enabled() Li Zetao
2024-08-31 2:13 ` [PATCH net-next 01/12] net: dsa: bcm_sf2: Convert using devm_clk_get_optional_enabled() in bcm_sf2_sw_probe() Li Zetao
2024-09-02 15:20 ` Florian Fainelli [this message]
2024-08-31 2:13 ` [PATCH net-next 02/12] net: ethernet: Convert using devm_clk_get_enabled() in emac_probe() Li Zetao
2024-08-31 2:13 ` [PATCH net-next 03/12] net: ethernet: arc: " Li Zetao
2024-08-31 2:13 ` [PATCH net-next 04/12] net: ethernet: ethoc: Convert using devm_clk_get_enabled() in ethoc_probe() Li Zetao
2024-08-31 2:13 ` [PATCH net-next 05/12] net: ftgmac100: Convert using devm_clk_get_enabled() in ftgmac100_setup_clk() Li Zetao
2024-09-03 8:09 ` Uwe Kleine-König
2024-09-03 10:46 ` Li Zetao
2024-09-03 15:52 ` Uwe Kleine-König
2024-08-31 2:13 ` [PATCH net-next 06/12] net: ethernet: hisilicon: Convert using devm_clk_get_enabled() in hisi_femac_drv_probe() Li Zetao
2024-08-31 2:13 ` [PATCH net-next 07/12] net: lantiq_xrx200: Convert using devm_clk_get_enabled() in xrx200_probe() Li Zetao
2024-08-31 2:13 ` [PATCH net-next 08/12] net: stmmac: dwmac-dwc-qos-eth: Convert using devm_clk_get_enabled() in dwc_qos_probe() Li Zetao
2024-08-31 2:13 ` [PATCH net-next 09/12] net: ethernet: sunplus: Convert using devm_clk_get_enabled() in spl2sw_probe() Li Zetao
2024-09-03 22:16 ` Jakub Kicinski
2024-09-04 1:27 ` Li Zetao
2024-09-04 5:20 ` Andrew Lunn
2024-08-31 2:13 ` [PATCH net-next 10/12] net: xilinx: axienet: Convert using devm_clk_get_optional_enabled() in axienet_probe() Li Zetao
2024-09-01 12:28 ` Pandey, Radhey Shyam
2024-09-03 2:27 ` Li Zetao
2024-08-31 2:13 ` [PATCH net-next 11/12] wifi: wilc1000: Convert using devm_clk_get_optional_enabled() in wilc_sdio_probe() Li Zetao
2024-09-02 16:38 ` Kalle Valo
2024-09-03 10:52 ` Li Zetao
2024-08-31 2:13 ` [PATCH net-next 12/12] wifi: wilc1000: Convert using devm_clk_get_optional_enabled() in wilc_bus_probe() Li Zetao
2024-09-06 23:17 ` [PATCH net-next 00/12] net: Convert using devm_clk_get_enabled()/devm_clk_get_optional_enabled() Jeff Johnson
2024-09-07 2:55 ` Li Zetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e92f33b-9900-4834-80e1-dcbb48cd8394@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=ajay.kathat@microchip.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=heiko@sntech.de \
--cc=jacky_chou@aspeedtech.com \
--cc=jernej.skrabec@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=salil.mehta@huawei.com \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wellslutw@gmail.com \
--cc=wens@csie.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox