Re: [PATCH v6 03/17] dt-bindings: rtc: sun6i: Add H616 compatible string

Samuel Holland
2021-05-21T02:37:37Z

Andre,

On 5/19/21 5:41 AM, Andre Przywara wrote:
> Add the obvious compatible name to the existing RTC binding.
> The actual RTC part of the device uses a different day/month/year
> storage scheme, so it's not compatible with the previous devices.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> index b1b0ee769b71..178c955f88bf 100644
> --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> @@ -26,6 +26,7 @@ properties:
> - const: allwinner,sun50i-a64-rtc
> - const: allwinner,sun8i-h3-rtc
> - const: allwinner,sun50i-h6-rtc
> + - const: allwinner,sun50i-h616-rtc
>
> reg:
> maxItems: 1
> @@ -97,7 +98,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: allwinner,sun50i-h6-rtc
> + enum:
> + - allwinner,sun50i-h6-rtc
> + - allwinner,sun50i-h616-rtc
>
> then:
> properties:
>

This binding is missing a clock reference for the pll-periph0-2x input
to the 32kHz clock fanout.

It is also missing a clock reference to the RTC register gate (and that
clock is in turn missing from the r_ccu driver).

Regards,
Samuel