Re: [PATCH v7 03/19] dt-bindings: rtc: sun6i: Add H616 compatible string

Andre Przywara
2021-06-16T15:00:16Z

On Tue, 15 Jun 2021 17:35:02 -0600
Rob Herring <robh@kernel.org> wrote:

Hi,

> On Tue, Jun 15, 2021 at 12:06:20PM +0100, Andre Przywara wrote:
> > Add the obvious compatible name to the existing RTC binding.
> > The actual RTC part of the device uses a different day/month/year
> > storage scheme, so it's not compatible with the previous devices.
> > Also the clock part is quite different, as there is no external 32K LOSC
> > oscillator input.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> > index b1b0ee769b71..2c3fd72e17ee 100644
> > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> > @@ -26,6 +26,7 @@ properties:
> > - const: allwinner,sun50i-a64-rtc
> > - const: allwinner,sun8i-h3-rtc
> > - const: allwinner,sun50i-h6-rtc
> > + - const: allwinner,sun50i-h616-rtc
> >
> > reg:
> > maxItems: 1
> > @@ -105,6 +106,20 @@ allOf:
> > minItems: 3
> > maxItems: 3
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: allwinner,sun50i-h616-rtc
> > +
> > + then:
> > + properties:
> > + clock-output-names:
> > + minItems: 3
> > + maxItems: 3
> > + clocks:
> > + maxItems: 0
>
> clocks: false
>
> if forbidding clocks is what you want.

Yes, thanks for the hint!

Cheers,
Andre

>
> > +
> > - if:
> > properties:
> > compatible:
> > --
> > 2.17.5
>