From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F91F2C80 for ; Sun, 21 Nov 2021 19:54:01 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id n12so70723836lfe.1 for ; Sun, 21 Nov 2021 11:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirenboard-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nQP1NjnROxOP2uUy2qYpkLLRNOS1H+2WMTMotJrpSCw=; b=6nmLl4db9aEDbKdFkJJ6+dSghC5PwZb/o9t6251/zT4OmGX2ZRX8H6Ay75EzOFwV6Y bap2Egm54SWuhvp6vktnaYBnX7sWg2ZHiL4Ju4K5pRB03MBIsJWF4E8UJtBayl8Ns+IT JZqyrCETcPkY0dTbLMPXNBTGq+lWC06lJHoHRlIqrfSeTRe9EzrDE0Fmr9qlsiB3jaJA yLY/I5aOtASEYnmeNw82D23k4e7PPTEKRKvp7IC4GN2iJGBGrV/r9ThZ853aoToyi/ge hPgTOJQHqyOGh6o3GHBZysie8Um4XEpegugHCo72iu2e9RvfCmQK0vgyuv2B9JNtqOIt 56dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nQP1NjnROxOP2uUy2qYpkLLRNOS1H+2WMTMotJrpSCw=; b=YjxBpijqiv5ApLtKp3jZoHKK3UYoRiiZnoAXaFIEkyN3b8eLTuFxHcQth1Dswnh8/2 tcAVQTZN8o+GoTkLVDARVUXRoP3ZpDbsRACwlUmZ+MPkBUUR1pYIgLdFhrcvEhZ/jMXA UK/3KiukgtZsuYW7c+2NUhTuiKnq8S1xaNckG3gAU2gUT+ewbJySQUxyAZkO9BcO6kqu ALD8v1W9jxKSsIecfFWNycJuWzmtLvpv06SsjnYrH7qko5Z++4PIVOBu+jisM2GeXxFR 5xtoyDiAcylzkxQ/56sC9Fw/us5pvk8xPaT1cI00xH+7PpT0kiGRrnZTVsPZbjOkdhMN sZag== X-Gm-Message-State: AOAM5338DVcpPudKo9LGWJvBUkUwZc6PL4gd4AgDoRENHmBlUiPuTtqK VpnwjNOoASBzPJWAhp4aVIkjsQ== X-Google-Smtp-Source: ABdhPJxifYrrCmCT6QRgl2SG0RtsCFdGwUTA6xje0y+r42KUO/VE9Rp5aGnPezZjfiSYKUblUCXLew== X-Received: by 2002:a2e:86da:: with SMTP id n26mr46096926ljj.522.1637524439998; Sun, 21 Nov 2021 11:53:59 -0800 (PST) Received: from boger-laptop.lan (81.5.99.121.dhcp.mipt-telecom.ru. [81.5.99.121]) by smtp.gmail.com with ESMTPSA id a24sm768987ljq.18.2021.11.21.11.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Nov 2021 11:53:59 -0800 (PST) From: Evgeny Boger To: Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Cc: Evgeny Boger , devicetree@vger.kernel.org, Rob Herring , linux-sunxi@lists.linux.dev Subject: [PATCH v3 1/3] net: allwinner: reset control support Date: Sun, 21 Nov 2021 22:53:35 +0300 Message-Id: <20211121195337.230475-2-boger@wirenboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211121195337.230475-1-boger@wirenboard.com> References: <20211121195337.230475-1-boger@wirenboard.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit R40 (aka V40/A40i/T3) and A10/A20 share the same EMAC IP. However, on R40 the EMAC is gated by default. Signed-off-by: Evgeny Boger --- drivers/net/ethernet/allwinner/sun4i-emac.c | 64 +++++++++++++++++++-- 1 file changed, 59 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c index 800ee022388f..16039784f2c6 100644 --- a/drivers/net/ethernet/allwinner/sun4i-emac.c +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include "sun4i-emac.h" @@ -68,6 +69,15 @@ MODULE_PARM_DESC(watchdog, "transmit timeout in milliseconds"); * devices, EMACA and EMACB. */ +/** + * struct emac_quirks - Differences between SoC variants. + * + * @has_reset: SoC needs reset deasserted. + */ +struct emac_quirks { + bool has_reset; +}; + struct emac_board_info { struct clk *clk; struct device *dev; @@ -85,6 +95,7 @@ struct emac_board_info { unsigned int link; unsigned int speed; unsigned int duplex; + struct reset_control *reset; phy_interface_t phy_interface; }; @@ -790,6 +801,7 @@ static int emac_probe(struct platform_device *pdev) struct emac_board_info *db; struct net_device *ndev; int ret = 0; + const struct emac_quirks *quirks; ndev = alloc_etherdev(sizeof(struct emac_board_info)); if (!ndev) { @@ -808,6 +820,13 @@ static int emac_probe(struct platform_device *pdev) spin_lock_init(&db->lock); + quirks = of_device_get_match_data(&pdev->dev); + if (!quirks) { + dev_err(&pdev->dev, "Failed to determine the quirks to use\n"); + ret = -ENODEV; + goto out; + } + db->membase = of_iomap(np, 0); if (!db->membase) { dev_err(&pdev->dev, "failed to remap registers\n"); @@ -824,16 +843,31 @@ static int emac_probe(struct platform_device *pdev) goto out_iounmap; } + if (quirks->has_reset) { + db->reset = devm_reset_control_get_exclusive(&pdev->dev, NULL); + if (IS_ERR(db->reset)) { + dev_err(&pdev->dev, "unable to request reset\n"); + ret = PTR_ERR(db->reset); + goto out_dispose_mapping; + } + + ret = reset_control_deassert(db->reset); + if (ret) { + dev_err(&pdev->dev, "could not deassert EMAC reset\n"); + goto out_dispose_mapping; + } + } + db->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(db->clk)) { ret = PTR_ERR(db->clk); - goto out_dispose_mapping; + goto out_assert_reset; } ret = clk_prepare_enable(db->clk); if (ret) { dev_err(&pdev->dev, "Error couldn't enable clock (%d)\n", ret); - goto out_dispose_mapping; + goto out_assert_reset; } ret = sunxi_sram_claim(&pdev->dev); @@ -889,6 +923,8 @@ static int emac_probe(struct platform_device *pdev) sunxi_sram_release(&pdev->dev); out_clk_disable_unprepare: clk_disable_unprepare(db->clk); +out_assert_reset: + reset_control_assert(db->reset); out_dispose_mapping: irq_dispose_mapping(ndev->irq); out_iounmap: @@ -909,6 +945,7 @@ static int emac_remove(struct platform_device *pdev) unregister_netdev(ndev); sunxi_sram_release(&pdev->dev); clk_disable_unprepare(db->clk); + reset_control_assert(db->reset); irq_dispose_mapping(ndev->irq); iounmap(db->membase); free_netdev(ndev); @@ -940,11 +977,28 @@ static int emac_resume(struct platform_device *dev) return 0; } -static const struct of_device_id emac_of_match[] = { - {.compatible = "allwinner,sun4i-a10-emac",}, +static const struct emac_quirks sun4i_a10_emac_quirks = { + .has_reset = false, +}; + +static const struct emac_quirks sun4i_r40_emac_quirks = { + .has_reset = true, +}; +static const struct of_device_id emac_of_match[] = { + { + .compatible = "allwinner,sun4i-a10-emac", + .data = &sun4i_a10_emac_quirks + }, + { + .compatible = "allwinner,sun4i-r40-emac", + .data = &sun4i_r40_emac_quirks + }, /* Deprecated */ - {.compatible = "allwinner,sun4i-emac",}, + { + .compatible = "allwinner,sun4i-emac", + .data = &sun4i_a10_emac_quirks + }, {}, }; -- 2.25.1