Re: [PATCH 22/56] ASoC: sunxi: Update to use set_fmt_new callback

Charles Keepax
2022-05-20T09:57:23Z

On Thu, May 19, 2022 at 06:40:11PM -0500, Samuel Holland wrote:
> On 5/19/22 10:42 AM, Charles Keepax wrote:
> > As part of updating the core to directly tell drivers if they are clock
> > provider or consumer update these CPU side drivers to use the new direct
> > callback.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > sound/soc/sunxi/sun4i-i2s.c | 20 ++++++++++----------
> > sound/soc/sunxi/sun8i-codec.c | 8 ++++----
> > 2 files changed, 14 insertions(+), 14 deletions(-)
> > diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c
> > index 0bea2162f68d9..6e9ef948d6621 100644
> > --- a/sound/soc/sunxi/sun8i-codec.c
> > +++ b/sound/soc/sunxi/sun8i-codec.c
> > @@ -286,11 +286,11 @@ static int sun8i_codec_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> > u32 dsp_format, format, invert, value;
> >
> > /* clock masters */
> > - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> > - case SND_SOC_DAIFMT_CBS_CFS: /* Codec slave, DAI master */
> > + switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
> > + case SND_SOC_DAIFMT_BP_FP: /* Codec slave, DAI master */
>
> This is a codec driver, and it is only ever used on the codec end of a link, so
> I would not expect it to be changed.
>

Thanks for spotting that, silly mistake on my part. Will fix for
a rev 2.

Thanks,
Charles