From: Corentin Labbe <clabbe@baylibre.com>
To: herbert@gondor.apana.org.au, hch@lst.de, heiko@sntech.de
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev,
Corentin Labbe <clabbe@baylibre.com>
Subject: [RFC PATCH] crypto: flush poison data
Date: Fri, 1 Jul 2022 13:27:35 +0000 [thread overview]
Message-ID: <20220701132735.1594822-1-clabbe@baylibre.com> (raw)
On my Allwinner D1 nezha, the sun8i-ce fail self-tests due to:
alg: skcipher: cbc-des3-sun8i-ce encryption overran dst buffer on test vector 0
In fact the buffer is not overran by device but by the dma_map_single() operation.
To prevent any corruption of the poisoned data, simply flush them before
giving the buffer to the tested driver.
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
Hello
I put this patch as RFC, since this behavour happen only on non yet merged RISCV code.
(Mostly riscv: implement Zicbom-based CMO instructions + the t-head variant)
Regards
crypto/testmgr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index c59bd9e07978..187163e2e593 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -19,6 +19,7 @@
#include <crypto/aead.h>
#include <crypto/hash.h>
#include <crypto/skcipher.h>
+#include <linux/cacheflush.h>
#include <linux/err.h>
#include <linux/fips.h>
#include <linux/module.h>
@@ -205,6 +206,8 @@ static void testmgr_free_buf(char *buf[XBUFSIZE])
static inline void testmgr_poison(void *addr, size_t len)
{
memset(addr, TESTMGR_POISON_BYTE, len);
+ /* Be sure data is written to prevent corruption from some DMA sync */
+ flush_icache_range((unsigned long)addr, (unsigned long)addr + len);
}
/* Is the memory region still fully poisoned? */
--
2.35.1
next reply other threads:[~2022-07-01 13:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 13:27 Corentin Labbe [this message]
2022-07-01 13:35 ` [RFC PATCH] crypto: flush poison data Ben Dooks
2022-07-05 8:21 ` LABBE Corentin
2022-07-05 16:42 ` Christoph Hellwig
2022-07-05 17:56 ` LABBE Corentin
2022-07-05 17:58 ` Christoph Hellwig
2022-07-06 7:25 ` LABBE Corentin
2022-07-06 9:47 ` Ben Dooks
2022-07-06 11:58 ` Christoph Hellwig
2022-07-06 12:23 ` LABBE Corentin
2022-07-01 14:36 ` Andre Przywara
2022-07-01 14:55 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701132735.1594822-1-clabbe@baylibre.com \
--to=clabbe@baylibre.com \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox