From: Andre Przywara <andre.przywara@arm.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-sunxi@lists.linux.dev, u-boot@lists.denx.de
Subject: [PATCH 0/3] sunxi: FEL boot fixes
Date: Wed, 13 Jul 2022 16:27:55 +0100 [thread overview]
Message-ID: <20220713152758.56929-1-andre.przywara@arm.com> (raw)
While investigating a FEL boot failure on the OrangePi Zero 2 board
(with an H616 SoC), I stared at our FEL code and found some issues,
which this series fixes.
Unfortunately those didn't fix the H616 problem, but they are worth
having anyway.
For the records on the FEL failure: with certain H616 DRAM parameters,
newer GCCs (starting with GCC 11, GCC 10 is fine) generate an SPL binary
that doesn't properly return to the BootROM after the SPL code has
finished. This does not occur on other H616 boards using different DRAM
parameters. Staring at the disassemblies from the different compiler
versions for a while didn't show anything obvious, the best theory so
far is that it's due to a subtle timing issue in the DRAM initialisation
code. Inserting a "udelay(0);" at the beginning of
mctl_phy_read_calibration() seems to avoid the problem, but is obviously
not a proper fix. I will keep looking.
However the issues addressed in this series should be fixed, regardless.
Cheers,
Andre
Andre Przywara (3):
sunxi: armv8: fel: load only 32-bit values
sunxi: h616: lower SPL stack address to avoid BROM data
sunxi: fel: drop redundant "control register" save/restore
arch/arm/cpu/armv7/sunxi/fel_utils.S | 4 ----
arch/arm/cpu/armv8/fel_utils.S | 8 ++++----
arch/arm/mach-sunxi/board.c | 1 -
include/configs/sunxi-common.h | 2 +-
4 files changed, 5 insertions(+), 10 deletions(-)
--
2.25.1
next reply other threads:[~2022-07-13 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 15:27 Andre Przywara [this message]
2022-07-13 15:27 ` [PATCH 1/3] sunxi: armv8: fel: load only 32-bit values Andre Przywara
2023-01-08 20:39 ` Samuel Holland
2022-07-13 15:27 ` [PATCH 2/3] sunxi: h616: lower SPL stack address to avoid BROM data Andre Przywara
2023-01-08 20:49 ` Samuel Holland
2022-07-13 15:27 ` [PATCH 3/3] sunxi: fel: drop redundant "control register" save/restore Andre Przywara
2023-01-08 20:40 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713152758.56929-1-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox