From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 691377C for ; Wed, 17 Aug 2022 07:47:17 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 5BF862B0645B; Wed, 17 Aug 2022 03:47:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 17 Aug 2022 03:47:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660722433; x=1660729633; bh=c10x6DPPH/ zyhRLNi3d5jZ8ntKycPsFvNbbCBkCZ6Wg=; b=ZTdpXVPLY+Eom76PVAvHzJ9qgy wdAtZOnJHHp/TWy2k7Ss/kPsJwaq3mPMIp6LgJ6qk/hK+igzaiYy3CnfkbP37Td1 SBGA0Hx3i+bo1jkW979K77o2HD6PGJRzo8fWxlNYTAgm7jflKHILXVkdAtFubj3V UQY8jOqPgP4oVAcL9ocxkagUbMtw4Thzc6OdvRW/d2IOe9XladHFPu+FB3a9elZW Q3A1TsclMmsVzWngkiTiwi05a4S/P26neuZg5ThqOTLepL4fh60tPRHNI6NzvIFX sMMZVjY0zQQn5UEpfb0wbUtjfkl5CZotikTLvslaPKxWT09qjDFl7ztk5h+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660722433; x=1660729633; bh=c10x6DPPH/zyhRLNi3d5jZ8ntKyc PsFvNbbCBkCZ6Wg=; b=h6EBQs+anDCv314V5tPWR40hOWF/0dR5pskwb4J0Q4Ry FOlXHuSuBPAsFJu+Hiu1Jh4OHWDvJO2MsmoOikLYzJDtPsABIDAfQgvAwbe5l+5F CRwFv6NbKKviE5A/AsVyXr2rcINCTQlAA0TBcWQ+Xrpx0U+9lzopC2cFFDSTD9VJ 07hYP907H0CO78oPa/p7nunsH5KsGKUSt0U9Fx+zzyjPnjXqnYhA3Wl6DkYYL4kF HmH+PfX1DMT45ZfQ0F/TJtOYAX/8eFzz/OTc9nzOOmJWV0gizOgcnMcF9gBx0mdt z1x8Jj0da9F6x+ymAUp4f5G2IXlCCJHV400yJVKHog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehhedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepteefffefgfektdefgfeludfgtdejfeejvddttdekteeiffejvdfgheeh fffhvedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 03:47:12 -0400 (EDT) Date: Wed, 17 Aug 2022 09:47:10 +0200 From: Maxime Ripard To: Geert Uytterhoeven Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, Linux Kernel Mailing List , Phil Elwell , Mateusz Kwiatkowski , Linux ARM , Dave Stevenson , "open list:ARM/Amlogic Meson..." , DRI Development , Dom Cobley Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property Message-ID: <20220817074710.w4c4xwj7edly2b5p@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-5-3d53ae722097@cerno.tech> <20220816132040.uwirtjm5yr6rdd3q@houat> <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j4epzi7aeysknnpu" Content-Disposition: inline In-Reply-To: --j4epzi7aeysknnpu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wrote: > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > > Either you have to add them here (e.g. "hd720p50" and "hd720p= 60"), or > > > > > > > handle them through "@". The latter would impact "[= PATCH v1 > > > > > > > 09/35] drm/modes: Move named modes parsing to a separate func= tion", as > > > > > > > currently a named mode and a refresh rate can't be specified = both. > > > > > > > > > > > > I think the former would make more sense. It simplifies a bit t= he > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode propert= y as a > > > > > > > command-line option" uses a separate "tv_mode" option, and no= t the main > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > It's a separate story I think, we could have a named mode hd720= p50, > > > > > > which would be equivalent to 1280x720,tv_mode=3Dhd720p > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=3Dhd720p"? > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=3Dhd720p > > > > > > Above you said "I think the former would make more sense", so that > > > should be "1280x720,tv_mode=3Dhd720p50"? > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mode=3Dhd72= 0p > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=3Dhd720p >=20 > I disagree: hd720p50 and hd720p60 are different TV modes. I agree, and I don't see how that command-line doesn't express that? Maxime --j4epzi7aeysknnpu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvyc/gAKCRDj7w1vZxhR xbYJAP4lo6uMsFFPTrsZHvEPpQ07NeUAWTRQuIXy05w+861pgAD/caEkBK1BcdYO Ivf5+QCpwXLo3HITMUo8nRREVgKEiwc= =haso -----END PGP SIGNATURE----- --j4epzi7aeysknnpu--