From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D5F41E9FF for ; Wed, 2 Nov 2022 16:50:21 +0000 (UTC) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9836CC0007; Wed, 2 Nov 2022 16:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1667407813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZsyW8KhbSSKVe049F+rFznlD/CrHS6a/awk5KKcwAxk=; b=FJGlgULNNF8yfAiVsxOge3rp3zqT+bPsVZ/NcJIQVVEPrGHJ0G3ANYjBVm1V8jurCI5z9/ BaiUyUX5xKTM4MDUnpDdvqwfzCwjq0CQ12+3n4kJSKSEn+JZHXOBbrsXioyZanq4PfYESK +f7mld3Tgp86shRYUpMVDsoPr99xeYtu9GDpwELKZCVkinaj14W2hp8rL9O2y0koiy0rjN 3sdCsiuuaVQ4kNjaKXbXMVHfIUyXdDKlrNapg3MOMdC7OLth4arERUsWd0Ft8KGsGbMW6N GcesQ5HwTRPYgk/OF34RqNPM8fHoJcLWkEkOic8aKn6t0QMcBOcNZmfyKTkfpw== Date: Wed, 2 Nov 2022 17:50:07 +0100 From: Miquel Raynal To: Rob Herring Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Chen-Yu Tsai , Naga Sureshkumar Relli , Linus Walleij , Manivannan Sadhasivam , Maxime Ripard , Sureshkumar Relli , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 05/12] dt-bindings: mtd: onenand: Mention the expected node name Message-ID: <20221102175007.4a4db2c9@xps-13> In-Reply-To: <20221031205442.GA3307775-robh@kernel.org> References: <20221028235933.934850-1-miquel.raynal@bootlin.com> <20221028235933.934850-6-miquel.raynal@bootlin.com> <20221031205442.GA3307775-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Rob, robh@kernel.org wrote on Mon, 31 Oct 2022 15:54:42 -0500: > On Sat, Oct 29, 2022 at 01:59:26AM +0200, Miquel Raynal wrote: > > The chip node name in this driver is expected to be different and should > > be prefixed with onenand instead of the regular "flash" string, so > > mention it. > >=20 > > Signed-off-by: Miquel Raynal > > --- > > Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml= b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml > > index a953f7397c40..8a79ad300216 100644 > > --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml > > +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml > > @@ -15,6 +15,9 @@ description: > > as child nodes of the GPMC controller. > > =20 > > properties: > > + $nodename: > > + pattern: "^onenand@[0-9],[0,9]$" =20 >=20 > I don't think it is worth enforcing node names that we=20 > haven't defined in the spec. Wouldn't 'nand-controller' be appropriate? Actually I've added this pattern here because there are several users in the arm/boot/dts/ directory which use it, and the example below in this file also uses onenand@xxx. I can either fix the example to use nand-controller or add this pattern (I guess "deprecated: true" would not mean anything?). What do you prefer? If we decide to switch to the nand-controller@ name, shall I change the DTS as well? Thanks, Miqu=C3=A8l