From: Thomas Zimmermann <tzimmermann@suse.de>
To: sam@ravnborg.org, daniel@ffwll.ch, airlied@gmail.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
nouveau@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 13/22] drm/nouveau: Remove unnecessary include statements for drm_crtc_helper.h
Date: Mon, 16 Jan 2023 14:12:26 +0100 [thread overview]
Message-ID: <20230116131235.18917-14-tzimmermann@suse.de> (raw)
In-Reply-To: <20230116131235.18917-1-tzimmermann@suse.de>
Several source files include drm_crtc_helper.h without needing it or
only to get its transitive include statements; leading to unnecessary
compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where
possible.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
9 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index ca6d07d8c2c6..a6f2e681bde9 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
@@ -24,6 +24,7 @@
*/
#include <drm/drm_crtc_helper.h>
#include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
#include <drm/drm_plane_helper.h>
#include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/nouveau/dispnv04/dac.c b/drivers/gpu/drm/nouveau/dispnv04/dac.c
index 22d10f328559..d6b8e0cce2ac 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/dac.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/dac.c
@@ -24,7 +24,7 @@
* DEALINGS IN THE SOFTWARE.
*/
-#include <drm/drm_crtc_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
#include "nouveau_drv.h"
#include "nouveau_encoder.h"
diff --git a/drivers/gpu/drm/nouveau/dispnv04/dfp.c b/drivers/gpu/drm/nouveau/dispnv04/dfp.c
index ce3d8c6ef000..d5b129dc623b 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/dfp.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/dfp.c
@@ -24,8 +24,8 @@
* DEALINGS IN THE SOFTWARE.
*/
-#include <drm/drm_crtc_helper.h>
#include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
#include "nouveau_drv.h"
#include "nouveau_reg.h"
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c
index 2f6d2b6711ab..a3fedd226854 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c
@@ -24,7 +24,6 @@
*
*/
-#include <drm/drm_crtc_helper.h>
#include "nouveau_drv.h"
#include "nouveau_encoder.h"
#include "nouveau_crtc.h"
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv04.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv04.c
index 3ba7b59580d5..de3ea731d6e6 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv04.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv04.c
@@ -30,7 +30,7 @@
#include "nouveau_connector.h"
#include "nouveau_crtc.h"
#include "hw.h"
-#include <drm/drm_crtc_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
#include <drm/i2c/ch7006.h>
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index e5480dab55e3..670c9739e5e1 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -25,6 +25,7 @@
*/
#include <drm/drm_crtc_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
#include <drm/drm_probe_helper.h>
#include "nouveau_drv.h"
#include "nouveau_reg.h"
diff --git a/drivers/gpu/drm/nouveau/dispnv50/head.c b/drivers/gpu/drm/nouveau/dispnv50/head.c
index f006e56e1e08..5f490fbf1877 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/head.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/head.c
@@ -32,7 +32,6 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
-#include <drm/drm_crtc_helper.h>
#include <drm/drm_vblank.h>
#include "nouveau_connector.h"
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 574a8abf6a1d..cc7c5b4a05fd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -31,7 +31,6 @@
#include <linux/dynamic_debug.h>
#include <drm/drm_aperture.h>
-#include <drm/drm_crtc_helper.h>
#include <drm/drm_drv.h>
#include <drm/drm_fbdev_generic.h>
#include <drm/drm_gem_ttm_helper.h>
diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c
index 789393b94291..f8bf0ec26844 100644
--- a/drivers/gpu/drm/nouveau/nouveau_vga.c
+++ b/drivers/gpu/drm/nouveau/nouveau_vga.c
@@ -2,7 +2,6 @@
#include <linux/vgaarb.h>
#include <linux/vga_switcheroo.h>
-#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_helper.h>
#include "nouveau_drv.h"
--
2.39.0
next prev parent reply other threads:[~2023-01-16 13:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 13:12 [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 01/22] drm/amdgpu: Fix coding style Thomas Zimmermann
2023-01-16 18:05 ` Alex Deucher
2023-01-16 13:12 ` [PATCH 02/22] drm: Remove unnecessary include statements for drm_crtc_helper.h Thomas Zimmermann
2023-01-16 20:15 ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 03/22] drm/amdgpu: " Thomas Zimmermann
2023-01-16 20:18 ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 04/22] drm/arm/komeda: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 05/22] drm/aspeed: " Thomas Zimmermann
2023-01-16 20:27 ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 06/22] drm/ast: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 07/22] drm/bridge: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 08/22] drm/gma500: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 09/22] drm/i2c/ch7006: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 10/22] drm/ingenic: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 11/22] drm/kmb: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 12/22] drm/logicvc: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann [this message]
2023-01-16 13:12 ` [PATCH 14/22] drm/radeon: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 15/22] drm/rockchip: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 16/22] drm/shmobile: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 17/22] drm/sprd: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 18/22] drm/sun4i: " Thomas Zimmermann
2023-01-16 20:31 ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 19/22] drm/tidss: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 20/22] drm/udl: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 21/22] drm/vboxvideo: " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 22/22] drm/crtc-helper: Remove most include statements from drm_crtc_helper.h Thomas Zimmermann
2023-01-16 16:19 ` [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h Jani Nikula
2023-01-16 18:37 ` Alex Deucher
2023-01-17 8:41 ` Thomas Zimmermann
2023-01-16 20:47 ` Sam Ravnborg
2023-01-17 8:45 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116131235.18917-14-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=nouveau@lists.freedesktop.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox