From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 447B023A7 for ; Mon, 13 Mar 2023 10:19:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51AC74B3; Mon, 13 Mar 2023 03:20:32 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 710783F71A; Mon, 13 Mar 2023 03:19:47 -0700 (PDT) Date: Mon, 13 Mar 2023 10:19:41 +0000 From: Andre Przywara To: Rob Herring Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: sunxi: Use of_property_present() for testing DT property presence Message-ID: <20230313101941.366738a9@slackpad.lan> In-Reply-To: <20230310144724.1545223-1-robh@kernel.org> References: <20230310144724.1545223-1-robh@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 Mar 2023 08:47:24 -0600 Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/soc/sunxi/sunxi_mbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c > index d90e4a264b6f..1734da357ca2 100644 > --- a/drivers/soc/sunxi/sunxi_mbus.c > +++ b/drivers/soc/sunxi/sunxi_mbus.c > @@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb, > * Older DTs or SoCs who are not clearly understood need to set > * that DMA offset though. > */ > - if (of_find_property(dev->of_node, "interconnects", NULL)) > + if (of_property_present(dev->of_node, "interconnects")) > return NOTIFY_DONE; > > ret = dma_direct_set_offset(dev, PHYS_OFFSET, 0, SZ_4G);