public inbox for linux-sunxi@lists.linux.dev
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, airlied@gmail.com, daniel@ffwll.ch,
	linus.walleij@linaro.org
Cc: linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 23/25] drm/mcde: Do not use dirty GEM FB handling
Date: Mon, 13 Mar 2023 16:51:36 +0100	[thread overview]
Message-ID: <20230313155138.20584-24-tzimmermann@suse.de> (raw)
In-Reply-To: <20230313155138.20584-1-tzimmermann@suse.de>

From: Linus Walleij <linus.walleij@linaro.org>

This driver has no way to handle damage, the reason the
drm_gem_fb_create_with_dirty() was used was because I had the
ambition that the driver would only send out updates to DSI
command displays whenever something changed, so as to
minimize traffic.

It turns out this ambition with command mode isn't working
in practice because all the MCDE does is to create a
continuous stream of DSI commands and while it is possible to
send single frame updates with it, it's not been worthwhile.
So we are just setting up continuous updates.

Reported-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/dri-devel/0e789778-03ca-e3cb-9c94-e8b55573894c@suse.de/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/mcde/mcde_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 4aedb050d2a5..a592ad0d7886 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -94,7 +94,7 @@
 #define MCDE_PID_MAJOR_VERSION_MASK 0xFF000000
 
 static const struct drm_mode_config_funcs mcde_mode_config_funcs = {
-	.fb_create = drm_gem_fb_create_with_dirty,
+	.fb_create = drm_gem_fb_create,
 	.atomic_check = drm_atomic_helper_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.39.2


  parent reply	other threads:[~2023-03-13 15:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 15:51 [PATCH v2 00/25] drm/dma-helper: Add dedicated fbdev emulation Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 01/25] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 02/25] arm/hdlcd: Use GEM DMA fbdev emulation Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 03/25] arm/malidp: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 04/25] drm/aspeed: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 05/25] drm/atmel-hlcdc: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 06/25] drm/fsl-dcu: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 07/25] drm/imx/dcss: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 08/25] drm/imx: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 09/25] drm/kmb: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 10/25] drm/logicvc: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 11/25] drm/meson: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 12/25] drm/mxsfb/lcdif: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 13/25] drm/mxsfb: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 14/25] drm/sti: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 15/25] drm/stm: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 16/25] drm/sun4i: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 17/25] drm/tidss: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 18/25] drm/tilcdc: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 19/25] drm/arcpgu: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 20/25] drm/tve200: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 21/25] drm/vc4: " Thomas Zimmermann
2023-03-13 15:51 ` [PATCH v2 22/25] drm/xlnx: " Thomas Zimmermann
2023-03-13 15:51 ` Thomas Zimmermann [this message]
2023-03-13 15:51 ` [PATCH v2 24/25] drm/mcde: " Thomas Zimmermann
2023-03-13 21:40   ` Linus Walleij
2023-03-13 15:51 ` [PATCH v2 25/25] drm/pl111: " Thomas Zimmermann
2023-03-13 21:41   ` Linus Walleij
2023-03-13 21:37 ` [PATCH v2 00/25] drm/dma-helper: Add dedicated " Linus Walleij
2023-03-14 16:09 ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313155138.20584-24-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox