From: Andre Przywara <andre.przywara@arm.com>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
mripard@kernel.org, uwu@icenowy.me, samuel@sholland.org,
jernej.skrabec@gmail.com, wens@csie.org, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 2/3] dt-binding: arm: sunxi: add Anbernic RG-Nano
Date: Wed, 21 Jun 2023 10:55:20 +0100 [thread overview]
Message-ID: <20230621105520.6272fa1f@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20230620200022.295674-3-macroalpha82@gmail.com>
On Tue, 20 Jun 2023 15:00:21 -0500
Chris Morgan <macroalpha82@gmail.com> wrote:
Hi,
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The Anbernic RG-Nano is a portable handheld console from Anbernic which
> uses the Allwinner V3s SoC.
>
> Add the board to the list of known board strings.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Apart from that nit-pick about the subject prefix that Krzysztof
mentioned, this looks alright:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 013821f4a7b8..a886f8390857 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -56,6 +56,11 @@ properties:
> - const: amarula,a64-relic
> - const: allwinner,sun50i-a64
>
> + - description: Anbernic RG-Nano
> + items:
> + - const: anbernic,rg-nano
> + - const: allwinner,sun8i-v3s
> +
> - description: Auxtek T003 A10s HDMI TV Stick
> items:
> - const: allwinner,auxtek-t003
next prev parent reply other threads:[~2023-06-21 9:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 20:00 [PATCH 0/3] Add Anbernic RG-Nano Chris Morgan
2023-06-20 20:00 ` [PATCH 1/3] arm: dts: sun8i: V3s: Add pinctrl for pwm Chris Morgan
2023-06-20 23:50 ` Andre Przywara
2023-06-24 4:57 ` Icenowy Zheng
2023-06-26 8:50 ` Andre Przywara
2023-06-27 17:49 ` Chris Morgan
2023-06-20 20:00 ` [PATCH 2/3] dt-binding: arm: sunxi: add Anbernic RG-Nano Chris Morgan
2023-06-21 6:15 ` Krzysztof Kozlowski
2023-06-21 9:55 ` Andre Przywara [this message]
2023-06-20 20:00 ` [PATCH 3/3] ARM: dts: sunxi: add support for " Chris Morgan
2023-06-21 9:52 ` Andre Przywara
2023-06-27 17:49 ` Chris Morgan
2023-06-29 19:34 ` Andre Przywara
2023-06-29 22:21 ` Chris Morgan
2023-06-30 8:16 ` Maxime Ripard
2023-06-30 13:34 ` Chris Morgan
2023-07-01 0:37 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621105520.6272fa1f@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox