Re: [PATCH] drm: Explicitly include correct DT includes

Steven Price
2023-07-17T08:20:26Z

On 14/07/2023 18:45, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
[...]
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index bbada731bbbd..20c25c836198 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -4,8 +4,9 @@
> /* Copyright 2019 Collabora ltd. */
>
> #include <linux/module.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> #include <linux/pagemap.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <drm/panfrost_drm.h>
> #include <drm/drm_drv.h>

Panfrost part:

Reviewed-by: Steven Price <steven.price@arm.com>

Steve